Skip to contentSkip to conversation

TSDEV - Don't flood dmesg with removal warnings

PATCH New Parag Warudkar 1 participant 1 message Jul 27, 2007 Input drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TSDEV - Don't flood dmesg with removal warnings

tsdev.c warns about scheduled removal each time tsdev_open is called - So even for a default boot I get to see the warning 3 times -

[  340.537078] tsdev (compaq touchscreen emulation) is scheduled for removal.
[  340.537081] See Documentation/feature-removal-schedule.txt for details.
[  340.550314] tsdev (compaq touchscreen emulation) is scheduled for removal.
[  340.550318] See Documentation/feature-removal-schedule.txt for details.
[  340.565065] tsdev (compaq touchscreen emulation) is scheduled for removal.
[  340.565068] See Documentation/feature-removal-schedule.txt for details.

Move the warning to tsdev_init() from tsdev_open so we don't end up printing a large string in dmesg everytime tsdev_open is called.

drivers/input/tsdev.c 2007-07-27 09:58:09.000000000 -0400 renamed from drivers/input/tsdev.c.orig 2007-07-27 09:57:14.000000000 -0400 +0 -4
@@ -154,10 +154,6 @@
    struct tsdev *tsdev;
    int error;
 
-    printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled "
-        "for removal.\nSee Documentation/feature-removal-schedule.txt "
-        "for details.\n");
-
    if (i >= TSDEV_MINORS)
        return -ENODEV;
 
@@ -521,6 +517,9 @@
 

static int __init tsdev_init(void)
{
+ printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled "
+ "for removal.\nSee Documentation/feature-removal-schedule.txt "

+        "for details.\n");
    return input_register_handler(&tsdev_handler);
}