Skip to contentSkip to conversation

Add errno definition to pm.h

PATCH Songmao Tian 2 participants 3 messages Jul 30, 2007 – Jul 31, 2007

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; } which need errno definition

include/linux/pm.h +0 -0
index e52f6f8..48b71ba 100644
@@ -25,6 +25,7 @@
 

#include <linux/list.h>
#include <asm/atomic.h>
+#include <asm/errno.h>

/*
* Power management requests... these are passed to pm_send_all() and
friends.

#1 lore raw
Quoted 11 lines · Songmao Tian

commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; } which need errno definition

include/linux/pm.h +0 -0
index e52f6f8..48b71ba 100644

include/linux/pm.h line 29

Quoted 5 lines
include/linux/pm.h +1 -0
@@ -25,6 +25,7 @@
 
 #include <linux/list.h>
 #include <asm/atomic.h>
+#include <asm/errno.h>
 

You should be including <linux/errno.h> which then includes the architecture-specific file. This patch should be rejected.

-Steve

#2 lore raw
Quoted 22 lines · Steven J. Hill
Quoted 11 lines · Songmao Tian

commit 296699de6bdc717189a331ab6bbe90e05c94db06 add
static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; } which need errno definition

include/linux/pm.h +0 -0
index e52f6f8..48b71ba 100644

include/linux/pm.h line 30

Quoted 6 lines
include/linux/pm.h +1 -0
@@ -25,6 +25,7 @@
 
 #include <linux/list.h>
 #include <asm/atomic.h>
+#include <asm/errno.h>
 
 

You should be including <linux/errno.h> which then includes the architecture-specific file. This patch should be rejected.

Quoted 5 lines

-Steve

Oh I see:)

Songmao Tian