Skip to contentSkip to conversation

Adding drivers/usb/misc/iowarrior.c to the Makefile

PATCH In review Nico Erfurth 3 participants 4 messages Aug 2, 2007 – Aug 7, 2007 USB

lore
Share & tools
lore

Nico Erfurth

author
#0 lore raw

PATCH 1/1 Adding drivers/usb/misc/iowarrior.c to the Makefile

This patch adds the new iowarrior module to the Makefile in drivers/usb. Currently the module isn't build unless another driver from usb/misc is selected.

Signed-off-by Nico Erfurth <[email protected]>

---

drivers/usb/Makefile 2007-08-02 22:20:57.000000000 +0200 renamed from drivers/usb/Makefile.orig 2007-08-02 21:54:16.000000000 +0200 +1 -0
@@ -38,6 +38,7 @@ obj-$(CONFIG_USB_EMI26)               += misc/
 obj-$(CONFIG_USB_EMI62)                += misc/
 obj-$(CONFIG_USB_FTDI_ELAN)    += misc/
 obj-$(CONFIG_USB_IDMOUSE)      += misc/
+obj-$(CONFIG_USB_IOWARRIOR)    += misc/
 obj-$(CONFIG_USB_LCD)          += misc/
 obj-$(CONFIG_USB_LD)           += misc/
 obj-$(CONFIG_USB_LED)          += misc/
#1 lore raw
Quoted 3 lines · Nico Erfurth

This patch adds the new iowarrior module to the Makefile in drivers/usb. Currently the module isn't build unless another driver from usb/misc is selected.

Can we please just always vist misc like this:
obj-y := misc/

Then we do not need to repeat this stuff in both drivers/usb/Makefile and drivers/usb/misc/Makefile

Thanks,
Sam

#2 lore raw
Quoted 10 lines · Sam Ravnborg
Quoted 3 lines · Nico Erfurth

This patch adds the new iowarrior module to the Makefile in drivers/usb. Currently the module isn't build unless another driver from usb/misc is selected.

Can we please just always vist misc like this:
obj-y := misc/

Then we do not need to repeat this stuff in both drivers/usb/Makefile and drivers/usb/misc/Makefile

For some reason, we didn't do that because people were upset at us going into these directories when they didn't have any usb misc devices selected? Or something like that, I really can't remember anymore.

But if you think it would be best to do that, I'd be glad to make the change.

thanks,

greg k-h

#3 lore raw
Quoted 12 lines · Greg KH
Quoted 10 lines · Sam Ravnborg
Quoted 3 lines · Nico Erfurth

This patch adds the new iowarrior module to the Makefile in drivers/usb. Currently the module isn't build unless another driver from usb/misc is selected.

Can we please just always vist misc like this:
obj-y := misc/

Then we do not need to repeat this stuff in both drivers/usb/Makefile and drivers/usb/misc/Makefile

Quoted 6 lines

For some reason, we didn't do that because people were upset at us going into these directories when they didn't have any usb misc devices selected? Or something like that, I really can't remember anymore.

But if you think it would be best to do that, I'd be glad to make the change.

Please do - we have too much duplication between the two files now.

Sam