au88x0: mem leak fix in snd_vortex_create()
PATCH 1/1 au88x0: mem leak fix in snd_vortex_create()
Hi,
In sound/pci/au88x0/au88x0.c::snd_vortex_create() :
The Coverity checker found that if we allocate storage for 'chip' but then leave via the regions_out: label, then we end up leaking the storage allocated for 'chip'.
I believe simply freeing 'chip' before the "return err;" line is all we need to fix this, but please double-check me :)
---
sound/pci/au88x0/au88x0.c +1 -0
@@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip)pci_disable_device (chip->pci_dev);//FIXME: this not the right place to unregister the gameport vortex_gameport_unregister (chip); +kfree (chip);return err; }
Quoted 16 lines · Jesper Juhl
In sound/pci/au88x0/au88x0.c::snd_vortex_create() :
The Coverity checker found that if we allocate storage for 'chip' but then leave via theregions_out: label, then we end up leaking the storage allocated for 'chip'.
I believe simply freeing 'chip' before the "return err;" line is all we need to fix this, but please double-check me :)Signed-off-by Jesper Juhl <[email protected]>---
sound/pci/au88x0/au88x0.c +0
-0
sound/pci/au88x0/au88x0.c snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip) · line 237
Quoted 6 lines
sound/pci/au88x0/au88x0.c +1
-0@@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip)pci_disable_device (chip->pci_dev);//FIXME: this not the right place to unregister the gameport vortex_gameport_unregister (chip); +kfree (chip);return err; }
ACK.
Rene.
Takashi Iwai
AppliedAt Sat, 4 Aug 2007 02:09:25 +0200,
Quoted 11 lines · Jesper Juhl
Hi,
In sound/pci/au88x0/au88x0.c::snd_vortex_create() :
The Coverity checker found that if we allocate storage for 'chip' but then leave via theregions_out: label, then we end up leaking the storage allocated for 'chip'.
I believe simply freeing 'chip' before the "return err;" line is all we need to fix this, but please double-check me :)
Quoted 1 line
Signed-off-by Jesper Juhl <[email protected]>
Thanks, applied to ALSA tree now.
Takashi