lapic3 branch rebased

DISCUSSION Avi Kivity 3 participants 10 messages Aug 13, 2007 – Aug 19, 2007 6 messages not in the archive KVM

Share & tools

Avi Kivity

author

2007-08-13 15:31 UTC #0 lore raw

lapic3 has been rebased, compile tested, and pushed. note that this does not include the patch-folding work I'd like to do before merging into master.

Signature · 8 lines

error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

A message that is not in the archive (sent off-list or not yet received): 46C07949.6090001-atKUWr5tajBWk0Htik3J/[email protected]

Dong, Eddie

2007-08-14 03:28 UTC #2 lore raw

Quoted 4 lines · Avi Kivity

lapic3 has been rebased, compile tested, and pushed. note that this does not include the patch-folding work I'd like to do before merging into master.

Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel free to
fold the patches and wanna to see merging soon :-)
thx,eddie

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/

A message that is not in the archive (sent off-list or not yet received): 10EA09EFD8728347A513008B6B0DA77A01E8E414-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org

Avi Kivity

author

2007-08-14 07:59 UTC #4 lore raw

Quoted 11 lines · Eddie

Quoted 5 lines · Avi Kivity
lapic3 has been rebased, compile tested, and pushed. note that this does not include the patch-folding work I'd like to do before merging into master.
Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel free to
fold the patches and wanna to see merging soon :-)

FC6 SMP boots with one cpu only. With -no-kvm-irqchip it boots fine.

Are you using the bios provided by kvm or the hacked one? That may be the problem.

(I'm proceeding with the folding anyway)

Signature · 8 lines

error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Avi Kivity

author

2007-08-14 10:00 UTC #5 lore raw

In reply to a message not in the archive

Quoted 7 lines · Eddie

Quoted 5 lines · Avi Kivity
lapic3 has been rebased, compile tested, and pushed. note that this does not include the patch-folding work I'd like to do before merging into master.

Quoted 5 lines

Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel free to
fold the patches and wanna to see merging soon :-)
thx,eddie

Some progress -- I rebased lapic3 and folded some patches; new branch called lapic4, 100% equivalent to lapic3 in final result.

Patches folded:

KVM: cleanups on user/kernel irqchip checking
KVM: Fix state save bug
KVM: remove status in kvm_lapic structure
KVM: Restore apic_base to struct kvm_vcpu
KVM: Fix crash due to apic being accessed beore initialization
KVM: Add missing #include
KVM: IOAPIC: Temporarily avoid reissuing irq on EOI
KVM: IOAPIC: Avoid delivering apic messages to non-existent vcpus
KVM: Rename KVM_CAP_PIC to KVM_CAP_IRQCHIP
KVM: Fix minor warnings in lapic patch
KVM: Fix oops destroying VM with virtual PIC

Patches kept:

KVM: pending irq save/restore
KVM: in-kernel LAPIC save and restore support
KVM: in-kernel IOAPIC save and restore support
KVM: Bypass irq_pending get/set when using in kernel irqchip
KVM: Add get/set irqchip ioctls for in-kernel PIC live migration support
KVM: Protect in-kernel pio using kvm->lock
KVM: Emulate hlt in the kernel
KVM: In-kernel I/O APIC model
KVM: Emulate local APIC in kernel
KVM: Define and use cr8 access functions
KVM: Add support for in-kernel PIC emulation

I plan to do some minor renaming and code movement (to remove artifacts like a line being moved by a patch for no reason). Will be in a new branch lapic5.

Signature · 8 lines

error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

A message that is not in the archive (sent off-list or not yet received): 46C17D21.607-atKUWr5tajBWk0Htik3J/[email protected]

Avi Kivity

author

2007-08-14 12:08 UTC #7 lore raw

Quoted 43 lines · Avi Kivity

Quoted 10 lines · Eddie
Quoted 4 lines · Avi Kivity
lapic3 has been rebased, compile tested, and pushed. note that this does not include the patch-folding work I'd like to do before merging into master.
Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel free to fold the patches and wanna to see merging soon :-) thx,eddie
Some progress -- I rebased lapic3 and folded some patches; new branch called lapic4, 100% equivalent to lapic3 in final result.
Patches folded:
KVM: cleanups on user/kernel irqchip checking
KVM: Fix state save bug
KVM: remove status in kvm_lapic structure
KVM: Restore apic_base to struct kvm_vcpu
KVM: Fix crash due to apic being accessed beore initialization
KVM: Add missing #include
KVM: IOAPIC: Temporarily avoid reissuing irq on EOI
KVM: IOAPIC: Avoid delivering apic messages to non-existent vcpus
KVM: Rename KVM_CAP_PIC to KVM_CAP_IRQCHIP
KVM: Fix minor warnings in lapic patch
KVM: Fix oops destroying VM with virtual PIC
Patches kept:
KVM: pending irq save/restore
KVM: in-kernel LAPIC save and restore support
KVM: in-kernel IOAPIC save and restore support
KVM: Bypass irq_pending get/set when using in kernel irqchip
KVM: Add get/set irqchip ioctls for in-kernel PIC live migration support
KVM: Protect in-kernel pio using kvm->lock
KVM: Emulate hlt in the kernel
KVM: In-kernel I/O APIC model
KVM: Emulate local APIC in kernel
KVM: Define and use cr8 access functions
KVM: Add support for in-kernel PIC emulation

Quoted 4 lines

I plan to do some minor renaming and code movement (to remove artifacts like a line being moved by a patch for no reason). Will be in a new branch lapic5.

This is now done, containing the following changes:

- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
- rearranged struct kvm_vcpu to reduce changes relative ro master

However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL). I'll debug the Linux problem first.

Signature · 8 lines

error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

A message that is not in the archive (sent off-list or not yet received): 46C19B51.9010502-atKUWr5tajBWk0Htik3J/[email protected]

Zhao, Yunfeng

2007-08-16 08:36 UTC #9 lore raw

Hi, Avi
In my testing for lapic5, I can boot Windows guest with UP ACPI HAL. And I cannot boot Windows Guest with SMP ACPI HAL even with enabling smp=1

Thanks
Yunfeng

Quoted 11 lines

This is now done, containing the following changes:
- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
- rearranged struct kvm_vcpu to reduce changes relative ro master
However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL). I'll debug the Linux problem first.

Quoted 5 lines

--
error compiling committee.c: too many arguments to function
-----------------------------------------------------------------------

Quoted 8 lines

This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Zhao, Yunfeng

2007-08-16 09:00 UTC #10 lore raw

In reply to a message not in the archive

Hi,Avi
Do you see any timer issue on Lapic5?
On lapic5 I found that linux guest has a big time lag while running kernel build. With network time the time cost is about 450s, but guest timer reports 899s.

I didn't meet the issue on lapic3.

Thanks
Yunfeng

Quoted 72 lines

-----Original Message-----
From: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org [mailto:kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Avi Kivity
Sent: 2007年8月14日 20:09
To: Dong, Eddie
Cc: kvm-devel; He, Qing
Subject: Re: [kvm-devel] lapic3 branch rebased
Quoted 43 lines · Avi Kivity
Quoted 10 lines · Eddie
Quoted 4 lines · Avi Kivity
lapic3 has been rebased, compile tested, and pushed. note that this does not include the patch-folding work I'd like to do before merging into master.
Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel free to fold the patches and wanna to see merging soon :-) thx,eddie
Some progress -- I rebased lapic3 and folded some patches; new branch called lapic4, 100% equivalent to lapic3 in final result.
Patches folded:
KVM: cleanups on user/kernel irqchip checking
KVM: Fix state save bug
KVM: remove status in kvm_lapic structure
KVM: Restore apic_base to struct kvm_vcpu
KVM: Fix crash due to apic being accessed beore initialization
KVM: Add missing #include
KVM: IOAPIC: Temporarily avoid reissuing irq on EOI
KVM: IOAPIC: Avoid delivering apic messages to non-existent vcpus
KVM: Rename KVM_CAP_PIC to KVM_CAP_IRQCHIP
KVM: Fix minor warnings in lapic patch
KVM: Fix oops destroying VM with virtual PIC
Patches kept:
KVM: pending irq save/restore
KVM: in-kernel LAPIC save and restore support
KVM: in-kernel IOAPIC save and restore support
KVM: Bypass irq_pending get/set when using in kernel irqchip
KVM: Add get/set irqchip ioctls for in-kernel PIC live migration support
KVM: Protect in-kernel pio using kvm->lock
KVM: Emulate hlt in the kernel
KVM: In-kernel I/O APIC model
KVM: Emulate local APIC in kernel
KVM: Define and use cr8 access functions
KVM: Add support for in-kernel PIC emulation
Quoted 4 lines
I plan to do some minor renaming and code movement (to remove artifacts like a line being moved by a patch for no reason). Will be in a new branch lapic5.
This is now done, containing the following changes:
- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
- rearranged struct kvm_vcpu to reduce changes relative ro master
However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL). I'll debug the Linux problem first.
--
error compiling committee.c: too many arguments to function

Quoted 9 lines

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

A message that is not in the archive (sent off-list or not yet received): 10EA09EFD8728347A513008B6B0DA77AA3F00B-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org

Avi Kivity

author

2007-08-19 07:52 UTC #12 lore raw

Quoted 8 lines · Yunfeng

Hi,Avi
Do you see any timer issue on Lapic5?
On lapic5 I found that linux guest has a big time lag while running kernel build. With network time the time cost is about 450s, but guest timer reports 899s.
I didn't meet the issue on lapic3.

No, I didn't. lapic3 and lapic5 shouldn't be that different...

Signature · 1 line

error compiling committee.c: too many arguments to function

_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Dong, Eddie

2007-08-18 10:32 UTC #13 lore raw

In reply to a message not in the archive

Quoted 11 lines

- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
- rearranged struct kvm_vcpu to reduce changes relative ro master
However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL).
I'll debug the Linux problem first.

Avi:
I am just back from a travel and want to know what is next in
your plan.
From the mailing list the XP ACPI HAL issue is fixed by Qing,
isn't it?
thx,eddie

A message that is not in the archive (sent off-list or not yet received): 10EA09EFD8728347A513008B6B0DA77A01EE24C5-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org

Avi Kivity

author

2007-08-19 07:31 UTC #15 lore raw

Quoted 11 lines · Eddie

Quoted 11 lines
- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
- rearranged struct kvm_vcpu to reduce changes relative ro master
However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL).
I'll debug the Linux problem first.

Quoted 6 lines

Avi:
I am just back from a travel and want to know what is next in
your plan.
From the mailing list the XP ACPI HAL issue is fixed by Qing,
isn't it?

I assume it is (haven't checked myself). But of course we need to get guest smp working.

I made some progress but it isn't working yet. If you have something, please post it.

Signature · 8 lines

error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/