Skip to contentSkip to conversation

Fix check for return value of create_pid_namespace

PATCH New Pavel Emelyanov 1 participant 1 message Aug 17, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix check for return value of create_pid_namespace

The function in question returns ERR_PTR-s to indicate the error, while the caller checks for return value to be NULL.

Found during testing the OpenVZ kernel with pid namespaces.

Cc Sukadev Bhattiprolu <sukadev-r/[email protected]>
Cc Oleg Nesterov <[email protected]>

---
kernel/pid.c | 2 +-

1 files changed, 1 insertion(+), 1 deletion(-)
kernel/pid.c +0 -0
index faad017..cb1f3cb 100644
@@ -543,7 +543,7 @@ struct pid_namespace *copy_pid_ns(unsign
		goto out_put;

	new_ns = create_pid_namespace(old_ns->level + 1);
-	if (new_ns != NULL)
+	if (!IS_ERR(new_ns))
		new_ns->parent = get_pid_ns(old_ns);

out_put: