MMC: OMAP: Introduces new structures for MMC multislot support.
Subsystems (2)
PATCH 1/17 MMC: OMAP: Introduces new structures for MMC multislot support.
From: Juha Yrjola <[email protected]>
Introduces new structures for MMC multislot support.
Introduces new structures for MMC multislot support.
drivers/mmc/host/omap.c +27 -6
@@ -32,6 +32,7 @@#include <asm/mach-types.h> #include <asm/arch/board.h> +#include <asm/arch/mmc.h> #include <asm/arch/gpio.h> #include <asm/arch/dma.h> #include <asm/arch/mux.h>
@@ -99,6 +100,26 @@static int mmc_omap_enable_poll =1 ; +struct mmc_omap_host ; + +struct mmc_omap_slot { +int id; +unsigned int vdd; +u16 saved_con; +u16 bus_mode; +unsigned int fclk_freq; +unsigned powered:1 ; + +struct work_struct switch_work; +struct timer_list switch_timer; +unsigned cover_open; + +struct mmc_request * mrq; +struct mmc_omap_host * host; +struct mmc_host * mmc; +struct omap_mmc_slot_data *pdata; +}; +struct mmc_omap_host {int initialized;int suspended;
@@ -132,13 +153,13 @@ struct mmc_omap_host {struct timer_list dma_timer;unsigned dma_len; -short power_pin; -short wp_pin; +struct mmc_omap_slot * slots[OMAP_MMC_MAX_SLOTS ]; +struct mmc_omap_slot * current_slot; +spinlock_t slot_lock; +wait_queue_head_t slot_wq; +int nr_slots; -int switch_pin; -struct work_struct switch_work; -struct timer_list switch_timer; -int switch_last_state; +struct omap_mmc_platform_data *pdata; }; static inline int
Quoted 1 line · Carlos Aguiar
Introduces new structures for MMC multislot support.
Seems like #1 and #2 should be a single patch, since after #1 it won't compile ...
Quoted 5 lines · David Brownell
Quoted 1 line · Carlos Aguiar
Introduces new structures for MMC multislot support.
Seems like #1 and #2 should be a single patch, since after #1 it won't compile ...
... and maybe #3, and ... ?
Also, this doesn't look to me primarily like "multislot" support. It's also "stop relying on GPIOs" for various things that newer boards handle with external chips (like CD and WP switches), and "move board-specific code out of the MMC driver"...
- Dave
Quoted 11 lines · ext David Brownell
Quoted 7 lines · David Brownell
Quoted 2 lines · Carlos Aguiar
Introduces new structures for MMC multislot support.
Seems like #1 and #2 should be a single patch, since after #1 it won't compile ...
Hi Dave,
Quoted 2 lines
... and maybe #3, and ... ?
You're right! But this 'level of granularity' of the patches was requested by Tony.
Quoted 6 lines
Also, this doesn't look to me primarily like "multislot" support. It's also "stop relying on GPIOs" for various things that newer boards handle with external chips (like CD and WP switches), and "move board-specific code out of the MMC driver"...
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC slots.
BR,
Carlos.
Quoted 8 lines
- Dave
_______________________________________________
Linux-omap-open-source mailing list
[email protected]
http://linux.omap.com/mailman/listinfo/linux-omap-open-source
Signature · 7 lines
Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]
Quoted 12 lines · Carlos Aguiar
Quoted 11 lines · ext David Brownell
Quoted 7 lines · David Brownell
Quoted 2 lines · Carlos Aguiar
Introduces new structures for MMC multislot support.
Seems like #1 and #2 should be a single patch, since after #1 it won't compile ...
Quoted 5 lines
Hi Dave,
Quoted 2 lines
... and maybe #3, and ... ?
You're right! But this 'level of granularity' of the patches was requested by Tony.
Huh? Naturally the patch series should compile and work after each step no matter what "level of granularity".
Quoted 8 lines
Quoted 6 lines
Also, this doesn't look to me primarily like "multislot" support. It's also "stop relying on GPIOs" for various things that newer boards handle with external chips (like CD and WP switches), and "move board-specific code out of the MMC driver"...
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC slots.
Carlos, what Dave is saying above is that the patches don't do what you have in the patch description. You should try to do a series of independent easy to read patches that match the patch description.
Regards,
Tony
Quoted 43 lines · ext Tony Lindgren
Quoted 17 lines · Carlos Aguiar
Quoted 6 lines · ext David Brownell
Quoted 3 lines · David Brownell
On Friday 17 August 2007, Carlos Aguiar wrote:
Quoted 9 lines
Quoted 7 lines
Quoted 3 lines
Introduces new structures for MMC multislot support.
Seems like #1 and #2 should be a single patch, since after #1 it won't compile ...
Quoted 8 lines
Hi Dave,
Quoted 3 lines
... and maybe #3, and ... ?
You're right! But this 'level of granularity' of the patches was requested by Tony.
Huh? Naturally the patch series should compile and work after each step no matter what "level of granularity".
Quoted 10 lines
Quoted 7 lines
Also, this doesn't look to me primarily like "multislot" support. It's also "stop relying on GPIOs" for various things that newer boards handle with external chips (like CD and WP switches), and "move board-specific code out of the MMC driver"...
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC slots.
Quoted 9 lines
Carlos, what Dave is saying above is that the patches don't do what you have in the patch description. You should try to do a series of independent easy to read patches that match the patch description.
Regards,
Tony
Ok Tony,
I'll re-work on the series in order to have the code compiling and working after each patch applied and each patch having a description that matches what is doing.
BR,
Carlos.
Signature · 7 lines
Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]
Hi Carlos,
Quoted 2 lines
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC slots.
Does this mean that supporting one or more MMC memory cards sharing the same bus?
Regards,
Madhu
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Carlos Aguiar
Sent: Monday, September 03, 2007 7:26 PM
To: ext David Brownell
Cc: [email protected]
Subject: Re: [01/17 PATCH] MMC: OMAP: Introduces new structures for MMC multislot support.
Quoted 11 lines · ext David Brownell
Quoted 7 lines · David Brownell
Quoted 2 lines · Carlos Aguiar
Introduces new structures for MMC multislot support.
Seems like #1 and #2 should be a single patch, since after #1 it won't compile ...
Hi Dave,
Quoted 2 lines
... and maybe #3, and ... ?
You're right! But this 'level of granularity' of the patches was requested by Tony.
Quoted 6 lines
Also, this doesn't look to me primarily like "multislot" support. It's also "stop relying on GPIOs" for various things that newer boards handle with external chips (like CD and WP switches), and "move board-specific code out of the MMC driver"...
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC slots.
BR,
Carlos.
Quoted 8 lines
- Dave
_______________________________________________
Linux-omap-open-source mailing list
[email protected]
http://linux.omap.com/mailman/listinfo/linux-omap-open-source
Signature · 12 lines
Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected] _______________________________________________ Linux-omap-open-source mailing list [email protected] http://linux.omap.com/mailman/listinfo/linux-omap-open-source
Quoted 2 lines · ext Madhusudhan Chikkature Rajashekar
Hi Carlos,
Hi Madhu,
Quoted 7 lines
Quoted 4 lines
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC slots.
Does this mean that supporting one or more MMC memory cards sharing the same bus?
Could you please re-work your question? I couldn't get it nicely... But even though, if I got it right you're asking if this code controls the concurrency between both slots sharing the same bus. Is that right? If so, yes. This code does it.
BR,
Carlos.
Quoted 64 lines
Regards,
Madhu-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Carlos Aguiar
Sent: Monday, September 03, 2007 7:26 PM
To: ext David Brownell
Cc: [email protected]
Subject: Re: [01/17 PATCH] MMC: OMAP: Introduces new structures for MMC multislot support.Quoted 6 lines · ext David Brownell
Quoted 3 lines · David Brownell
On Friday 17 August 2007, Carlos Aguiar wrote:
Quoted 9 lines
Quoted 7 lines
Quoted 3 lines
Introduces new structures for MMC multislot support.
Seems like #1 and #2 should be a single patch, since after #1 it won't compile ...
Hi Dave,
Quoted 3 lines
... and maybe #3, and ... ?
You're right! But this 'level of granularity' of the patches was requested by Tony.
Quoted 7 lines
Also, this doesn't look to me primarily like "multislot" support. It's also "stop relying on GPIOs" for various things that newer boards handle with external chips (like CD and WP switches), and "move board-specific code out of the MMC driver"...
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC slots.
BR,
Carlos.
Quoted 9 lines
- Dave
_______________________________________________
Linux-omap-open-source mailing list
[email protected]
http://linux.omap.com/mailman/listinfo/linux-omap-open-source
Signature · 7 lines
Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]
Hi,
Quoted 3 lines
If I got it right you're asking if this code controls the concurrency between both slots sharing the same bus. Is that right? If so, yes. This code does it.
Yes. That is what I meant.
Thanks for the clarification.
Regards,
Madhu
-----Original Message-----
From: Carlos Aguiar [mailto:[email protected]]
Sent: Tuesday, September 04, 2007 8:19 PM
To: ext Madhusudhan Chikkature Rajashekar
Cc: [email protected]
Subject: Re: [01/17 PATCH] MMC: OMAP: Introduces new structures for MMC multislot support.
Quoted 2 lines · ext Madhusudhan Chikkature Rajashekar
Hi Carlos,
Hi Madhu,
Quoted 3 lines
Quoted 3 lines
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC
slots.
Quoted 2 lines
Quoted 1 line
Does this mean that supporting one or more MMC memory cards sharing the
same
Quoted 2 lines
bus?
Could you please re-work your question? I couldn't get it nicely... But even though, if I got it right you're asking if this code controls the concurrency between both slots sharing the same bus. Is that right? If so, yes. This code does it.
BR,
Carlos.
Quoted 45 lines
Regards,
Madhu-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Carlos Aguiar
Sent: Monday, September 03, 2007 7:26 PM
To: ext David Brownell
Cc: [email protected]
Subject: Re: [01/17 PATCH] MMC: OMAP: Introduces new structures for MMC multislot support.Quoted 6 lines · ext David Brownell
Quoted 3 lines · David Brownell
On Friday 17 August 2007, Carlos Aguiar wrote:
Quoted 9 lines
Quoted 7 lines
Quoted 3 lines
Introduces new structures for MMC multislot support.
Seems like #1 and #2 should be a single patch, since after #1 it won't compile ...
Hi Dave,
Quoted 3 lines
... and maybe #3, and ... ?
You're right! But this 'level of granularity' of the patches was requested by Tony.
Quoted 7 lines
Also, this doesn't look to me primarily like "multislot" support. It's also "stop relying on GPIOs" for various things that newer boards handle with external chips (like CD and WP switches), and "move board-specific code out of the MMC driver"...
Quoted 2 lines
The concept of multislot applied here is to provide a code (and needed modifications) that runs OMAP platforms with a single and/or two MMC
slots.
Quoted 17 lines
BR,
Carlos.
Quoted 9 lines
- Dave
_______________________________________________
Linux-omap-open-source mailing list
[email protected]
http://linux.omap.com/mailman/listinfo/linux-omap-open-source
Signature · 7 lines
Carlos Eduardo Aguiar Nokia Institute of Technology - INdT Open Source Mobile Research Center - OSMRC - Manaus Core Team Phone: +55 92 2126-1079 Mobile: +55 92 8127-1797 E-mail: [email protected]