Skip to contentSkip to conversation

(2/5) Fix lvconvert to pass correct parameter to allocate_extents()

PATCH New Jun'ichi Nomura 2 participants 2 messages Aug 21, 2007 – Aug 22, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 (2/5) Fix lvconvert to pass correct parameter to allocate_extents()

This patch fixes lvconvert_mirrors() to pass correct set of parameters to allocate_extents().

It used to pass (length of LV * number of mirrors) as 'extents' parameter of allocate_extents().

Though the parameter was wrong, the allocation function somehow worked because it also passed segtype "striped" instead of "mirror".

Thanks,

Signature · 8 lines
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvm2-lvconvert-fix-wrong-parameter-to-allocator.patch
Type: text/x-patch
Size: 3115 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20070821/66811d8b/attachment.bin>
#1 lore raw

PATCH 1/1 (2/5) Fix lvconvert to pass correct parameter to allocate_extents()

Quoted 2 lines · Jun'ichi Nomura

This patch fixes lvconvert_mirrors() to pass correct set of parameters to allocate_extents().

lvcreate and lvextend do this correctly as intended.

lvconvert (the new code) should do things the same way as those existing callers.

Alasdair

Signature · 1 line
agk at redhat.com