Skip to contentSkip to conversation

sgiseeq: Fix return type of sgiseeq_remove

NET Applied Ralf Baechle 2 participants 2 messages Aug 22, 2007 – Aug 25, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ralf Baechle

author
#0 lore raw

The driver remove method needs to return an int not void. This was just never noticed because usually this driver is not being built as a module.

Signed-off-by Ralf Baechle <[email protected]>
drivers/net/sgiseeq.c +3 -1
index 384b468..0fb74cb 100644
@@ -726,7 +726,7 @@ err_out:
 	return err;
 }
 
-static void __exit sgiseeq_remove(struct platform_device *pdev)
+static int __exit sgiseeq_remove(struct platform_device *pdev)
 {
 	struct net_device *dev = platform_get_drvdata(pdev);
 	struct sgiseeq_private *sp = netdev_priv(dev);

@@ -735,6 +735,8 @@ static void __exit sgiseeq_remove(struct platform_device *pdev)
 	free_page((unsigned long) sp->srings);
 	free_netdev(dev);
 	platform_set_drvdata(pdev, NULL);
+
+	return 0;
 }
 
 static struct platform_driver sgiseeq_driver = {
Applied
#1 lore raw
Quoted 4 lines · Ralf Baechle

The driver remove method needs to return an int not void. This was just never noticed because usually this driver is not being built as a module.

Signed-off-by Ralf Baechle <[email protected]>

applied