Skip to contentSkip to conversation

cxgb3 - engine microcode update

PATCH In review Divy Le Ray 3 participants 6 messages Aug 22, 2007 – Sep 5, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Divy Le Ray

author
#0 lore raw

PATCH 9/11 cxgb3 - engine microcode update

From: Divy Le Ray <[email protected]>

Load microcode engine when the interface
is configured up.
Bump up version to 1.1.0.
Allow the driver to be and running with
older microcode images.
Allow ethtool to log the microcode version.

Signed-off-by Divy Le Ray <[email protected]>

---

 drivers/net/cxgb3/common.h     |    8 ++-
 drivers/net/cxgb3/cxgb3_main.c |  116 ++++++++++++++++++++++++----------------
 drivers/net/cxgb3/t3_hw.c      |   43 +++++++++++++--
 3 files changed, 113 insertions(+), 54 deletions(-)
drivers/net/cxgb3/common.h +5 -3
index d54446f..b665b20 100644
@@ -127,8 +127,8 @@ enum {				/* adapter interrupt-maintained statistics */
 
 enum {
 	TP_VERSION_MAJOR	= 1,
-	TP_VERSION_MINOR	= 0,
-	TP_VERSION_MICRO	= 44
+	TP_VERSION_MINOR	= 1,
+	TP_VERSION_MICRO	= 0
 };
 
 #define S_TP_VERSION_MAJOR		16

@@ -438,6 +438,7 @@ enum {					    /* chip revisions */
 	T3_REV_A  = 0,
 	T3_REV_B  = 2,
 	T3_REV_B2 = 3,
+	T3_REV_C  = 4,
 };
 
 struct trace_params {

@@ -682,7 +683,8 @@ const struct adapter_info *t3_get_adapter_info(unsigned int board_id);
 int t3_seeprom_read(struct adapter *adapter, u32 addr, u32 *data);
 int t3_seeprom_write(struct adapter *adapter, u32 addr, u32 data);
 int t3_seeprom_wp(struct adapter *adapter, int enable);
-int t3_check_tpsram_version(struct adapter *adapter);
+int t3_get_tp_version(struct adapter *adapter, u32 *vers);
+int t3_check_tpsram_version(struct adapter *adapter, int *must_load);
 int t3_check_tpsram(struct adapter *adapter, u8 *tp_ram, unsigned int size);
 int t3_set_proto_sram(struct adapter *adap, u8 *data);
 int t3_read_flash(struct adapter *adapter, unsigned int addr,
drivers/net/cxgb3/cxgb3_main.c +71 -45

170 lines not on this page · raw message

drivers/net/cxgb3/t3_hw.c +37 -6

66 lines not on this page · raw message

#1 lore raw
Quoted 10 lines · Divy Le Ray

From: Divy Le Ray <[email protected]>

Load microcode engine when the interface
is configured up.
Bump up version to 1.1.0.
Allow the driver to be and running with
older microcode images.
Allow ethtool to log the microcode version.

Signed-off-by Divy Le Ray <[email protected]>

ACK patches 9-14, but dropped, since they do not apply to #upstream (probably due to fixes sent into 2.6.23-rc)

#2 lore raw
Quoted 10 lines · Jeff Garzik
Quoted 9 lines · Divy Le Ray

From: Divy Le Ray <[email protected]>

Load microcode engine when the interface
is configured up.
Bump up version to 1.1.0.
Allow the driver to be and running with
older microcode images.
Allow ethtool to log the microcode version.

Quoted 4 lines
Quoted 1 line
Signed-off-by Divy Le Ray <[email protected]>

ACK patches 9-14, but dropped, since they do not apply to #upstream (probably due to fixes sent into 2.6.23-rc)

Hey Jeff,

I think 9-14 still need to be incorporated. I don't see them in your upstream branch, and they aren't in linus' tree either.

Steve.

#3 lore raw
Quoted 15 lines · Steve Wise
Quoted 12 lines · Jeff Garzik
Quoted 10 lines · Divy Le Ray

From: Divy Le Ray <[email protected]>

Load microcode engine when the interface
is configured up.
Bump up version to 1.1.0.
Allow the driver to be and running with
older microcode images.
Allow ethtool to log the microcode version.

Signed-off-by Divy Le Ray <[email protected]>
Quoted 8 lines
Quoted 3 lines

ACK patches 9-14, but dropped, since they do not apply to #upstream (probably due to fixes sent into 2.6.23-rc)

Hey Jeff,

I think 9-14 still need to be incorporated. I don't see them in your upstream branch, and they aren't in linus' tree either.

I am not the blocker here. Re-read the email you quoted.

Jeff, still waiting for the patches

#4 lore raw
Quoted 16 lines · Jeff Garzik
Quoted 15 lines · Steve Wise
Quoted 13 lines · Jeff Garzik
Quoted 10 lines · Divy Le Ray

From: Divy Le Ray <[email protected]>

Load microcode engine when the interface
is configured up.
Bump up version to 1.1.0.
Allow the driver to be and running with
older microcode images.
Allow ethtool to log the microcode version.

Signed-off-by Divy Le Ray <[email protected]>

ACK patches 9-14, but dropped, since they do not apply to #upstream (probably due to fixes sent into 2.6.23-rc)

Quoted 8 lines
Quoted 3 lines

Hey Jeff,

I think 9-14 still need to be incorporated. I don't see them in your upstream branch, and they aren't in linus' tree either.

I am not the blocker here. Re-read the email you quoted.

Jeff, still waiting for the patches

Ok. I didn't get that you were stating that the patches should be resent because they're busted :)

Steve.

author
#5 lore raw
In reply to Jeff Garzik
Quoted 8 lines
Quoted 5 lines

I think 9-14 still need to be incorporated. I don't see them in your upstream branch, and they aren't in linus' tree either.

I am not the blocker here.

Sorry for the delay - again.
I'm resubmitting these patches against net#upstream.

Cheers,
Divy