fdt command: can't set a value-less property
Hello,
I'm playing with the fdt command in recent (60174746) U-Boot and I can't set a property that does not have a value. Documentation/powerpc/booting-without-of.txt" says "A property can have a value or not.", and fdt help suggests the same:
fdt set <path> <prop> [<val>] - Set <property> [to <val>]
However, I am getting:
=> fdt mknode / testnode
=> fdt list /testnode
testnode {
};
=> fdt set /testnode testprop
Usage:
fdt - flattened device tree utility commands
=> fdt list /testnode
testnode {
};
Setting a property with value works:
=> fdt set /testnode testprop "testvalue"
=> fdt list /testnode
testnode {
testprop=""testvalue"";
};Am I doing something wrong, or is it a bug?
Regards,
Bartlomiej
Quoted 26 lines · Bartlomiej Sieka
Hello,
I'm playing with the fdt command in recent (60174746) U-Boot and I can't set a property that does not have a value.
Documentation/powerpc/booting-without-of.txt" says "A property can have a value or not.", and fdt help suggests the same:
fdt set <path> <prop> [<val>] - Set <property> [to <val>]However, I am getting:
=> fdt mknode / testnode
=> fdt list /testnode
testnode {
};
=> fdt set /testnode testprop
Usage:
fdt - flattened device tree utility commands=> fdt list /testnode
testnode {
};Setting a property with value works:
=> fdt set /testnode testprop "testvalue"
=> fdt list /testnode
Quoted 8 lines
testnode { testprop=""testvalue""; };Am I doing something wrong, or is it a bug?
Regards,
Bartlomiej
Hi Bartlomiej,
That looks like a bug. The cmd_fdt.c parser looks like it is insisting on a value (looking for three parameters to the "fdt set" subcommand).
I have not looked at the code to confirm the above hypothesis yet...
Best regards,
gvb
Quoted 5 lines · Jerry Van Baren
Quoted 4 lines · Bartlomiej Sieka
Hello,
I'm playing with the fdt command in recent (60174746) U-Boot and I can't set a property that does not have a value.
[...]
Quoted 1 line
Quoted 1 line
Am I doing something wrong, or is it a bug?
[...]>
Quoted 7 lines
That looks like a bug. The
cmd_fdt.cparser looks like it is insisting on a value (looking for three parameters to the "fdt set" subcommand).I have not looked at the code to confirm the above hypothesis yet...
Best regards,
gvb
Hi Jerry,
Thanks for a quick reply.
I've got a few comments after playing with fdt commands a little bit more. They concern the help message of "fdt move", which says:
fdt move <fdt> <newaddr> <length> - Copy the fdt to <addr>
And the comments are:
- <fdt> -> <addr> (to be in sync with "fdt addr" description)
- <length> -> [<length>]
- Copy the fdt to <addr> -> Copy the fdt to <newaddr>
- to me, it's not clear from the description that this command will make the blob at the new location the "active" one.
Does the above make sense? If yes, it might be a good idea to update the help message while working on the "fdt set" issue.
Regards,
Bartlomiej
Quoted 33 lines · Bartlomiej Sieka
Quoted 5 lines · Jerry Van Baren
Quoted 4 lines · Bartlomiej Sieka
Hello,
I'm playing with the fdt command in recent (60174746) U-Boot and I can't set a property that does not have a value.
[...]
Quoted 1 line
Quoted 1 line
Am I doing something wrong, or is it a bug?
[...]>
Quoted 8 lines
That looks like a bug. The
cmd_fdt.cparser looks like it is insisting on a value (looking for three parameters to the "fdt set" subcommand).I have not looked at the code to confirm the above hypothesis yet...
Best regards,
gvbHi Jerry,
Thanks for a quick reply.
I've got a few comments after playing with fdt commands a little bit more. They concern the help message of "fdt move", which says:
fdt move <fdt> <newaddr> <length> - Copy the fdt to <addr>And the comments are:
- <fdt> -> <addr> (to be in sync with "fdt addr" description)
- <length> -> [<length>]
- Copy the fdt to <addr> -> Copy the fdt to <newaddr>
- to me, it's not clear from the description that this command will make the blob at the new location the "active" one.
Quoted 5 lines
Does the above make sense? If yes, it might be a good idea to update the help message while working on the "fdt set" issue.
Regards,
Bartlomiej
Agreed, the help text should be improved to be more specific, less confusing, and its accuracy should be verified.
Best regards,
gvb