Skip to contentSkip to conversation

Fix bad symbol reference

PATCH In review Ben Guthro 1 participant 1 message Sep 6, 2007 Xen hypervisor interface

lore
Share & tools
lore

Ben Guthro

author
#0 lore raw

PATCH 3/3 Fix bad symbol reference

This fixes a bug causing a bogus symbol reference (to init_page_count) in the PV-on-HVM drivers for 2.6 kernels that define the set_page_count macro.

include/xen/gnttab.h +9 -5
diff -r e2956856259c include/xen/gnttab.h
@@ -108,11 +108,15 @@ static inline void __gnttab_dma_unmap_pa
 {
 }
 
-static inline void gnttab_reset_grant_page(struct page *page)
-{
-	init_page_count(page);
-	reset_page_mapcount(page);
-}
+/* init_page_count() is conditionally redefined by xen/platform-compat.h, so
+ * we can't inline a call to it.
+ */
+#define gnttab_reset_grant_page(p)		\
+	do {					\
+		struct page *_page = p;	        \
+		init_page_count(_page);		\
+		reset_page_mapcount(_page);	\
+	} while (0);				\
 
 int gnttab_suspend(void);
 int gnttab_resume(void);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel