Skip to contentSkip to conversation

sata & scsi suggestion for make menuconfig

PATCH In review Folkert van Heusden 22 participants 88 messages Sep 7, 2007 – Sep 17, 2007

Subsystems (19)
Arm (32-bit) SCSI PowerPC MIPS +15 more subsystems
lore
Share & tools
lore
#0 lore raw

Hi,

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

Folkert van Heusden

Signature · 5 lines
Multi tail barnamaj mowahib li mora9abat attasjilat wa nataij awamir
al 7asoub. damj, talwin, mora9abat attarchi7 wa ila akhirih.
http://www.vanheusden.com/multitail/
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
#1 lore raw
Quoted 4 lines · Folkert van Heusden

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

Having no sd support is perfectly valid. Imagine a diskless boot with only sr support.

#2 lore raw
Quoted 6 lines
Quoted 3 lines

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

Having no sd support is perfectly valid. Imagine a diskless boot with only sr support.

Ok, but that's not the most common situaties. What I'm suggesting is a warning or a please note popup. Not neccessarily an error or refusing to continue thing.

Folkert van Heusden

Signature · 5 lines
www.vanheusden.com/multitail - win een vlaai van multivlaai! zorg
ervoor dat multitail opgenomen wordt in Fedora Core, AIX, Solaris of
HP/UX en win een vlaai naar keuze
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
#3 lore raw
Quoted 3 lines · Folkert van Heusden

Ok, but that's not the most common situaties. What I'm suggesting is a warning or a please note popup. Not neccessarily an error or refusing to continue thing.

What IMHO makes sense is changing all references to SCSI CDROM, SCSI DISK etc. to just CDROM, DISK, and changing SCSI (menu) to something like MASS STORAGE.

Signature · 1 line
Krzysztof Halasa
#4 lore raw
Quoted 7 lines · Krzysztof Halasa
Quoted 3 lines

Ok, but that's not the most common situaties. What I'm suggesting is a warning or a please note popup. Not neccessarily an error or refusing to continue thing.

What IMHO makes sense is changing all references to SCSI CDROM, SCSI DISK etc. to just CDROM, DISK, and changing SCSI (menu) to something like MASS STORAGE.

There is still too much SCSI in it IMO :-)

#5 lore raw
Quoted 10 lines · Jan Engelhardt
Quoted 7 lines · Krzysztof Halasa
Quoted 3 lines

Ok, but that's not the most common situaties. What I'm suggesting is a warning or a please note popup. Not neccessarily an error or refusing to continue thing.

What IMHO makes sense is changing all references to SCSI CDROM, SCSI DISK etc. to just CDROM, DISK, and changing SCSI (menu) to something like MASS STORAGE.

There is still too much SCSI in it IMO :-)

And to explain that point: SCSI device name inquiry is limited to 16 bytes. That may be a limitation of SCSI (as in: the protocol), but the SCSI *subsystem* should not impose such a tight limit.

Jan

#6 lore raw
In reply to Folkert van Heusden
Quoted 5 lines · On Fri, 7 Sep 2007 14:48:00 +0200 Folkert van Heusden wrote:

Hi,

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

I know that it's difficult to get people to read docs & help text, and maybe it is needed in more places, but CONFIG_ATA (SATA/PATA) help text says:

NOTE: ATA enables basic SCSI support; *however*, 'SCSI disk support', 'SCSI tape support', or 'SCSI CDROM support' may also be needed, depending on your hardware configuration.

A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#7 lore raw
Quoted 11 lines
Quoted 3 lines

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

I know that it's difficult to get people to read docs & help text, and maybe it is needed in more places, but CONFIG_ATA (SATA/PATA) help text says:
NOTE: ATA enables basic SCSI support; *however*, 'SCSI disk support', 'SCSI tape support', or
'SCSI CDROM support' may also be needed,
depending on your hardware configuration.

Yes but that would mean that you have to open the help for each item that you add.

Quoted 3 lines

A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig.

Maybe add a new type?

Folkert van Heusden

Signature · 6 lines
MultiTail na wan makriki wrokosani fu tan luku den logfile nanga san
den commando spiti puru. Piki puru spesrutu sani, wroko nanga difreti
kroru, tja kon makandra, nanga wan lo moro.
http://www.vanheusden.com/multitail/
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
#8 lore raw
Quoted 8 lines · Folkert van Heusden
Quoted 7 lines

I know that it's difficult to get people to read docs & help text, and maybe it is needed in more places, but CONFIG_ATA (SATA/PATA) help text says:
NOTE: ATA enables basic SCSI support; *however*, 'SCSI disk support', 'SCSI tape support', or
'SCSI CDROM support' may also be needed,
depending on your hardware configuration.

Quoted 8 lines

Yes but that would mean that you have to open the help for each item that you add.

Quoted 3 lines

A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig.

Maybe add a new type?

How about

comment "Note: 'SCSI disk support' is required for SATA/PATA HDDs!"

	depends on ATA && !BLK_DEV_SD
Signature · 3 lines
Stefan Richter
-=====-=-=== =--= --===
http://arcgraph.de/sr/
#9 lore raw
Quoted 15 lines
Quoted 15 lines
Quoted 7 lines

I know that it's difficult to get people to read docs & help text, and maybe it is needed in more places, but CONFIG_ATA (SATA/PATA) help text says:
NOTE: ATA enables basic SCSI support; *however*, 'SCSI disk support', 'SCSI tape support', or
'SCSI CDROM support' may also be needed,
depending on your hardware configuration.

Yes but that would mean that you have to open the help for each item that you add.

Quoted 3 lines

A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig.

Quoted 5 lines
Quoted 1 line

Maybe add a new type?

How about
comment "Note: 'SCSI disk support' is required for SATA/PATA HDDs!"

	depends on ATA && !BLK_DEV_SD

Yes! Maybe create some status-line at the bottom of the screen in which these hints scrollby. Like powertop does.

Folkert van Heusden

Signature · 5 lines
MultiTail är en flexibel redskap för att fälja logfilar, utför av
commandoer, filtrera, ge färg, sammanfoga, o.s.v. följa.
http://www.vanheusden.com/multitail/
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
#10 lore raw

(added Cc linux-ide)

Quoted 10 lines · Folkert van Heusden
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig.

Maybe add a new type?

How about
comment "Note: 'SCSI disk support' is required for SATA/PATA HDDs!"

	depends on ATA && !BLK_DEV_SD

Yes! Maybe create some status-line at the bottom of the screen in which these hints scrollby. Like powertop does.

'comment' is already supported by make {menu,x,g}config and AFAIK by make oldconfig too. It is not effective in make oldconfig though because it will scroll off the screen quickly.

I am not a friend of 'select', but maybe the following actually helps. I didn't follow all of this and previous related discussions, so I guess somebody else suggested something like this before:

# drivers/ata/Kconfig

config ATA

	[...]

comment "Controller drivers"

[...low-level drivers go here...]

comment "Storage device drivers"

config ATA_SD
tristate "SATA/PATA HDD support (via SCSI disk support)" depends on ATA
select BLK_DEV_SD
help
'SCSI disk support' is required to access SATA HDDs. It is also necessary for parallel ATA (IDE) HDDs if you use the experimental parallel ATA option.

You can say Y or M here to select SCSI disk support, or you can do so in the 'SCSI device support' section.

[...ditto for CD/DVD-ROMs, tapes, and generic support...]

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
#11 lore raw
Quoted 18 lines · Stefan Richter

config ATA

	[...]

comment "Controller drivers"

[...low-level drivers go here...]

comment "Storage device drivers"

config ATA_SD
tristate "SATA/PATA HDD support (via SCSI disk support)" depends on ATA
select BLK_DEV_SD
help
'SCSI disk support' is required to access SATA HDDs. It is also necessary for parallel ATA (IDE) HDDs if you use the experimental parallel ATA option.

Quoted 4 lines

You can say Y or M here to select SCSI disk support, or you can do so in the 'SCSI device support' section.

[...ditto for CD/DVD-ROMs, tapes, and generic support...]

And what uses ATA_SD, or is the user supposed to manually enable it?

Jan

#12 lore raw
Quoted 7 lines · Jan Engelhardt
Quoted 6 lines · Stefan Richter

config ATA_SD
tristate "SATA/PATA HDD support (via SCSI disk support)" depends on ATA
select BLK_DEV_SD
help
'SCSI disk support' is required to access SATA HDDs. It is

[...]

Quoted 2 lines
Quoted 2 lines

You can say Y or M here to select SCSI disk support, or you can do so in the 'SCSI device support' section.

[...]

Quoted 1 line

And what uses ATA_SD, or is the user supposed to manually enable it?

It is merely there to produce the prompt which people asked for. CONFIG_ATA_SD (or CONFIG_ATA_BLK_DEV_SD or whatever) won't turn up in any Makefile or source code.

Note, I'm not fond of 'select' nor of dummy Kconfig variables. Plus I can personally live very well with the current solution (sd_mod et al are mentioned in the help text at CONFIG_ATA). That's why I posted only the example instead of a complete patch.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
#13 lore raw
In reply to Stefan Richter
Quoted 13 lines · Stefan Richter

(added Cc linux-ide)

Quoted 9 lines · Folkert van Heusden
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig.

Maybe add a new type?

How about
comment "Note: 'SCSI disk support' is required for SATA/PATA HDDs!"

	depends on ATA && !BLK_DEV_SD

Yes! Maybe create some status-line at the bottom of the screen in which these hints scrollby. Like powertop does.

Quoted 8 lines

'comment' is already supported by make {menu,x,g}config and AFAIK by make oldconfig too. It is not effective in make oldconfig though because it will scroll off the screen quickly.

I am not a friend of 'select', but maybe the following actually helps. I didn't follow all of this and previous related discussions, so I guess somebody else suggested something like this before:

The problem with 'select' here is that it will enable BLK_DEV_SD, but if SCSI is not enabled, it will not become enabled -- i.e., select does not follow the dependency chain. So usually the kernel will not build unless SCSI is enabled by the user.

Quoted 24 lines

# drivers/ata/Kconfig

config ATA

	[...]

comment "Controller drivers"

[...low-level drivers go here...]

comment "Storage device drivers"

config ATA_SD
tristate "SATA/PATA HDD support (via SCSI disk support)" depends on ATA
select BLK_DEV_SD
help
'SCSI disk support' is required to access SATA HDDs. It is also necessary for parallel ATA (IDE) HDDs if you use the experimental parallel ATA option.

You can say Y or M here to select SCSI disk support, or you can do so in the 'SCSI device support' section.

[...ditto for CD/DVD-ROMs, tapes, and generic support...]

Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
#14 lore raw
Quoted 2 lines · Randy Dunlap
Quoted 1 line · Stefan Richter

I am not a friend of 'select', but maybe the following actually helps.

...

Quoted 4 lines

The problem with 'select' here is that it will enable BLK_DEV_SD, but if SCSI is not enabled, it will not become enabled -- i.e., select does not follow the dependency chain. So usually the kernel will not build unless SCSI is enabled by the user.

...

Quoted 6 lines
Quoted 6 lines

config ATA_SD
tristate "SATA/PATA HDD support (via SCSI disk support)" depends on ATA
select BLK_DEV_SD
help
'SCSI disk support' is required to access SATA HDDs. It is

...

I checked the dependencies. ATA depends on SCSI (actually, selects SCSI), so all is well. Otherwise I would have added more dependencies to ATA_SD.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
#15 lore raw
Quoted 15 lines · On Sat, 08 Sep 2007 18:44:46 +0200 Stefan Richter wrote:
Quoted 2 lines · Randy Dunlap
Quoted 1 line · Stefan Richter

I am not a friend of 'select', but maybe the following actually helps.

...

Quoted 4 lines

The problem with 'select' here is that it will enable BLK_DEV_SD, but if SCSI is not enabled, it will not become enabled -- i.e., select does not follow the dependency chain. So usually the kernel will not build unless SCSI is enabled by the user.

...

Quoted 6 lines
Quoted 6 lines

config ATA_SD
tristate "SATA/PATA HDD support (via SCSI disk support)" depends on ATA
select BLK_DEV_SD
help
'SCSI disk support' is required to access SATA HDDs. It is

Quoted 5 lines

...

I checked the dependencies. ATA depends on SCSI (actually, selects SCSI), so all is well. Otherwise I would have added more dependencies to ATA_SD.

Ah, that's good, then. Thanks.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#16 lore raw
Quoted 6 lines · Randy Dunlap
Quoted 5 lines · On Sat, 08 Sep 2007 18:44:46 +0200 Stefan Richter wrote:
Quoted 4 lines · Randy Dunlap

The problem with 'select' here is that it will enable BLK_DEV_SD, but if SCSI is not enabled, it will not become enabled -- i.e., select does not follow the dependency chain. So usually the kernel will not build unless SCSI is enabled by the user.

...

Quoted 5 lines
Quoted 3 lines

I checked the dependencies. ATA depends on SCSI (actually, selects SCSI), so all is well. Otherwise I would have added more dependencies to ATA_SD.

Ah, that's good, then.

Not completely though. Whenever a 'select' is inserted into the dependency graph, the whole thing becomes more fragile WRT future changes.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
#17 lore raw
In reply to Randy Dunlap
Quoted 18 lines · Randy Dunlap
Quoted 5 lines · On Fri, 7 Sep 2007 14:48:00 +0200 Folkert van Heusden wrote:

Hi,

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

I know that it's difficult to get people to read docs & help text, and maybe it is needed in more places, but CONFIG_ATA (SATA/PATA) help text says:

NOTE: ATA enables basic SCSI support; *however*, 'SCSI disk support', 'SCSI tape support', or 'SCSI CDROM support' may also be needed, depending on your hardware configuration.

Quoted 3 lines

A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig.

For menuconfig I would much rather see that it had an additional window at the bottom displaying the help text for the active menu line.

Implementing support for a pop-up in the kconfig language seems to be a bit off the purpose of the kconfig language.

Sam

#18 lore raw
In reply to Randy Dunlap
Quoted 20 lines · Randy Dunlap
Quoted 6 lines · On Fri, 7 Sep 2007 14:48:00 +0200 Folkert van Heusden wrote:

Hi,

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

I know that it's difficult to get people to read docs & help text, and maybe it is needed in more places, but CONFIG_ATA (SATA/PATA) help text says:

NOTE: ATA enables basic SCSI support; *however*, 'SCSI disk support', 'SCSI tape support', or 'SCSI CDROM support' may also be needed, depending on your hardware configuration.

Quoted 4 lines

A popup makes some sense, but I don't know if menuconfig knows how to do popup warnings... and it needs to be done for all *configs, not just menuconfig.

A popup hardly ever makes sense - popups generally are a bad user interface. The user will have to dismiss the popup - every time - whether he needs the warning or not.

But feel free to print a warning somewhere, such as a status line. The warning itself is useful, but not something we will have to dismiss in order to go on with the job.

Helge Hafting

#19 lore raw
Quoted 11 lines · Helge Hafting
Quoted 10 lines · Randy Dunlap
Quoted 6 lines · On Fri, 7 Sep 2007 14:48:00 +0200 Folkert van Heusden wrote:

Hi,

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

Quoted 8 lines
Quoted 8 lines

I know that it's difficult to get people to read docs & help text, and maybe it is needed in more places, but CONFIG_ATA (SATA/PATA) help text says:

NOTE: ATA enables basic SCSI support; *however*, 'SCSI disk support', 'SCSI tape support', or 'SCSI CDROM support' may also be needed, depending on your hardware configuration.

Could one duplicate the configure options for scsi disk/tape/cdrom at that place? The text should then probably read SCSI/SATA disk support in both places.

MfG
Goswin

#20 lore raw
Quoted 9 lines · Goswin von Brederlow
Quoted 5 lines · Helge Hafting
Quoted 4 lines · Randy Dunlap

NOTE: ATA enables basic SCSI support; *however*, 'SCSI disk support', 'SCSI tape support', or 'SCSI CDROM support' may also be needed, depending on your hardware configuration.

Could one duplicate the configure options for scsi disk/tape/cdrom at that place?

Yes, e.g. like in http://lkml.org/lkml/2007/9/8/9.

Quoted 1 line

The text should then probably read SCSI/SATA disk support in both places.

Or rather than duplicating the menu items for the same options, split the SCSI high-level options out into a top-level menu and adjust the wording of the prompts. http://lkml.org/lkml/2007/9/14/217

(top level)
menu "Storage (core and SCSI commands)"
config SCSI
tristate "Storage support (core and SCSI commands)"
config BLK_DEV_SD
tristate "Harddisks and other Direct access devices"
config CHR_DEV_ST
tristate "Tape drives"
config CHR_DEV_OSST
tristate "SCSI OnStream SC-x0 tape support"
config BLK_DEV_SR
tristate "CD-ROMs, DVD-ROMs"
...

menu "Device Drivers"

	...
	menu "SCSI device support"
		config RAID_ATTRS
		config SCSI_TGT
		menu "SCSI Transports"
			...
		menuconfig SCSI_LOWLEVEL
			bool "SCSI low-level drivers"
			...
Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#21 lore raw
In reply to Folkert van Heusden
Quoted 5 lines · Folkert van Heusden

Hi,

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

This has also bitten me one or two times. A reasonable way would be to just select SD automatically for !EMBEDDED

Here's a patch:

-Andi

Select BLK_DEV_SD for all SCSI/libata drivers

This avoid a common user mistake.

drivers/ata/Kconfig +62 -0
Index: linux-2.6.23-rc1-misc/drivers/ata/Kconfig
===================================================================
@@ -42,6 +42,7 @@ config ATA_ACPI
 
 config SATA_AHCI
 	tristate "AHCI SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for AHCI Serial ATA.
@@ -50,6 +51,7 @@ config SATA_AHCI
 
 config SATA_SVW
 	tristate "ServerWorks Frodo / Apple K2 SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for Broadcom/Serverworks/Apple K2
@@ -59,6 +61,7 @@ config SATA_SVW
 
 config ATA_PIIX
 	tristate "Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for ICH5/6/7/8 Serial ATA
@@ -69,6 +72,7 @@ config ATA_PIIX
 
 config SATA_MV
 	tristate "Marvell SATA support (HIGHLY EXPERIMENTAL)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the Marvell Serial ATA family.
@@ -78,6 +82,7 @@ config SATA_MV
 
 config SATA_NV
 	tristate "NVIDIA SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for NVIDIA Serial ATA.
@@ -86,6 +91,7 @@ config SATA_NV
 
 config PDC_ADMA
 	tristate "Pacific Digital ADMA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for Pacific Digital ADMA controllers
@@ -94,6 +100,7 @@ config PDC_ADMA
 
 config SATA_QSTOR
 	tristate "Pacific Digital SATA QStor support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for Pacific Digital Serial ATA QStor.
@@ -102,6 +109,7 @@ config SATA_QSTOR
 
 config SATA_PROMISE
 	tristate "Promise SATA TX2/TX4 support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for Promise Serial ATA TX2/TX4.
@@ -110,6 +118,7 @@ config SATA_PROMISE
 
 config SATA_SX4
 	tristate "Promise SATA SX4 support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for Promise Serial ATA SX4.
@@ -118,6 +127,7 @@ config SATA_SX4
 
 config SATA_SIL
 	tristate "Silicon Image SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for Silicon Image Serial ATA.
@@ -126,6 +136,7 @@ config SATA_SIL
 
 config SATA_SIL24
 	tristate "Silicon Image 3124/3132 SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for Silicon Image 3124/3132 Serial ATA.
@@ -134,6 +145,7 @@ config SATA_SIL24
 
 config SATA_SIS
 	tristate "SiS 964/965/966/180 SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	select PATA_SIS
 	help
@@ -145,6 +157,7 @@ config SATA_SIS
 
 config SATA_ULI
 	tristate "ULi Electronics SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for ULi Electronics SATA.
@@ -153,6 +166,7 @@ config SATA_ULI
 
 config SATA_VIA
 	tristate "VIA SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for VIA Serial ATA.
@@ -161,6 +175,7 @@ config SATA_VIA
 
 config SATA_VITESSE
 	tristate "VITESSE VSC-7174 / INTEL 31244 SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for Vitesse VSC7174 and Intel 31244 Serial ATA.
@@ -169,12 +184,14 @@ config SATA_VITESSE
 
 config SATA_INIC162X
 	tristate "Initio 162x SATA support (HIGHLY EXPERIMENTAL)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for Initio 162x Serial ATA.
 
 config PATA_ALI
 	tristate "ALi PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the ALi ATA interfaces
@@ -184,6 +201,7 @@ config PATA_ALI
 
 config PATA_AMD
 	tristate "AMD/NVidia PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for the AMD and NVidia PATA
@@ -193,6 +211,7 @@ config PATA_AMD
 
 config PATA_ARTOP
 	tristate "ARTOP 6210/6260 PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for ARTOP PATA controllers.
@@ -201,6 +220,7 @@ config PATA_ARTOP
 
 config PATA_ATIIXP
 	tristate "ATI PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the ATI ATA interfaces
@@ -210,6 +230,7 @@ config PATA_ATIIXP
 
 config PATA_CMD640_PCI
 	tristate "CMD640 PCI PATA support (Very Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the CMD640 PCI IDE
@@ -220,6 +241,7 @@ config PATA_CMD640_PCI
 
 config PATA_CMD64X
 	tristate "CMD64x PATA support (Very Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI&& EXPERIMENTAL
 	help
 	  This option enables support for the CMD64x series chips
@@ -229,6 +251,7 @@ config PATA_CMD64X
 
 config PATA_CS5520
 	tristate "CS5510/5520 PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for the Cyrix 5510/5520
@@ -238,6 +261,7 @@ config PATA_CS5520
 
 config PATA_CS5530
 	tristate "CS5530 PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the Cyrix/NatSemi/AMD CS5530
@@ -247,6 +271,7 @@ config PATA_CS5530
 
 config PATA_CS5535
 	tristate "CS5535 PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && X86 && !X86_64 && EXPERIMENTAL
 	help
 	  This option enables support for the NatSemi/AMD CS5535
@@ -256,6 +281,7 @@ config PATA_CS5535
 
 config PATA_CYPRESS
 	tristate "Cypress CY82C693 PATA support (Very Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the Cypress/Contaq CY82C693
@@ -265,6 +291,7 @@ config PATA_CYPRESS
 
 config PATA_EFAR
 	tristate "EFAR SLC90E66 support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for the EFAR SLC90E66
@@ -274,6 +301,7 @@ config PATA_EFAR
 
 config ATA_GENERIC
 	tristate "Generic ATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for generic BIOS configured
@@ -283,6 +311,7 @@ config ATA_GENERIC
 
 config PATA_HPT366
 	tristate "HPT 366/368 PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the HPT 366 and 368
@@ -292,6 +321,7 @@ config PATA_HPT366
 
 config PATA_HPT37X
 	tristate "HPT 370/370A/371/372/374/302 PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the majority of the later HPT
@@ -301,6 +331,7 @@ config PATA_HPT37X
 
 config PATA_HPT3X2N
 	tristate "HPT 372N/302N PATA support (Very Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the N variant HPT PATA
@@ -310,6 +341,7 @@ config PATA_HPT3X2N
 
 config PATA_HPT3X3
 	tristate "HPT 343/363 PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for the HPT 343/363
@@ -327,6 +359,7 @@ config PATA_HPT3X3_DMA
 
 config PATA_ISAPNP
 	tristate "ISA Plug and Play PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on EXPERIMENTAL && ISAPNP
 	help
 	  This option enables support for ISA plug & play ATA
@@ -336,6 +369,7 @@ config PATA_ISAPNP
 
 config PATA_IT821X
 	tristate "IT8211/2 PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for the ITE 8211 and 8212
@@ -346,6 +380,7 @@ config PATA_IT821X
 
 config PATA_IT8213
 	tristate "IT8213 PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the ITE 821 PATA
@@ -355,6 +390,7 @@ config PATA_IT8213
 
 config PATA_JMICRON
 	tristate "JMicron PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  Enable support for the JMicron IDE controller, via the new
@@ -364,6 +400,7 @@ config PATA_JMICRON
 
 config PATA_LEGACY
 	tristate "Legacy ISA PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ISA && EXPERIMENTAL
 	help
 	  This option enables support for ISA/VLB bus legacy PATA
@@ -373,6 +410,7 @@ config PATA_LEGACY
 
 config PATA_TRIFLEX
 	tristate "Compaq Triflex PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  Enable support for the Compaq 'Triflex' IDE controller as found
@@ -382,6 +420,7 @@ config PATA_TRIFLEX
 
 config PATA_MARVELL
 	tristate "Marvell PATA support via legacy mode"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables limited support for the Marvell 88SE6145 ATA
@@ -391,6 +430,7 @@ config PATA_MARVELL
 
 config PATA_MPC52xx
 	tristate "Freescale MPC52xx SoC internal IDE"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PPC_MPC52xx
 	help
 	  This option enables support for integrated IDE controller
@@ -400,6 +440,7 @@ config PATA_MPC52xx
 
 config PATA_MPIIX
 	tristate "Intel PATA MPIIX support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for MPIIX PATA support.
@@ -408,6 +449,7 @@ config PATA_MPIIX
 
 config PATA_OLDPIIX
 	tristate "Intel PATA old PIIX support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for early PIIX PATA support.
@@ -416,6 +458,7 @@ config PATA_OLDPIIX
 
 config PATA_NETCELL
 	tristate "NETCELL Revolution RAID support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for the Netcell Revolution RAID
@@ -425,6 +468,7 @@ config PATA_NETCELL
 
 config PATA_NS87410
 	tristate "Nat Semi NS87410 PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the National Semiconductor
@@ -434,6 +478,7 @@ config PATA_NS87410
 
 config PATA_OPTI
 	tristate "OPTI621/6215 PATA support (Very Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables full PIO support for the early Opti ATA
@@ -443,6 +488,7 @@ config PATA_OPTI
 
 config PATA_OPTIDMA
 	tristate "OPTI FireStar PATA support (Very Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables DMA/PIO support for the later OPTi
@@ -462,6 +508,7 @@ config PATA_PCMCIA
 
 config PATA_PDC_OLD
 	tristate "Older Promise PATA controller support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the Promise 20246, 20262, 20263,
@@ -471,12 +518,14 @@ config PATA_PDC_OLD
 
 config PATA_QDI
 	tristate "QDI VLB PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ISA
 	help
 	  Support for QDI 6500 and 6580 PATA controllers on VESA local bus.
 
 config PATA_RADISYS
 	tristate "RADISYS 82600 PATA support (Very Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the RADISYS 82600
@@ -486,6 +535,7 @@ config PATA_RADISYS
 
 config PATA_RZ1000
 	tristate "PC Tech RZ1000 PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables basic support for the PC Tech RZ1000/1
@@ -495,6 +545,7 @@ config PATA_RZ1000
 
 config PATA_SC1200
 	tristate "SC1200 PATA support (Very Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the NatSemi/AMD SC1200 SoC
@@ -504,6 +555,7 @@ config PATA_SC1200
 
 config PATA_SERVERWORKS
 	tristate "SERVERWORKS OSB4/CSB5/CSB6/HT1000 PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for the Serverworks OSB4/CSB5/CSB6 and
@@ -513,6 +565,7 @@ config PATA_SERVERWORKS
 
 config PATA_PDC2027X
 	tristate "Promise PATA 2027x support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for Promise PATA pdc20268 to pdc20277 host adapters.
@@ -521,6 +574,7 @@ config PATA_PDC2027X
 
 config PATA_SIL680
 	tristate "CMD / Silicon Image 680 PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for CMD / Silicon Image 680 PATA.
@@ -529,6 +583,7 @@ config PATA_SIL680
 
 config PATA_SIS
 	tristate "SiS PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for SiS PATA controllers
@@ -537,6 +592,7 @@ config PATA_SIS
 
 config PATA_VIA
 	tristate "VIA PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for the VIA PATA interfaces
@@ -546,6 +602,7 @@ config PATA_VIA
 
 config PATA_WINBOND
 	tristate "Winbond SL82C105 PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	help
 	  This option enables support for SL82C105 PATA devices found in the
@@ -555,6 +612,7 @@ config PATA_WINBOND
 
 config PATA_WINBOND_VLB
 	tristate "Winbond W83759A VLB PATA support (Experimental)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ISA && EXPERIMENTAL
 	help
 	  Support for the Winbond W83759A controller on Vesa Local Bus
@@ -562,6 +620,7 @@ config PATA_WINBOND_VLB
 
 config PATA_PLATFORM
 	tristate "Generic platform device PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on EMBEDDED || ARCH_RPC
 	help
 	  This option enables support for generic directly connected ATA
@@ -571,6 +630,7 @@ config PATA_PLATFORM
 
 config PATA_ICSIDE
 	tristate "Acorn ICS PATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARM && ARCH_ACORN
 	help
 	  On Acorn systems, say Y here if you wish to use the ICS PATA
@@ -579,6 +639,7 @@ config PATA_ICSIDE
 
 config PATA_IXP4XX_CF
 	tristate "IXP4XX Compact Flash support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARCH_IXP4XX
 	help
 	  This option enables support for a Compact Flash connected on
@@ -589,6 +650,7 @@ config PATA_IXP4XX_CF
 
 config PATA_SCC
 	tristate "Toshiba's Cell Reference Set IDE support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && PPC_CELLEB
 	help
 	  This option enables support for the built-in IDE controller on
drivers/scsi/Kconfig +80 -0

558 lines not on this page · raw message

drivers/scsi/aic7xxx/Kconfig.aic79xx +1 -0
Index: linux-2.6.23-rc1-misc/drivers/scsi/aic7xxx/Kconfig.aic79xx
===================================================================
@@ -4,6 +4,7 @@
 #
 config SCSI_AIC79XX
 	tristate "Adaptec AIC79xx U320 support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && SCSI
 	select SCSI_SPI_ATTRS
 	help
drivers/scsi/aic7xxx/Kconfig.aic7xxx +1 -0
Index: linux-2.6.23-rc1-misc/drivers/scsi/aic7xxx/Kconfig.aic7xxx
===================================================================
@@ -4,6 +4,7 @@
 #
 config SCSI_AIC7XXX
 	tristate "Adaptec AIC7xxx Fast -> U160 support (New Driver)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on (PCI || EISA) && SCSI
 	select SCSI_SPI_ATTRS
 	---help---
drivers/scsi/aic94xx/Kconfig +1 -0
Index: linux-2.6.23-rc1-misc/drivers/scsi/aic94xx/Kconfig
===================================================================
@@ -26,6 +26,7 @@
 
 config SCSI_AIC94XX
 	tristate "Adaptec AIC94xx SAS/SATA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI
 	select SCSI_SAS_LIBSAS
 	select FW_LOADER
drivers/scsi/arm/Kconfig +7 -0
Index: linux-2.6.23-rc1-misc/drivers/scsi/arm/Kconfig
===================================================================
@@ -3,6 +3,7 @@
 #
 config SCSI_ACORNSCSI_3
 	tristate "Acorn SCSI card (aka30) support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARCH_ACORN && SCSI && BROKEN
 	select SCSI_SPI_ATTRS
 	help
@@ -32,6 +33,7 @@ config SCSI_ACORNSCSI_SYNC
 
 config SCSI_ARXESCSI
 	tristate "ARXE SCSI support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARCH_ACORN && SCSI
 	help
 	  Around 1991, Arxe Systems Limited released a high density floppy
@@ -44,6 +46,7 @@ config SCSI_ARXESCSI
 
 config SCSI_CUMANA_2
 	tristate "CumanaSCSI II support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARCH_ACORN && SCSI
 	help
 	  This enables support for the Cumana SCSI II card. If you have an
@@ -51,6 +54,7 @@ config SCSI_CUMANA_2
 
 config SCSI_EESOXSCSI
 	tristate "EESOX support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARCH_ACORN && SCSI
 	help
 	  This enables support for the EESOX SCSI card. If you have an Acorn
@@ -58,6 +62,7 @@ config SCSI_EESOXSCSI
 
 config SCSI_POWERTECSCSI
 	tristate "PowerTec support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARCH_ACORN && SCSI
 	help
 	  This enables support for the Powertec SCSI card on Acorn systems. If
@@ -68,6 +73,7 @@ comment "The following drivers are not f
 
 config SCSI_CUMANA_1
 	tristate "CumanaSCSI I support (EXPERIMENTAL)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARCH_ACORN && EXPERIMENTAL && SCSI
 	select SCSI_SPI_ATTRS
 	help
@@ -76,6 +82,7 @@ config SCSI_CUMANA_1
 
 config SCSI_ECOSCSI
 	tristate "EcoScsi support (EXPERIMENTAL)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on ARCH_ACORN && EXPERIMENTAL && (ARCH_ARC || ARCH_A5K) && SCSI
 	select SCSI_SPI_ATTRS
 	help
drivers/scsi/megaraid/Kconfig.megaraid +3 -0
Index: linux-2.6.23-rc1-misc/drivers/scsi/megaraid/Kconfig.megaraid
===================================================================
@@ -6,6 +6,7 @@ config MEGARAID_NEWGEN
 
 config MEGARAID_MM
 	tristate "LSI Logic Management Module (New Driver)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && SCSI && MEGARAID_NEWGEN
 	help
 	Management Module provides ioctl, sysfs support for LSI Logic
@@ -16,6 +17,7 @@ config MEGARAID_MM
 
 config MEGARAID_MAILBOX
 	tristate "LSI Logic MegaRAID Driver (New Driver)"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && SCSI && MEGARAID_MM
 	help
 	List of supported controllers
@@ -77,6 +79,7 @@ config MEGARAID_LEGACY
 
 config MEGARAID_SAS
 	tristate "LSI Logic MegaRAID SAS RAID Module"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && SCSI
 	help
 	Module for LSI Logic's SAS based RAID controllers.
drivers/scsi/pcmcia/Kconfig +5 -0
Index: linux-2.6.23-rc1-misc/drivers/scsi/pcmcia/Kconfig
===================================================================
@@ -10,6 +10,7 @@ if SCSI_LOWLEVEL_PCMCIA && SCSI && PCMCI
 
 config PCMCIA_AHA152X
 	tristate "Adaptec AHA152X PCMCIA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on !64BIT
 	select SCSI_SPI_ATTRS
 	help
@@ -21,6 +22,7 @@ config PCMCIA_AHA152X
 
 config PCMCIA_FDOMAIN
 	tristate "Future Domain PCMCIA support"
+	select BLK_DEV_SD if !EMBEDDED
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
 	  adapter to your computer.
@@ -30,6 +32,7 @@ config PCMCIA_FDOMAIN
 
 config PCMCIA_NINJA_SCSI
 	tristate "NinjaSCSI-3 / NinjaSCSI-32Bi (16bit) PCMCIA support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on !64BIT
 	help
 	  If you intend to attach this type of PCMCIA SCSI host adapter to
@@ -64,6 +67,7 @@ config PCMCIA_NINJA_SCSI
 
 config PCMCIA_QLOGIC
 	tristate "Qlogic PCMCIA support"
+	select BLK_DEV_SD if !EMBEDDED
 	help
 	  Say Y here if you intend to attach this type of PCMCIA SCSI host
 	  adapter to your computer.
@@ -73,6 +77,7 @@ config PCMCIA_QLOGIC
 
 config PCMCIA_SYM53C500
 	tristate "Symbios 53c500 PCMCIA support"
+	select BLK_DEV_SD if !EMBEDDED
 	help
 	  Say Y here if you have a New Media Bus Toaster or other PCMCIA
 	  SCSI adapter based on the Symbios 53c500 controller.
drivers/scsi/qla2xxx/Kconfig +1 -0
Index: linux-2.6.23-rc1-misc/drivers/scsi/qla2xxx/Kconfig
===================================================================
@@ -1,5 +1,6 @@
 config SCSI_QLA_FC
 	tristate "QLogic QLA2XXX Fibre Channel Support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && SCSI
 	select SCSI_FC_ATTRS
 	select FW_LOADER
drivers/scsi/qla4xxx/Kconfig +1 -0
Index: linux-2.6.23-rc1-misc/drivers/scsi/qla4xxx/Kconfig
===================================================================
@@ -1,5 +1,6 @@
 config SCSI_QLA_ISCSI
 	tristate "QLogic ISP4XXX host adapter family support"
+	select BLK_DEV_SD if !EMBEDDED
 	depends on PCI && SCSI && NET
 	select SCSI_ISCSI_ATTRS
 	---help---
#22 lore raw
Quoted 11 lines · On 08 Sep 2007 18:07:00 +0200 Andi Kleen wrote:
Quoted 5 lines · Folkert van Heusden

Hi,

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

This has also bitten me one or two times. A reasonable way would be to just select SD automatically for !EMBEDDED

Quoted 7 lines

Here's a patch:

-Andi

Select BLK_DEV_SD for all SCSI/libata drivers

This avoid a common user mistake.

I'd say that someone needs to use a vendor kernel, or at least begin with a vendor .config file...

Quoted 1 line

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#23 lore raw
Quoted 6 lines · Randy Dunlap
Quoted 2 lines · On 08 Sep 2007 18:07:00 +0200 Andi Kleen wrote:

This has also bitten me one or two times. A reasonable way would be to just select SD automatically for !EMBEDDED

I'd say that someone needs to use a vendor kernel, or at least begin with a vendor .config file...

That's not entirely fair ... if you're switching over from a config you've been dragging around for years which uses IDE rather than ATA, it's far from obvious which config options you need to change. I think Andi's patch is a good one. It might also be good to select SR (at least my wife's laptop has the cd-rom on SATA).

Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
#24 lore raw
In reply to Randy Dunlap
Quoted 2 lines

I'd say that someone needs to use a vendor kernel, or at least begin with a vendor .config file...

Vendor kernels tend to compile forever and require initrds. For just testing a kernel quickly compiling only a few drivers in is much more convenient.

Also when you've been using CONFIG_IDE before it is not completely obvious you need BLK_SD for your hard disk.

-Andi

#25 lore raw
Quoted 2 lines · Andi Kleen

when you've been using CONFIG_IDE before it is not completely obvious you need BLK_SD for your hard disk.

Switching to different drivers without reading the help text? Tough.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
#26 lore raw
Quoted 6 lines · Stefan Richter
Quoted 2 lines · Andi Kleen

when you've been using CONFIG_IDE before it is not completely obvious you need BLK_SD for your hard disk.

Switching to different drivers without reading the help text? Tough.

The individual driver descriptions don't say BLK_SD needs to be selected.

Besides if all descriptions said that the computer could as well do it for the user automatically. After all it's a stupid repetive task and computers are much better at those than humans.

-Andi

#27 lore raw
Quoted 8 lines · Andi Kleen
Quoted 5 lines · Stefan Richter
Quoted 2 lines · Andi Kleen

when you've been using CONFIG_IDE before it is not completely obvious you need BLK_SD for your hard disk.

Switching to different drivers without reading the help text? Tough.

The individual driver descriptions don't say BLK_SD needs to be selected.

At least the help to CONFIG_ATA says so.

Quoted 1 line

Besides if all descriptions said that

We certainly don't want (too much) redundancy in help texts.

Quoted 3 lines

the computer could as well
do it for the user automatically. After all it's a stupid repetive task and computers are much better at those than humans.

In your patch, it is not the computer who finds out that the user wants BLK_SD. It is you who predetermined that the user wants it.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -=---
http://arcgraph.de/sr/
#28 lore raw
In reply to Andi Kleen
Quoted 11 lines · Andi Kleen
Quoted 5 lines · Folkert van Heusden

Hi,

Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

This has also bitten me one or two times. A reasonable way would be to just select SD automatically for !EMBEDDED

Quoted 7 lines

Here's a patch:

-Andi

Select BLK_DEV_SD for all SCSI/libata drivers

This avoid a common user mistake.

I can see where you're coming from, but logically, this is wrong. There's a huge slew of enterprise machines that only have DVD on SATA. On the other hand, all of these machines will have SCSI disk devices on various other transports, so no harm is done, it's just an inelegant solution.

James

#29 lore raw
Quoted 2 lines

I can see where you're coming from, but logically, this is wrong. There's a huge slew of enterprise machines that only have DVD on SATA.

... and enterprise systems don't really care about a few KB more of code. In fact you definitely want to have SATA compiled in in case you need to recover the machine later when the SAN is down.

Quoted 3 lines

On the other hand, all of these machines will have SCSI disk devices on various other transports, so no harm is done, it's just an inelegant solution.

Do you know of a better one?

-Andi

#30 lore raw
Quoted 7 lines · Andi Kleen
Quoted 2 lines

I can see where you're coming from, but logically, this is wrong. There's a huge slew of enterprise machines that only have DVD on SATA.

... and enterprise systems don't really care about a few KB more of code. In fact you definitely want to have SATA compiled in in case you need to recover the machine later when the SAN is down.

Quoted 5 lines
Quoted 3 lines

On the other hand, all of these machines will have SCSI disk devices on various other transports, so no harm is done, it's just an inelegant solution.

Do you know of a better one?

Let's step back a moment and consider the actual scale and impact of the problem at hand.

The vast majority of users are consumers of pre-compiled kernels, built by People With Clue(tm), who figured this stuff out as soon as it was introduced.

The current setup expresses the dependencies as they exist -- OPTIONAL extras, and that is a problem once a year or so, when someone builds their own kernel but must learn this fact anew.

There is simply no compelling need at all to change things from the current setup.

Our Kconfig system is for people who already know the kernel, not Aunt Tillie.

Jeff

#31 lore raw
Quoted 2 lines

The current setup expresses the dependencies as they exist -- OPTIONAL extras, and that is a problem once a year or so, when someone builds

Disk support over SCSI/SATA is hardly an "optional extra". It's more the 99+% case.

Quoted 1 line

their own kernel but must learn this fact anew.

When it costs 10000 people half an hour to learn and correct this it wasted 5000 hours of previous livetime.

Besides there is no good reason to have ever learned this imho.

-Andi

#32 lore raw
Quoted 5 lines · Andi Kleen
Quoted 2 lines

The current setup expresses the dependencies as they exist -- OPTIONAL extras, and that is a problem once a year or so, when someone builds

Disk support over SCSI/SATA is hardly an "optional extra". It's more the 99+% case.

Using that argument, there's an equal case for always requiring SCSI to be built for every kernel, since very few people can boot a system without a disk. However, the 1% case is the embedded flash booting community plus a few others, so we allow SCSI to be optional for our 1% who don't want it.

At base, the Kconfig system is designed to give the greatest flexibility with the fewest foot shooting opportunities. However, we do tend to err on the side of flexibility if there's a conflict between the two design goals.

Quoted 6 lines
Quoted 1 line

their own kernel but must learn this fact anew.

When it costs 10000 people half an hour to learn and correct this it wasted 5000 hours of previous livetime.

Besides there is no good reason to have ever learned this imho.

The process of becoming an expert in the kernel build system naturally involves making mistakes and learning from them, so this is probably time reasonably well spent.

James

#33 lore raw
Quoted 9 lines · James Bottomley
Quoted 4 lines · Andi Kleen

When it costs 10000 people half an hour to learn and correct this it wasted 5000 hours of previous livetime.

Besides there is no good reason to have ever learned this imho.

The process of becoming an expert in the kernel build system naturally involves making mistakes and learning from them, so this is probably time reasonably well spent.

Nevertheless we should try to arrange the menus in a way that makes sense to as many people as possible. The difficulty is, different environments call for different menu layouts, as your previous example of SATA DVD-only boxes demonstrates.

However, liberal usage of 'select' is not the ultimate solution to create menus that work for more people. Just one problem with select is that it works behind the back of the people configuring kernels (unless they use an UI with debug options turned on) --- they have less control, they are less informed. ATA already 'select's SCSI. What do we gain from hiding the fact that Linux' SCSI option is not just for those 50-wire ribbons (which people still think SCSI stands for) but is a very central Linux subsystem for even more than what complies to the SCSI family of standards?

'select' should really be limited to switch on small library-like code without further dependencies or requirements. SCSI, together with its upper layer options, is not of this kind of library.

We should think about order and grouping of prompts and the labels of prompts (there were already suggestions in this discussion) before we resort to 'select' --- or even worse, select options unconditionally which are not always necessary to be enabled.

A pro pos grouping of options --- consider how options for another central subsystem are laid out:

	Networking
		Networking options
			...
			TCP/IP networking
			...
		...

	Device Drivers
		...
		Network device support
			...
			Ethernet (10 or 100MBit)
			...
		...

This also happens to reflect the layout of sources in directories, and the current SCSI menu layout is close to source layout too --- but it doesn't have to be that way.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -=-=-
http://arcgraph.de/sr/
#34 lore raw
Quoted 42 lines · Stefan Richter

Nevertheless we should try to arrange the menus in a way that makes sense to as many people as possible. The difficulty is, different environments call for different menu layouts, as your previous example of SATA DVD-only boxes demonstrates.

However, liberal usage of 'select' is not the ultimate solution to create menus that work for more people. Just one problem with select is that it works behind the back of the people configuring kernels (unless they use an UI with debug options turned on) --- they have less control, they are less informed. ATA already 'select's SCSI. What do we gain from hiding the fact that Linux' SCSI option is not just for those 50-wire ribbons (which people still think SCSI stands for) but is a very central Linux subsystem for even more than what complies to the SCSI family of standards?

'select' should really be limited to switch on small library-like code without further dependencies or requirements. SCSI, together with its upper layer options, is not of this kind of library.

We should think about order and grouping of prompts and the labels of prompts (there were already suggestions in this discussion) before we resort to 'select' --- or even worse, select options unconditionally which are not always necessary to be enabled.

A pro pos grouping of options --- consider how options for another central subsystem are laid out:

	Networking
		Networking options
			...
			TCP/IP networking
			...
		...

	Device Drivers
		...
		Network device support
			...
			Ethernet (10 or 100MBit)
			...
		...
Quoted 3 lines

This also happens to reflect the layout of sources in directories, and the current SCSI menu layout is close to source layout too --- but it doesn't have to be that way.

If someone's keen on really restructuring these things -- in this analogy:

Storage

	Storage Options
		...
		Disk
		Optical
		...
	...

Device Drivers

	...
	Storage Support
		...
		IDE
		PATA
		SATA
		SCSI
		USB
		FW
		...
	...

(sound is an example where both in the menus and the tree everything is kept under one top-level sound/ directory, not sound/ and drivers/sound/ as for networking -- opinions may vary which one's better I guess).

This is just config menus -- on a source code level, it would also make sense at least at some point to introduce "storage/" alongside net/ and sound/ and move things around I guess.

Rene.

#35 lore raw
In reply to Andi Kleen

Andi Kleen wrote on 09-09-07 23:22:

Quoted 2 lines

When it costs 10000 people half an hour to learn and correct this it wasted 5000 hours of previous livetime.

         ^^^^^            ^       ^

Poor me. Here I am -- still waiting for my 15 minutes of fame in /this/ life...

;-)

bjd

#36 lore raw
In reply to Jeff Garzik
Quoted 9 lines · Jeff Garzik
Quoted 8 lines · Andi Kleen
Quoted 2 lines

I can see where you're coming from, but logically, this is wrong. There's a huge slew of enterprise machines that only have DVD on SATA.

... and enterprise systems don't really care about a few KB more of code. In fact you definitely want to have SATA compiled in in case you need to recover the machine later when the SAN is down.

Quoted 3 lines

On the other hand, all of these machines will have SCSI disk devices on various other transports, so no harm is done, it's just an inelegant solution.

Quoted 8 lines
Quoted 1 line

Do you know of a better one?

Let's step back a moment and consider the actual scale and impact of the problem at hand.

The vast majority of users are consumers of pre-compiled kernels, built by People With Clue(tm), who figured this stuff out as soon as it was introduced.

We are talking about a patch to kconfig, and the users using pre-compiled kernels are not kconfig users.

Quoted 9 lines

The current setup expresses the dependencies as they exist -- OPTIONAL extras, and that is a problem once a year or so, when someone builds their own kernel but must learn this fact anew.

There is simply no compelling need at all to change things from the current setup.

Our Kconfig system is for people who already know the kernel, not Aunt Tillie.

Couldn't we just remove kconfig and assume that all "people who already know the kernel" anyway prefer to edit their .config using vi? ;-)

In my experience, the vast majority of kconfig users are not the few people working on distribution kernels, most of the kconfig userbase could be better described by the use case "sysadmin who knows about the hardware in his machine and which filesystems he uses".

And there must have been a reason why a leading kernel developer has written a complete book covering only configuration and building of the kernel - the target audience of this book are most likely not "people who already know the kernel".

Quoted 1 line

Jeff

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#37 lore raw
Quoted 7 lines · Adrian Bunk
Quoted 6 lines · Jeff Garzik

Let's step back a moment and consider the actual scale and impact of the problem at hand.

The vast majority of users are consumers of pre-compiled kernels, built by People With Clue(tm), who figured this stuff out as soon as it was introduced.

[...]

Quoted 4 lines

In my experience, the vast majority of kconfig users are not the few people working on distribution kernels, most of the kconfig userbase could be better described by the use case "sysadmin who knows about the hardware in his machine and which filesystems he uses".

The patch which is discussed here is specifically targeted towards users who are convinced that they can migrate to different drivers without reading Kconfig help texts.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#38 lore raw
Quoted 9 lines · Stefan Richter
Quoted 7 lines · Adrian Bunk
Quoted 6 lines · Jeff Garzik

Let's step back a moment and consider the actual scale and impact of the problem at hand.

The vast majority of users are consumers of pre-compiled kernels, built by People With Clue(tm), who figured this stuff out as soon as it was introduced.

[...]

Quoted 8 lines
Quoted 4 lines

In my experience, the vast majority of kconfig users are not the few people working on distribution kernels, most of the kconfig userbase could be better described by the use case "sysadmin who knows about the hardware in his machine and which filesystems he uses".

The patch which is discussed here is specifically targeted towards users who are convinced that they can migrate to different drivers without reading Kconfig help texts.

Nothing about the patch is only about migration.

The same applies if you configure a kernel from scratch.

Do "make menuconfig" with the .config you are normally using, count the number of options that are visible, and ask yourself whether we can really expect users to read the help texts for every single option shown.

People mostly read help texts for options where they don't understand what this option is about - and "Serial ATA" therefore is an option that is likely to get enabled without the user looking at the help text.

Quoted 1 line

Stefan Richter

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#39 lore raw
Quoted 9 lines · Adrian Bunk
Quoted 3 lines · Stefan Richter

The patch which is discussed here is specifically targeted towards users who are convinced that they can migrate to different drivers without reading Kconfig help texts.

Nothing about the patch is only about migration.

The same applies if you configure a kernel from scratch.

Quoted 7 lines

Do "make menuconfig" with the .config you are normally using, count the number of options that are visible, and ask yourself whether we can really expect users to read the help texts for every single option shown.

People mostly read help texts for options where they don't understand what this option is about - and "Serial ATA" therefore is an option that is likely to get enabled without the user looking at the help text.

If you create .config from scratch, then you can get away without reading help texts if you have a target with minimal hardware and protocols requirements and you know all the subsystems involved.

In all other cases, you theoretically need to read all help texts (minus the ones that don't appear because you deselect entire subsystems). In practice, this takes too much time, hence you take an existing .config (yours or somebody else's) and go from there.

Whenever one enables an option for the first time, it would IMO be foolish to ignore its help text.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#40 lore raw

PATCH 1/1 SCSI: update Kconfig help text to indicate SCSI core's widespread usage

---

Applicable to 2.6.23-rc6 and to scsi-misc.

 drivers/scsi/Kconfig |   32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)
drivers/scsi/Kconfig +20 -12
Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================
@@ -12,23 +12,31 @@ config SCSI
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
-	  If you want to use a SCSI hard disk, SCSI tape drive, SCSI CD-ROM or
-	  any other SCSI device under Linux, say Y and make sure that you know
-	  the name of your SCSI host adapter (the card inside your computer
-	  that "speaks" the SCSI protocol, also called SCSI controller),
-	  because you will be asked for it.
-
-	  You also need to say Y here if you have a device which speaks
-	  the SCSI protocol.  Examples of this include the parallel port
-	  version of the IOMEGA ZIP drive, USB storage devices, Fibre
-	  Channel, FireWire storage and the IDE-SCSI emulation driver.
+	  This option enables core support for SCSI protocols.
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    or iSCSI,
+	  - for non-SCSI hardware which speaks SCSI protocols, such as USB
+	    storage devices or the parallel port version of Iomega Zip drive,
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, like the IDE-SCSI emulation driver and most notably
+	    for all SATA drivers.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called scsi_mod.
 
 	  However, do not compile this as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI device.
+	  (the one containing the directory /) is located on a SCSI device
+	  or on a device whose driver represents it as SCSI device, as
+	  indicated above.  Choose Y in this case, or set up an initrd.
+
+	  Subsequent options in this menu enable specific SCSI command set
+	  support for harddisks, CD/DVD-ROM/R/W, tapes etc..  This menu also
+	  presents options for specific SCSI controllers, while options for
+	  some other SCSI transports and all non-SCSI controllers are located
+	  in other menus (SATA, USB, FireWire etc.).
 
 config SCSI_DMA
 	bool
@@ -120,7 +128,7 @@ config BLK_DEV_SR
 	tristate "SCSI CDROM support"
 	depends on SCSI
 	---help---
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
+	  If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM,
 	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
 	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
 	  Y or M to "ISO 9660 CD-ROM file system support" later.
Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#41 lore raw

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 7 lines · Stefan Richter

---

Applicable to 2.6.23-rc6 and to scsi-misc.

 drivers/scsi/Kconfig |   32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)

ACK

#42 lore raw

RFC PATCH 1/1 SCSI: split Kconfig menu into two

In reply to Stefan Richter

The SCSI core and SCSI high-level drivers play a central role not just for the whole lot of different SCSI Architecture types of hardware and protocols, but also for subsystems which drive non SCSI hardware, especially libata.

Hence the options pertaining to SCSI core and high-level are separated out into an own top-level menu outside the "Device Drivers" submenu, and some prompts are reworded.

---

Applies after patch "SCSI: update Kconfig help text to indicate SCSI core's widespread usage", http://lkml.org/lkml/2007/9/14/168. These two patches could very well be collapsed into one.

 arch/alpha/Kconfig            |    2 
 arch/arm/Kconfig              |    2 
 arch/avr32/Kconfig            |    2 
 arch/blackfin/Kconfig         |    2 
 arch/cris/Kconfig             |    2 
 arch/frv/Kconfig              |    2 
 arch/i386/Kconfig             |    2 
 arch/ia64/Kconfig             |    2 
 arch/m32r/Kconfig             |    2 
 arch/m68k/Kconfig             |    2 
 arch/m68knommu/Kconfig        |    2 
 arch/mips/Kconfig             |    2 
 arch/parisc/Kconfig           |    2 
 arch/powerpc/Kconfig          |    2 
 arch/ppc/Kconfig              |    2 
 arch/s390/Kconfig             |    2 
 arch/sh/Kconfig               |    2 
 arch/sh64/Kconfig             |    2 
 arch/sparc/Kconfig            |    2 
 arch/sparc64/Kconfig          |    2 
 arch/um/Kconfig               |    2 
 arch/v850/Kconfig             |    2 
 arch/x86_64/Kconfig           |    4 
 arch/xtensa/Kconfig           |    2 
 drivers/Kconfig               |    2 
 drivers/scsi/Kconfig          | 1589 ----------------------------------
 drivers/scsi/Kconfig.lowlevel | 1578 +++++++++++++++++++++++++++++++++
 27 files changed, 1635 insertions(+), 1584 deletions(-)
arch/alpha/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/alpha/Kconfig
===================================================================
@@ -650,6 +650,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/arm/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/arm/Kconfig
===================================================================
@@ -1003,6 +1003,8 @@ endif
 
 source "drivers/scsi/Kconfig"
 
+source "drivers/scsi/Kconfig.lowlevel"
+
 source "drivers/ata/Kconfig"
 
 source "drivers/md/Kconfig"
arch/avr32/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/avr32/Kconfig
===================================================================
@@ -227,6 +227,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/blackfin/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/blackfin/Kconfig
===================================================================
@@ -910,6 +910,8 @@ endif
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/cris/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/cris/Kconfig
===================================================================
@@ -170,6 +170,8 @@ source "drivers/ide/Kconfig"
 
 source "drivers/scsi/Kconfig"
 
+source "drivers/scsi/Kconfig.lowlevel"
+
 source "drivers/ieee1394/Kconfig"
 
 source "drivers/message/i2o/Kconfig"
arch/frv/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/frv/Kconfig
===================================================================
@@ -371,6 +371,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/i386/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/i386/Kconfig
===================================================================
@@ -1224,6 +1224,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/ia64/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/ia64/Kconfig
===================================================================
@@ -536,6 +536,8 @@ endif
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 config MSPEC
arch/m32r/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/m32r/Kconfig
===================================================================
@@ -422,6 +422,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/m68k/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/m68k/Kconfig
===================================================================
@@ -470,6 +470,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 menu "Character devices"
arch/m68knommu/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/m68knommu/Kconfig
===================================================================
@@ -692,6 +692,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/mips/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/mips/Kconfig
===================================================================
@@ -1912,6 +1912,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/parisc/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/parisc/Kconfig
===================================================================
@@ -263,6 +263,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/powerpc/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/powerpc/Kconfig
===================================================================
@@ -624,6 +624,8 @@ endif
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/ppc/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/ppc/Kconfig
===================================================================
@@ -1423,6 +1423,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/s390/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/s390/Kconfig
===================================================================
@@ -525,6 +525,8 @@ config PCMCIA
 config CCW
 	def_bool y
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/sh/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/sh/Kconfig
===================================================================
@@ -727,6 +727,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/sh64/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/sh64/Kconfig
===================================================================
@@ -281,6 +281,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
arch/sparc/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/sparc/Kconfig
===================================================================
@@ -264,6 +264,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 if !SUN4
arch/sparc64/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/sparc64/Kconfig
===================================================================
@@ -452,6 +452,8 @@ config CMDLINE
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "drivers/sbus/char/Kconfig"
arch/x86_64/Kconfig +3 -1
Index: linux-2.6.23-rc6/arch/x86_64/Kconfig
===================================================================
@@ -777,7 +777,9 @@ endmenu
 
 source "net/Kconfig"
 
-source drivers/Kconfig
+source "drivers/scsi/Kconfig"
+
+source "drivers/Kconfig"
 
 source "drivers/firmware/Kconfig"
 
arch/um/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/um/Kconfig
===================================================================
@@ -324,6 +324,8 @@ source "lib/Kconfig"
 
 source "drivers/scsi/Kconfig"
 
+source "drivers/scsi/Kconfig.lowlevel"
+
 source "drivers/md/Kconfig"
 
 if BROKEN
arch/v850/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/v850/Kconfig
===================================================================
@@ -294,6 +294,8 @@ source "drivers/ide/Kconfig"
 
 source "drivers/scsi/Kconfig"
 
+source "drivers/scsi/Kconfig.lowlevel"
+
 endmenu
 
 #############################################################################
arch/xtensa/Kconfig +2 -0
Index: linux-2.6.23-rc6/arch/xtensa/Kconfig
===================================================================
@@ -230,6 +230,8 @@ endmenu
 
 source "net/Kconfig"
 
+source "drivers/scsi/Kconfig"
+
 source "drivers/Kconfig"
 
 source "fs/Kconfig"
drivers/Kconfig +1 -1
Index: linux-2.6.23-rc6/drivers/Kconfig
===================================================================
@@ -22,7 +22,7 @@ source "drivers/misc/Kconfig"
 
 source "drivers/ide/Kconfig"
 
-source "drivers/scsi/Kconfig"
+source "drivers/scsi/Kconfig.lowlevel"
 
 source "drivers/ata/Kconfig"
 
drivers/scsi/Kconfig +7 -1582

1,624 lines not on this page · raw message

drivers/scsi/Kconfig.lowlevel new file +1578 -0

1,174 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/

Part of the diff is not shown here. View the raw message.

#43 lore raw

PATCH 1/1 SCSI: trailing whitespace in Kconfig

---

Applies after patch "SCSI: split Kconfig menu into two". I didn't want to change whitespace in the portions that this patch moved from drivers/scsi/Kconfig to drivers/scsi/Kconfig.lowlevel, hence produced this follow-up.

 drivers/scsi/Kconfig.lowlevel |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/Kconfig.lowlevel +4 -4
Index: linux-2.6.23-rc6/drivers/scsi/Kconfig.lowlevel
===================================================================
@@ -252,7 +252,7 @@ config SCSI_DPT_I2O
 	tristate "Adaptec I2O RAID support "
 	depends on !64BIT && SCSI && PCI && VIRT_TO_BUS
 	help
-	  This driver supports all of Adaptec's I2O based RAID controllers as 
+	  This driver supports all of Adaptec's I2O based RAID controllers as
 	  well as the DPT SmartRaid V cards.  This is an Adaptec maintained
 	  driver by Deanna Bonds.  See <file:Documentation/scsi/dpti.txt>.
 
@@ -457,7 +457,7 @@ config SCSI_GDTH
 	---help---
 	  Formerly called GDT SCSI Disk Array Controller Support.
 
-	  This is a driver for RAID/SCSI Disk Array Controllers (EISA/ISA/PCI) 
+	  This is a driver for RAID/SCSI Disk Array Controllers (EISA/ISA/PCI)
 	  manufactured by Intel Corporation/ICP vortex GmbH. It is documented
 	  in the kernel source in <file:drivers/scsi/gdth.c> and
 	  <file:drivers/scsi/gdth.h.>
@@ -491,7 +491,7 @@ config SCSI_GENERIC_NCR5380_MMIO
 	select SCSI_SPI_ATTRS
 	---help---
 	  This is a driver for the old NCR 53c80 series of SCSI controllers
-	  on boards using memory mapped I/O. 
+	  on boards using memory mapped I/O.
 	  It is explained in section 3.8 of the SCSI-HOWTO, available from
 	  <http://www.tldp.org/docs.html#howto>.  If it doesn't work out
 	  of the box, you may have to change some settings in
@@ -1261,7 +1261,7 @@ config SCSI_DEBUG
 	  each with multiple dummy SCSI devices (disks). It defaults to one
 	  host adapter with one dummy SCSI disk. Each dummy disk uses kernel
 	  RAM as storage (i.e. it is a ramdisk). To save space when multiple
-	  dummy disks are simulated, they share the same kernel RAM for 
+	  dummy disks are simulated, they share the same kernel RAM for
 	  their storage. See <http://www.torque.net/sg/sdebug.html> for more
 	  information. This driver is primarily of use to those testing the
 	  SCSI and block subsystems. If unsure, say N.
Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#44 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

In reply to Stefan Richter

Hi Stefan.

Such a patch really calls for some minimal unifacation among the architectures.

Quoted 17 lines
 arch/alpha/Kconfig            |    2 
 arch/arm/Kconfig              |    2 
 arch/avr32/Kconfig            |    2 
 arch/blackfin/Kconfig         |    2 
 arch/cris/Kconfig             |    2 
 arch/frv/Kconfig              |    2 
 arch/i386/Kconfig             |    2 
 arch/ia64/Kconfig             |    2 
 arch/m32r/Kconfig             |    2 
 arch/m68k/Kconfig             |    2 
 arch/m68knommu/Kconfig        |    2 
 arch/mips/Kconfig             |    2 
 arch/parisc/Kconfig           |    2 
 arch/powerpc/Kconfig          |    2 
 arch/ppc/Kconfig              |    2 
 arch/s390/Kconfig             |    2 
Quoted 8 lines
 arch/sh/Kconfig               |    2 
 arch/sh64/Kconfig             |    2 
 arch/sparc/Kconfig            |    2 
 arch/sparc64/Kconfig          |    2 
 arch/um/Kconfig               |    2 
 arch/v850/Kconfig             |    2 
 arch/x86_64/Kconfig           |    4 
 arch/xtensa/Kconfig           |    2 

Exactly the same change for all architectures.
IT would be good to introduce a common file that contains some of the shared stuff from the different architectures. We could start out simple with:

arch/Kconfig.arch:

source "net/Kconfig"
source "drivers/Kconfig"
source "fs/Kconfig"
source "security/Kconfig"
source "crypto/Kconfig"
source "lib/Kconfig"

And then source it in all relevant arch Kconfig files. It is not all that can use it but most do.
A trivial task but one small step towards unification between the architectures on the Kconfig level.

Sam

#45 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 32 lines · Sam Ravnborg

Hi Stefan.

Such a patch really calls for some minimal unifacation among the architectures.

Quoted 17 lines
 arch/alpha/Kconfig            |    2 
 arch/arm/Kconfig              |    2 
 arch/avr32/Kconfig            |    2 
 arch/blackfin/Kconfig         |    2 
 arch/cris/Kconfig             |    2 
 arch/frv/Kconfig              |    2 
 arch/i386/Kconfig             |    2 
 arch/ia64/Kconfig             |    2 
 arch/m32r/Kconfig             |    2 
 arch/m68k/Kconfig             |    2 
 arch/m68knommu/Kconfig        |    2 
 arch/mips/Kconfig             |    2 
 arch/parisc/Kconfig           |    2 
 arch/powerpc/Kconfig          |    2 
 arch/ppc/Kconfig              |    2 
 arch/s390/Kconfig             |    2 
Quoted 8 lines
 arch/sh/Kconfig               |    2 
 arch/sh64/Kconfig             |    2 
 arch/sparc/Kconfig            |    2 
 arch/sparc64/Kconfig          |    2 
 arch/um/Kconfig               |    2 
 arch/v850/Kconfig             |    2 
 arch/x86_64/Kconfig           |    4 
 arch/xtensa/Kconfig           |    2 
Quoted 7 lines

Exactly the same change for all architectures.
IT would be good to introduce a common file that contains some of the shared stuff from the different architectures. We could start out simple with:

arch/Kconfig.arch:
...

Stefan simply shouldn't move it out of drivers/Kconfig.

Quoted 1 line

Sam

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#46 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 33 lines · Adrian Bunk
Quoted 32 lines · Sam Ravnborg

Hi Stefan.

Such a patch really calls for some minimal unifacation among the architectures.

Quoted 25 lines
 arch/alpha/Kconfig            |    2 
 arch/arm/Kconfig              |    2 
 arch/avr32/Kconfig            |    2 
 arch/blackfin/Kconfig         |    2 
 arch/cris/Kconfig             |    2 
 arch/frv/Kconfig              |    2 
 arch/i386/Kconfig             |    2 
 arch/ia64/Kconfig             |    2 
 arch/m32r/Kconfig             |    2 
 arch/m68k/Kconfig             |    2 
 arch/m68knommu/Kconfig        |    2 
 arch/mips/Kconfig             |    2 
 arch/parisc/Kconfig           |    2 
 arch/powerpc/Kconfig          |    2 
 arch/ppc/Kconfig              |    2 
 arch/s390/Kconfig             |    2 
 arch/sh/Kconfig               |    2 
 arch/sh64/Kconfig             |    2 
 arch/sparc/Kconfig            |    2 
 arch/sparc64/Kconfig          |    2 
 arch/um/Kconfig               |    2 
 arch/v850/Kconfig             |    2 
 arch/x86_64/Kconfig           |    4 
 arch/xtensa/Kconfig           |    2 
Quoted 7 lines
Quoted 7 lines

Exactly the same change for all architectures.
IT would be good to introduce a common file that contains some of the shared stuff from the different architectures. We could start out simple with:

arch/Kconfig.arch:
...

Yes, that would be good. But Adrian has a point too.

Quoted 1 line

Stefan simply shouldn't move it out of drivers/Kconfig.

From: Stefan Richter <[email protected]>
Subject: SCSI: split Kconfig menu into two

The SCSI core and SCSI high-level drivers play a central role not just for the whole lot of different SCSI Architecture types of hardware and protocols, but also for subsystems which drive non SCSI hardware, especially libata.

Hence the options pertaining to SCSI core and high-level are separated out into an own top-level menu outside the "Device Drivers" submenu, and some prompts are reworded.

---
 drivers/Kconfig               |    4 
 drivers/scsi/Kconfig          | 1589 ----------------------------------
 drivers/scsi/Kconfig.lowlevel | 1578 +++++++++++++++++++++++++++++++++
 3 files changed, 1588 insertions(+), 1583 deletions(-)
drivers/Kconfig +3 -1
Index: linux-2.6.23-rc6/drivers/Kconfig
===================================================================
@@ -1,5 +1,7 @@
 # drivers/Kconfig
 
+source "drivers/scsi/Kconfig"
+
 menu "Device Drivers"
 
 source "drivers/base/Kconfig"
@@ -22,7 +24,7 @@ source "drivers/misc/Kconfig"
 
 source "drivers/ide/Kconfig"
 
-source "drivers/scsi/Kconfig"
+source "drivers/scsi/Kconfig.lowlevel"
 
 source "drivers/ata/Kconfig"
 
drivers/scsi/Kconfig +7 -1582

1,624 lines not on this page · raw message

drivers/scsi/Kconfig.lowlevel new file +1578 -0

1,361 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/

Part of the diff is not shown here. View the raw message.

#47 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 42 lines · Stefan Richter
Quoted 33 lines · Adrian Bunk
Quoted 32 lines · Sam Ravnborg

Hi Stefan.

Such a patch really calls for some minimal unifacation among the architectures.

Quoted 25 lines
 arch/alpha/Kconfig            |    2 
 arch/arm/Kconfig              |    2 
 arch/avr32/Kconfig            |    2 
 arch/blackfin/Kconfig         |    2 
 arch/cris/Kconfig             |    2 
 arch/frv/Kconfig              |    2 
 arch/i386/Kconfig             |    2 
 arch/ia64/Kconfig             |    2 
 arch/m32r/Kconfig             |    2 
 arch/m68k/Kconfig             |    2 
 arch/m68knommu/Kconfig        |    2 
 arch/mips/Kconfig             |    2 
 arch/parisc/Kconfig           |    2 
 arch/powerpc/Kconfig          |    2 
 arch/ppc/Kconfig              |    2 
 arch/s390/Kconfig             |    2 
 arch/sh/Kconfig               |    2 
 arch/sh64/Kconfig             |    2 
 arch/sparc/Kconfig            |    2 
 arch/sparc64/Kconfig          |    2 
 arch/um/Kconfig               |    2 
 arch/v850/Kconfig             |    2 
 arch/x86_64/Kconfig           |    4 
 arch/xtensa/Kconfig           |    2 
Quoted 7 lines
Quoted 7 lines

Exactly the same change for all architectures.
IT would be good to introduce a common file that contains some of the shared stuff from the different architectures. We could start out simple with:

arch/Kconfig.arch:
...

Quoted 8 lines

Yes, that would be good. But Adrian has a point too.

Quoted 1 line

Stefan simply shouldn't move it out of drivers/Kconfig.

...

 drivers/Kconfig               |    4 
 drivers/scsi/Kconfig          | 1589 ----------------------------------
 drivers/scsi/Kconfig.lowlevel | 1578 +++++++++++++++++++++++++++++++++
 3 files changed, 1588 insertions(+), 1583 deletions(-)

Nearly right. ;-)

There are a few architectures not (yet) using drivers/Kconfig.

Quoted 13 lines

Index: linux-2.6.23-rc6/drivers/Kconfig
===================================================================

drivers/Kconfig +2 -0
@@ -1,5 +1,7 @@
 # drivers/Kconfig
 
+source "drivers/scsi/Kconfig"
+
 menu "Device Drivers"
 
 source "drivers/base/Kconfig"

drivers/Kconfig source "drivers/misc/Kconfig" · line 29

Quoted 8 lines
drivers/Kconfig +1 -1
@@ -22,7 +24,7 @@ source "drivers/misc/Kconfig"
 
 source "drivers/ide/Kconfig"
 
-source "drivers/scsi/Kconfig"
+source "drivers/scsi/Kconfig.lowlevel"
 
 source "drivers/ata/Kconfig"
...

This way the order is wrong:

There should first be the lowlevel SCSI, SATA, USB etc. drivers, these drivers should select CONFIG_SCSI, and then the menu offering support for disk, CD,...

Quoted 12 lines

Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================

drivers/scsi/Kconfig +0 -7
@@ -1,14 +1,7 @@
-menu "SCSI device support"
-
-config RAID_ATTRS
-	tristate "RAID Transport Class"
-	default n
-	depends on BLOCK
-	---help---

drivers/scsi/Kconfig line 7

Quoted 10 lines
drivers/scsi/Kconfig +2 -2
-	  Provides RAID
+menu "Storage (core and SCSI commands)"
 
 config SCSI
-	tristate "SCSI device support"
+	tristate "Storage support (core and SCSI commands)"
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
...

What is "storage support"?
SATA?
PATA?
USB mass storage?
MMC?
MTD?

Whether or not a driver uses the SCSI layer is an implementation detail (it even differs for the two USB mass storage implementations and the two PATA implementations in the kernel) the user shouldn't have to know about.

I don't see any reason why CONFIG_SCSI should have to stay user-visible at all after your patch.

Quoted 1 line

Stefan Richter

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#48 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 9 lines · Adrian Bunk
Quoted 4 lines · Stefan Richter
 drivers/Kconfig               |    4 
 drivers/scsi/Kconfig          | 1589 ----------------------------------
 drivers/scsi/Kconfig.lowlevel | 1578 +++++++++++++++++++++++++++++++++
 3 files changed, 1588 insertions(+), 1583 deletions(-)

Nearly right. ;-)

There are a few architectures not (yet) using drivers/Kconfig.

Right, the patch is wrong for those architectures which include drivers/scsi/Kconfig directly, rather than indirectly via drivers/Kconfig.

[...]

Quoted 14 lines
Quoted 14 lines

# drivers/Kconfig

drivers/Kconfig +3 -1
+source "drivers/scsi/Kconfig"
+
 menu "Device Drivers"
 
 source "drivers/base/Kconfig"
@@ -22,7 +24,7 @@ source "drivers/misc/Kconfig"
 
 source "drivers/ide/Kconfig"
 
-source "drivers/scsi/Kconfig"
+source "drivers/scsi/Kconfig.lowlevel"
 
Quoted 8 lines

drivers/Kconfig source "drivers/misc/Kconfig" · line 29

Quoted 2 lines
drivers/Kconfig +0 -0
 source "drivers/ata/Kconfig"
...

This way the order is wrong:

There should first be the lowlevel SCSI, SATA, USB etc. drivers, these drivers should select CONFIG_SCSI, and then the menu offering support for disk, CD,...

The order was inspired by

	# the protocols etc.
	"Networking"
	# the interconnects
	"Device Drivers"/ "Network device support"

So that order is wrong too?

However, there is also precedence for the order which you suggest: The partition and filesystems options come after device driver options.

[...]

Quoted 16 lines

drivers/scsi/Kconfig line 7

Quoted 9 lines
drivers/scsi/Kconfig +2 -1
+menu "Storage (core and SCSI commands)"
 
 config SCSI
-	tristate "SCSI device support"
+	tristate "Storage support (core and SCSI commands)"
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
...

What is "storage support"?
SATA?
PATA?
USB mass storage?
MMC?
MTD?

What is "Networking"? Ethernet? Infiniband? ...?

Quoted 7 lines

Whether or not a driver uses the SCSI layer is an implementation detail (it even differs for the two USB mass storage implementations and the two PATA implementations in the kernel) the user shouldn't have to know about.

I don't see any reason why CONFIG_SCSI should have to stay user-visible at all after your patch.

Vice versa, I don't see any reason for "select SCSI" anywhere after my patch.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#49 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 27 lines · Stefan Richter

Adrian Bunk wrote:
...

Quoted 14 lines
Quoted 14 lines

# drivers/Kconfig

drivers/Kconfig +3 -1
+source "drivers/scsi/Kconfig"
+
 menu "Device Drivers"
 
 source "drivers/base/Kconfig"
@@ -22,7 +24,7 @@ source "drivers/misc/Kconfig"
 
 source "drivers/ide/Kconfig"
 
-source "drivers/scsi/Kconfig"
+source "drivers/scsi/Kconfig.lowlevel"
 
Quoted 8 lines

drivers/Kconfig source "drivers/misc/Kconfig" · line 29

Quoted 2 lines
drivers/Kconfig +0 -0
 source "drivers/ata/Kconfig"
...

This way the order is wrong:

There should first be the lowlevel SCSI, SATA, USB etc. drivers, these drivers should select CONFIG_SCSI, and then the menu offering support for disk, CD,...

The order was inspired by

Quoted 7 lines
	# the protocols etc.
	"Networking"
	# the interconnects
	"Device Drivers"/ "Network device support"

So that order is wrong too?

It's different since _all_ network device drivers require networking support.

Quoted 21 lines

However, there is also precedence for the order which you suggest: The partition and filesystems options come after device driver options.

[...]

Quoted 16 lines

drivers/scsi/Kconfig line 7

Quoted 9 lines
drivers/scsi/Kconfig +2 -1
+menu "Storage (core and SCSI commands)"
 
 config SCSI
-	tristate "SCSI device support"
+	tristate "Storage support (core and SCSI commands)"
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
...

What is "storage support"?
SATA?
PATA?
USB mass storage?
MMC?
MTD?

Quoted 1 line

What is "Networking"? Ethernet? Infiniband? ...?

Different to CONFIG_SCSI, CONFIG_NET=n is so exotic that we should change it to no longer show users the question unless CONFIG_EMBEDDED=y.

Quoted 10 lines
Quoted 7 lines

Whether or not a driver uses the SCSI layer is an implementation detail (it even differs for the two USB mass storage implementations and the two PATA implementations in the kernel) the user shouldn't have to know about.

I don't see any reason why CONFIG_SCSI should have to stay user-visible at all after your patch.

Vice versa, I don't see any reason for "select SCSI" anywhere after my patch.

If users who don't need it now enable CONFIG_SCSI (and drivers/ide/ usage is not that uncommon) that's a regression in the user interface.

If the lowlevel SCSI drivers move into a separate menu as your patch does, we simply no longer have any good reason for bothering the user with the CONFIG_SCSI.

Quoted 1 line

Stefan Richter

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#50 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 3 lines · Adrian Bunk
Quoted 3 lines
Quoted 3 lines

There should first be the lowlevel SCSI, SATA, USB etc. drivers, these drivers should select CONFIG_SCSI, and then the menu offering support for disk, CD,...

...

Quoted 2 lines

If users who don't need it now enable CONFIG_SCSI (and drivers/ide/ usage is not that uncommon) that's a regression in the user interface.

Aha, first all interconnects/transports are configured. If none of them 'select'ed SCSI, the menu for sd, sr, st stays invisible. Otherwise it is exposed.

It still doesn't entirely clarify whether users need sd, sr, st, and whether thy need sd for the disk with root filesystem.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#51 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 8 lines · Stefan Richter
Quoted 3 lines · Adrian Bunk
Quoted 3 lines
Quoted 3 lines

There should first be the lowlevel SCSI, SATA, USB etc. drivers, these drivers should select CONFIG_SCSI, and then the menu offering support for disk, CD,...

...

Quoted 2 lines

If users who don't need it now enable CONFIG_SCSI (and drivers/ide/ usage is not that uncommon) that's a regression in the user interface.

Quoted 6 lines

Aha, first all interconnects/transports are configured. If none of them 'select'ed SCSI, the menu for sd, sr, st stays invisible. Otherwise it is exposed.

It still doesn't entirely clarify whether users need sd, sr, st, and whether thy need sd for the disk with root filesystem.

If you want to do it in a really perfect way, help texts aren't the solution. You'll have to make the options like CONFIG_BLK_DEV_SR no longer be user visible and select'ed through dummy options like e.g.:

config USB_STORAGE
tristate "USB Mass Storage support"
depends on USB
select SCSI
help
...

config USB_STORAGE_SD
tristate "USB Mass Storage hard disk support" depends on USB_STORAGE
select BLK_DEV_SD
help
...

config USB_STORAGE_SR
tristate "USB Mass Storage CD/DVD support" depends on USB_STORAGE
select BLK_DEV_SR
help
...

Quoted 1 line

Stefan Richter

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#52 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 7 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

It still doesn't entirely clarify whether users need sd, sr, st, and whether thy need sd for the disk with root filesystem.

If you want to do it in a really perfect way, help texts aren't the solution. You'll have to make the options like CONFIG_BLK_DEV_SR no longer be user visible and select'ed through dummy options like e.g.:

...

Quoted 3 lines

tristate "USB Mass Storage hard disk support" depends on USB_STORAGE
select BLK_DEV_SD

...

Quoted 3 lines

tristate "USB Mass Storage CD/DVD support" depends on USB_STORAGE
select BLK_DEV_SR

...

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Also, one more question on whether CONFIG_SCSI ought to be 'select'ed:
Where do scsi-core options like CONFIG_SCSI_CONSTANTS go?

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#53 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 12 lines · Stefan Richter
Quoted 7 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

It still doesn't entirely clarify whether users need sd, sr, st, and whether thy need sd for the disk with root filesystem.

If you want to do it in a really perfect way, help texts aren't the solution. You'll have to make the options like CONFIG_BLK_DEV_SR no longer be user visible and select'ed through dummy options like e.g.:

...

Quoted 3 lines

tristate "USB Mass Storage hard disk support" depends on USB_STORAGE
select BLK_DEV_SD

Quoted 8 lines

...

Quoted 3 lines

tristate "USB Mass Storage CD/DVD support" depends on USB_STORAGE
select BLK_DEV_SR

...

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Kconfig is a user interface, so perfect is what is best for the kconfig users.

Quoted 2 lines

Also, one more question on whether CONFIG_SCSI ought to be 'select'ed:
Where do scsi-core options like CONFIG_SCSI_CONSTANTS go?

The first question is whether it's for actual SCSI hardware [1] or for the block layer functionality which the SCSI subsystem has become. The mixture of these two is the root of much user confusion.

With the help text "The error messages regarding your SCSI hardware will be easier to understand if you say Y here" a user wouldn't have expected to see you using it in a firewire driver. But unless I miss anything, the setting of SCSI_SCAN_ASYNC does only affect "real" SCSI hardware.

If you check each option and place it either in the generic storage menu or the SCSI lowlevel menu this would fix much possible user confusion.

But these are relatively unimportant options compared to e.g. USB_STORAGE=y, BLK_DEV_SD=n, which is a misconfiguration many users run into, so having one menu somewhere with these advanced options should be enough.

Quoted 1 line

Stefan Richter

cu
Adrian

[1] SCSI as in "sold as SCSI"

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#54 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 6 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Kconfig is a user interface, so perfect is what is best for the kconfig users.

Duplicate options with different names in different menus, but which all do the same, --- is this the best for users?

Quoted 10 lines
Quoted 2 lines

Also, one more question on whether CONFIG_SCSI ought to be 'select'ed:
Where do scsi-core options like CONFIG_SCSI_CONSTANTS go?

The first question is whether it's for actual SCSI hardware [1] or for the block layer functionality which the SCSI subsystem has become. The mixture of these two is the root of much user confusion.

With the help text "The error messages regarding your SCSI hardware will be easier to understand if you say Y here" a user wouldn't have expected to see you using it in a firewire driver.

FireWire hardware which implements SBP-2 is SCSI hardware... But this detail aside --- yes, of course this help text is old and misleading.

Quoted 2 lines

But unless I miss anything,
the setting of SCSI_SCAN_ASYNC does only affect "real" SCSI hardware.

It affects every hardware which is driven by scsi low-level providers which have been integrated with the SCSI_SCAN_ASYNC facility.

Quoted 7 lines

If you check each option and place it either in the generic storage menu or the SCSI lowlevel menu this would fix much possible user confusion.

But these are relatively unimportant options compared to e.g. USB_STORAGE=y, BLK_DEV_SD=n, which is a misconfiguration many users run into, so having one menu somewhere with these advanced options should be enough.

True.

So,
config SCSI_CONSTANTS
"Kernel log messages from the SCSI subsystem will be easier to understand if you say Y here..."
would say what this option really does. But to some degree the need to explain what the SCSI subsystem or SCSI core is and which other subsystems make use of it remains. Maybe it's OK to provide documentation of this kind outside of Kconfig help though.

Quoted 1 line

[1] SCSI as in "sold as SCSI"

Difficult. Does e.g. hardware sold as SAS count as "sold as SCSI"? How about SBP-2 then? ;-)

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#55 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 9 lines · Stefan Richter
Quoted 5 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Kconfig is a user interface, so perfect is what is best for the kconfig users.

Duplicate options with different names in different menus, but which all do the same, --- is this the best for users?

I recognize it's a rhetorical question :) The answer is of course "no".

I hope the other participants of this thread register the severe disinclination of the maintainers to change this stuff, as this is a classic case of making a mountain out of a molehill[1].

For the -vast majority- of people configuring the kernel, this is not a problem. Kernel people are -expected- to know what they're doing, especially when switching from one major subsystem to another.

Therefore, all this is IMO wasted effort and hot air. There are far more important issues to deal with.

Jeff

[1] http://www.bartleby.com/59/4/makeamountai.html

#56 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 10 lines · Jeff Garzik
Quoted 8 lines · Stefan Richter
Quoted 5 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Kconfig is a user interface, so perfect is what is best for the kconfig users.

Duplicate options with different names in different menus, but which all do the same, --- is this the best for users?

Quoted 8 lines

I recognize it's a rhetorical question :) The answer is of course "no".

I hope the other participants of this thread register the severe disinclination of the maintainers to change this stuff, as this is a classic case of making a mountain out of a molehill[1].

For the -vast majority- of people configuring the kernel, this is not a problem. Kernel people are -expected- to know what they're doing,

I doubt your claim is true since the vast majority of kconfig users are most likely not kernel developers.

@Greg:
Do you have any numbers regarding how your "Linux Kernel in a Nutshell" is selling?
Even download numbers?

Quoted 1 line

especially when switching from one major subsystem to another.

It's not only about switching, the same problems awaits people when configuring a kernel for their hardware the first time.

Quoted 2 lines

Therefore, all this is IMO wasted effort and hot air. There are far more important issues to deal with.

Why don't we dump kconfig and write the .config by hand? ;-)

More seriously:
Yes, there are many other important issues in the kernel. But not fixing kconfig UI problems doesn't fix these issues faster.

I have seen people running into problems because some required option wasn't set - in the simplest cases things like IDE without DMA because a help text wasn't updated when more hardware support was added to a driver.

You might not care about the kconfig users.
But other people do.

Quoted 2 lines

Jeff
...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#57 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 17 lines · Adrian Bunk
Quoted 16 lines · Jeff Garzik
Quoted 8 lines · Stefan Richter
Quoted 5 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Kconfig is a user interface, so perfect is what is best for the kconfig users.

Duplicate options with different names in different menus, but which all do the same, --- is this the best for users?

I recognize it's a rhetorical question :) The answer is of course "no".

I hope the other participants of this thread register the severe disinclination of the maintainers to change this stuff, as this is a classic case of making a mountain out of a molehill[1].

Quoted 5 lines
Quoted 2 lines

For the -vast majority- of people configuring the kernel, this is not a problem. Kernel people are -expected- to know what they're doing,

I doubt your claim is true since the vast majority of kconfig users are most likely not kernel developers.

Yes, we shouldn't be needlessly raising the bar for power users.

Quoted 9 lines

@Greg:
Do you have any numbers regarding how your "Linux Kernel in a Nutshell" is selling?
Even download numbers?

Quoted 1 line

especially when switching from one major subsystem to another.

It's not only about switching, the same problems awaits people when configuring a kernel for their hardware the first time.

*nods*

Quoted 8 lines
Quoted 2 lines

Therefore, all this is IMO wasted effort and hot air. There are far more important issues to deal with.

Why don't we dump kconfig and write the .config by hand? ;-)

More seriously:
Yes, there are many other important issues in the kernel. But not fixing kconfig UI problems doesn't fix these issues faster.

Agreed, and actually not fixing Kconfig UI problems will make the other issues being fixed *slower* (because they result in *increased* workload on developers' side).

Quoted 4 lines

I have seen people running into problems because some required option wasn't set - in the simplest cases things like IDE without DMA because a help text wasn't updated when more hardware support was added to a driver.

This is why nowadays IDE DMA support is automatically selected by IDE host drivers that need it - a big relief for everybody.

Quoted 2 lines

You might not care about the kconfig users.
But other people do.

...and even if their attempts/solutions may not be proper yet they should not be discouraged to work on these problems...

Thanks,
Bart

#58 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 13 lines · Bartlomiej Zolnierkiewicz
Quoted 12 lines · Adrian Bunk
Quoted 11 lines · Jeff Garzik
Quoted 8 lines · Stefan Richter
Quoted 5 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Kconfig is a user interface, so perfect is what is best for the kconfig users.

Duplicate options with different names in different menus, but which all do the same, --- is this the best for users?

I recognize it's a rhetorical question :) The answer is of course "no".

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I hope the other participants of this thread register the severe disinclination of the maintainers to change this stuff, as this is a classic case of making a mountain out of a molehill[1].

For the -vast majority- of people configuring the kernel, this is not a problem. Kernel people are -expected- to know what they're doing,

I doubt your claim is true since the vast majority of kconfig users are most likely not kernel developers.

Yes, we shouldn't be needlessly raising the bar for power users.

In this case, no bar is being "raised," for any user.

Quoted 12 lines
Quoted 6 lines

@Greg:
Do you have any numbers regarding how your "Linux Kernel in a Nutshell" is selling? Even download numbers?

Quoted 1 line

especially when switching from one major subsystem to another.

It's not only about switching, the same problems awaits people when configuring a kernel for their hardware the first time.

*nods*

Quoted 3 lines
Quoted 1 line

Therefore, all this is IMO wasted effort and hot air. There are far more important issues to deal with.

Why don't we dump kconfig and write the .config by hand? ;-)

Quoted 7 lines
Quoted 3 lines

More seriously:
Yes, there are many other important issues in the kernel. But not fixing kconfig UI problems doesn't fix these issues faster.

Agreed, and actually not fixing Kconfig UI problems will make the other issues being fixed *slower* (because they result in *increased* workload on developers' side).

Irrelevant in this case, because there is no increased workload on the developer's side.

Quoted 4 lines
Quoted 1 line

I have seen people running into problems because some required option wasn't set - in the simplest cases things like IDE without DMA because a help text wasn't updated when more hardware support was added to a driver.

This is why nowadays IDE DMA support is automatically selected by IDE host drivers that need it - a big relief for everybody.

Please don't take this any more off-topic than it already is.

IDE DMA option was vastly different. The options in question here affect whether or not you have a block device to use -- something that is immediately obviously and corrected quickly.

Quoted 5 lines
Quoted 2 lines

You might not care about the kconfig users.
But other people do.

...and even if their attempts/solutions may not be proper yet they should not be discouraged to work on these problems...

There is no problem, in this case.

Otherwise, there would be more than a complaint or two per year.

Jeff

#59 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 18 lines · Jeff Garzik
Quoted 17 lines · Bartlomiej Zolnierkiewicz
Quoted 16 lines · Adrian Bunk
Quoted 15 lines · Jeff Garzik
Quoted 8 lines · Stefan Richter
Quoted 5 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Kconfig is a user interface, so perfect is what is best for the kconfig users.

Duplicate options with different names in different menus, but which all do the same, --- is this the best for users?

I recognize it's a rhetorical question :) The answer is of course "no".

I hope the other participants of this thread register the severe disinclination of the maintainers to change this stuff, as this is a classic case of making a mountain out of a molehill[1].

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

For the -vast majority- of people configuring the kernel, this is not a problem. Kernel people are -expected- to know what they're doing,

I doubt your claim is true since the vast majority of kconfig users are most likely not kernel developers.

Yes, we shouldn't be needlessly raising the bar for power users.

In this case, no bar is being "raised," for any user.

It has already been raised by making SATA configuration counterintuitive (SATA has a separate Kconfig menu but depends on SCSI device drivers).

Quoted 19 lines
Quoted 19 lines
Quoted 8 lines

@Greg:
Do you have any numbers regarding how your "Linux Kernel in a Nutshell" is selling?
Even download numbers?

Quoted 1 line

especially when switching from one major subsystem to another.

It's not only about switching, the same problems awaits people when configuring a kernel for their hardware the first time.

*nods*

Quoted 7 lines
Quoted 2 lines

Therefore, all this is IMO wasted effort and hot air. There are far more important issues to deal with.

Why don't we dump kconfig and write the .config by hand? ;-)

More seriously:
Yes, there are many other important issues in the kernel. But not fixing kconfig UI problems doesn't fix these issues faster.

Quoted 6 lines
Quoted 3 lines

Agreed, and actually not fixing Kconfig UI problems will make the other issues being fixed *slower* (because they result in *increased* workload on developers' side).

Irrelevant in this case, because there is no increased workload on the developer's side.

This thread alone serves as a perfect counter-example. ;)

Quoted 9 lines
Quoted 7 lines
Quoted 4 lines

I have seen people running into problems because some required option wasn't set - in the simplest cases things like IDE without DMA because a help text wasn't updated when more hardware support was added to a driver.

This is why nowadays IDE DMA support is automatically selected by IDE host drivers that need it - a big relief for everybody.

Please don't take this any more off-topic than it already is.

OK, I'll stop here and I'll just patiently wait till the SATA Kconfig issue comes up again on LKML (then I'll just smile and move on to the next post 8).

Quoted 3 lines

IDE DMA option was vastly different. The options in question here affect whether or not you have a block device to use -- something that is immediately obviously and corrected quickly.

Indeed -- completely different situation.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

You might not care about the kconfig users.
But other people do.

...and even if their attempts/solutions may not be proper yet they should not be discouraged to work on these problems...

There is no problem, in this case.

Fine with me then. The above was the most important part for me.

Quoted 1 line

Otherwise, there would be more than a complaint or two per year.

Thanks,
Bart

#60 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

In reply to Adrian Bunk
Quoted 4 lines · Adrian Bunk

@Greg:
Do you have any numbers regarding how your "Linux Kernel in a Nutshell" is selling?

It is selling reasonably well for an O'Reilly book from what I have been told. But I have not seen any real numbers yet.

Quoted 1 line

Even download numbers?

The downloads are spread around all of the kernel.org mirrors so I have absolutely no idea what they are.

Nor do I really want to, as it doesn't matter to me.

thanks,

greg k-h

#61 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

In reply to Stefan Richter
Quoted 10 lines · Stefan Richter
Quoted 6 lines · Adrian Bunk
Quoted 2 lines · Stefan Richter

Perfect is in the eye of the beholder. You would consequently have to add such options into all menus which contain scsi low-level providers.

Kconfig is a user interface, so perfect is what is best for the kconfig users.

Duplicate options with different names in different menus, but which all do the same, --- is this the best for users?

Different to your approach of trying to achieve the same with one huge help text I see a realistic chance of it working.

What's other alternatives do we have?

Automatically select BLK_DEV_SD and BLK_DEV_SR if one driver that uses the SCSI layer gets enabled by the user?

Quoted 30 lines
Quoted 10 lines
Quoted 2 lines

Also, one more question on whether CONFIG_SCSI ought to be 'select'ed:
Where do scsi-core options like CONFIG_SCSI_CONSTANTS go?

The first question is whether it's for actual SCSI hardware [1] or for the block layer functionality which the SCSI subsystem has become. The mixture of these two is the root of much user confusion.

With the help text "The error messages regarding your SCSI hardware will be easier to understand if you say Y here" a user wouldn't have expected to see you using it in a firewire driver.

FireWire hardware which implements SBP-2 is SCSI hardware... But this detail aside --- yes, of course this help text is old and misleading.

Quoted 2 lines

But unless I miss anything,
the setting of SCSI_SCAN_ASYNC does only affect "real" SCSI hardware.

It affects every hardware which is driven by scsi low-level providers which have been integrated with the SCSI_SCAN_ASYNC facility.

Quoted 7 lines

If you check each option and place it either in the generic storage menu or the SCSI lowlevel menu this would fix much possible user confusion.

But these are relatively unimportant options compared to e.g. USB_STORAGE=y, BLK_DEV_SD=n, which is a misconfiguration many users run into, so having one menu somewhere with these advanced options should be enough.

True.

Quoted 8 lines

So,
config SCSI_CONSTANTS
"Kernel log messages from the SCSI subsystem will be easier to understand if you say Y here..."
would say what this option really does. But to some degree the need to explain what the SCSI subsystem or SCSI core is and which other subsystems make use of it remains. Maybe it's OK to provide documentation of this kind outside of Kconfig help though.

This is a debug option and it's unlikely that users will need it unless someone explicitely requested them to do so, so it's not such an important issue.

Quoted 4 lines
Quoted 1 line

[1] SCSI as in "sold as SCSI"

Difficult. Does e.g. hardware sold as SAS count as "sold as SCSI"? How about SBP-2 then? ;-)

If SBP-2 is what you get in a shop when asking for an external Firewire disk enclosure then it's not sold as SCSI.

Quoted 1 line

Stefan Richter

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#62 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

In reply to Stefan Richter
Quoted 17 lines · Stefan Richter
Quoted 16 lines

drivers/scsi/Kconfig line 7

Quoted 9 lines
drivers/scsi/Kconfig +2 -1
+menu "Storage (core and SCSI commands)"
 
 config SCSI
-	tristate "SCSI device support"
+	tristate "Storage support (core and SCSI commands)"
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
...

What is "storage support"?
SATA?
PATA?
USB mass storage?
MMC?
MTD?

Quoted 1 line

What is "Networking"? Ethernet? Infiniband? ...?

SCSI is a generic peripheral bus (recall the expansion of the acronym).
Even though probably the most common, storage is one of its applications only (think scanners for an immediately obvious other one). I find describing CONFIG_SCSI as "storage support" misleading and inappropriate.

Referring to your example it is like calling generic networking (i.e.
CONFIG_NET) "Ethernet support".

Maciej

#63 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

Quoted 1 line · Maciej W. Rozycki

SCSI is a generic peripheral bus

No, not anymore. http://www.t10.org/scsi-3.htm

Quoted 1 line

(recall the expansion of the acronym).

The expansion of the acronym doesn't fit anymore to what SCSI is today, or even to what it became already circa 10 years ago.

Quoted 3 lines

Even though probably the most common, storage is one of its applications only (think scanners for an immediately obvious other one). I find describing CONFIG_SCSI as "storage support" misleading and inappropriate.

Right. I wrote that in lack of better words, but at least I added "SCSI commands" in parentheses. Something like "SCSI I/O - core and command sets" would much better describe what it is, but it would put "SCSI" first again and thus wouldn't reflect that Linux' SCSI core and highlevel is in broader use than just for actual SCSI hardware... Of course there is no way around the issue that Linux' SCSI core's and highlevel's role cannot be characterized in 3...6 words only, but there should be a way to point out its general importance.

Quoted 2 lines

Referring to your example it is like calling generic networking (i.e.
CONFIG_NET) "Ethernet support".

Wrong comparison.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= =---=
http://arcgraph.de/sr/
#64 lore raw

Re: [RFC PATCH] SCSI: split Kconfig menu into two

In reply to Stefan Richter
Quoted 2 lines · I wrote:

Applies after patch "SCSI: update Kconfig help text to indicate SCSI core's widespread usage",

Actually the addition "This menu also presents options for specific SCSI controllers..." from that patch is then no longer true.

Quoted 1 line

These two patches could very well be collapsed into one.

(I'll gladly do that, or only send an update of the 'split Kconfig menu' patch with that sentence backed out, if desired.)

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#65 lore raw

PATCH 1/1 SCSI: split Kconfig menu into two

Date:
From: Stefan Richter <[email protected]>
Subject: SCSI: split Kconfig menu into two

The SCSI core and SCSI high-level drivers play a central role not just for the whole lot of different SCSI Architecture types of hardware and protocols, but also for subsystems which drive non SCSI hardware, especially libata.

Hence the options pertaining to SCSI core and high-level are separated out into an own top-level menu outside the "Device Drivers" submenu, and some prompts are reworded.

---

Update: adjusted to "[PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage" from September 14, 23:14:21 +0200

 drivers/Kconfig               |    4 
 drivers/scsi/Kconfig          | 1587 ----------------------------------
 drivers/scsi/Kconfig.lowlevel | 1578 +++++++++++++++++++++++++++++++++
 3 files changed, 1584 insertions(+), 1585 deletions(-)
drivers/Kconfig +3 -1
Index: linux-2.6.23-rc6/drivers/Kconfig
===================================================================
@@ -1,5 +1,7 @@
 # drivers/Kconfig
 
+source "drivers/scsi/Kconfig"
+
 menu "Device Drivers"
 
 source "drivers/base/Kconfig"
@@ -22,7 +24,7 @@ source "drivers/misc/Kconfig"
 
 source "drivers/ide/Kconfig"
 
-source "drivers/scsi/Kconfig"
+source "drivers/scsi/Kconfig.lowlevel"
 
 source "drivers/ata/Kconfig"
 
drivers/scsi/Kconfig +3 -1584

1,605 lines not on this page · raw message

drivers/scsi/Kconfig.lowlevel new file +1578 -0

1,380 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/

Part of the diff is not shown here. View the raw message.

#66 lore raw

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

In reply to Stefan Richter
Quoted 56 lines · Stefan Richter

---

Applicable to 2.6.23-rc6 and to scsi-misc.

 drivers/scsi/Kconfig |   32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)

Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================

drivers/scsi/Kconfig +19 -11
@@ -12,23 +12,31 @@ config SCSI
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
-	  If you want to use a SCSI hard disk, SCSI tape drive, SCSI CD-ROM or
-	  any other SCSI device under Linux, say Y and make sure that you know
-	  the name of your SCSI host adapter (the card inside your computer
-	  that "speaks" the SCSI protocol, also called SCSI controller),
-	  because you will be asked for it.
-
-	  You also need to say Y here if you have a device which speaks
-	  the SCSI protocol.  Examples of this include the parallel port
-	  version of the IOMEGA ZIP drive, USB storage devices, Fibre
-	  Channel, FireWire storage and the IDE-SCSI emulation driver.
+	  This option enables core support for SCSI protocols.
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    or iSCSI,
+	  - for non-SCSI hardware which speaks SCSI protocols, such as USB
+	    storage devices or the parallel port version of Iomega Zip drive,
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, like the IDE-SCSI emulation driver and most notably
+	    for all SATA drivers.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called scsi_mod.
 
 	  However, do not compile this as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI device.
+	  (the one containing the directory /) is located on a SCSI device
+	  or on a device whose driver represents it as SCSI device, as
+	  indicated above.  Choose Y in this case, or set up an initrd.
+
+	  Subsequent options in this menu enable specific SCSI command set
+	  support for harddisks, CD/DVD-ROM/R/W, tapes etc..  This menu also
+	  presents options for specific SCSI controllers, while options for
+	  some other SCSI transports and all non-SCSI controllers are located
+	  in other menus (SATA, USB, FireWire etc.).
 
 config SCSI_DMA
 	bool

drivers/scsi/Kconfig config BLK_DEV_SR · line 134

Quoted 8 lines
drivers/scsi/Kconfig +1 -1
@@ -120,7 +128,7 @@ config BLK_DEV_SR
 	tristate "SCSI CDROM support"
 	depends on SCSI
 	---help---
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
+	  If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM,
 	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
 	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
 	  Y or M to "ISO 9660 CD-ROM file system support" later.

You left out PATA running libata drivers. Not just SATA is affected there. Looks pretty decent otherwise.

--
Len Sorensen

#67 lore raw

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 1 line · Lennart Sorensen

On Fri, Sep 14, 2007 at 06:01:53PM +0200, Stefan Richter wrote:

...

Quoted 3 lines
Quoted 3 lines
(quoted diff) +3 -0
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, like the IDE-SCSI emulation driver and most notably
+	    for all SATA drivers.

...

Quoted 2 lines

You left out PATA running libata drivers. Not just SATA is affected there. Looks pretty decent otherwise.

From: Stefan Richter <[email protected]>
Subject: SCSI: update Kconfig help text to indicate SCSI core's widespread usage

---
 drivers/scsi/Kconfig |   32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)
drivers/scsi/Kconfig +20 -12
Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================
@@ -12,23 +12,31 @@ config SCSI
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
-	  If you want to use a SCSI hard disk, SCSI tape drive, SCSI CD-ROM or
-	  any other SCSI device under Linux, say Y and make sure that you know
-	  the name of your SCSI host adapter (the card inside your computer
-	  that "speaks" the SCSI protocol, also called SCSI controller),
-	  because you will be asked for it.
-
-	  You also need to say Y here if you have a device which speaks
-	  the SCSI protocol.  Examples of this include the parallel port
-	  version of the IOMEGA ZIP drive, USB storage devices, Fibre
-	  Channel, FireWire storage and the IDE-SCSI emulation driver.
+	  This option enables core support for SCSI protocols.
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    or iSCSI,
+	  - for non-SCSI hardware which speaks SCSI protocols, such as USB
+	    storage devices or the parallel port version of Iomega Zip drive,
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, most notably all Serial ATA drivers, and Parallel ATA
+	    via the ATA configuration option.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called scsi_mod.
 
 	  However, do not compile this as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI device.
+	  (the one containing the directory /) is located on a SCSI device
+	  or on a device whose driver represents it as SCSI device, as
+	  indicated above.  Choose Y in this case, or set up an initrd.
+
+	  Subsequent options in this menu enable specific SCSI command set
+	  support for harddisks, CD/DVD-ROM/R/W, tapes etc..  This menu also
+	  presents options for specific SCSI controllers, while options for
+	  some other SCSI transports and all non-SCSI controllers are located
+	  in other menus (SATA, USB, FireWire etc.).
 
 config SCSI_DMA
 	bool
@@ -120,7 +128,7 @@ config BLK_DEV_SR
 	tristate "SCSI CDROM support"
 	depends on SCSI
 	---help---
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
+	  If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM,
 	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
 	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
 	  Y or M to "ISO 9660 CD-ROM file system support" later.
Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#68 lore raw

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

drivers/scsi/Kconfig config BLK_DEV_SR · line 134

Quoted 5 lines · Stefan Richter
drivers/scsi/Kconfig +1 -1
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
+	  If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM,
 	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
 	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
 	  Y or M to "ISO 9660 CD-ROM file system support" later.

How about that one for libata driven PATA CDROM drives? Could replace SATA with libata, or something similar.

--
Len Sorensen

#69 lore raw

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 9 lines · Lennart Sorensen

Review

Quoted 5 lines · Stefan Richter
(quoted diff) +1 -1
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
+	  If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM,
 	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
 	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
 	  Y or M to "ISO 9660 CD-ROM file system support" later.

How about that one for libata driven PATA CDROM drives? Could replace SATA with libata, or something similar.

From: Stefan Richter <[email protected]>
Subject: SCSI: update Kconfig help text to indicate SCSI core's widespread usage

---
 drivers/scsi/Kconfig |   67 ++++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 32 deletions(-)
drivers/scsi/Kconfig +35 -32
Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================
@@ -12,23 +12,31 @@ config SCSI
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
-	  If you want to use a SCSI hard disk, SCSI tape drive, SCSI CD-ROM or
-	  any other SCSI device under Linux, say Y and make sure that you know
-	  the name of your SCSI host adapter (the card inside your computer
-	  that "speaks" the SCSI protocol, also called SCSI controller),
-	  because you will be asked for it.
-
-	  You also need to say Y here if you have a device which speaks
-	  the SCSI protocol.  Examples of this include the parallel port
-	  version of the IOMEGA ZIP drive, USB storage devices, Fibre
-	  Channel, FireWire storage and the IDE-SCSI emulation driver.
+	  This option enables core support for SCSI protocols.
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    or iSCSI,
+	  - for non-SCSI hardware which speaks SCSI protocols, such as USB
+	    storage devices or the parallel port version of Iomega Zip drive,
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, most notably all Serial ATA drivers, and Parallel ATA
+	    via the ATA configuration option.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called scsi_mod.
 
 	  However, do not compile this as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI device.
+	  (the one containing the directory /) is located on a SCSI device
+	  or on a device whose driver represents it as SCSI device, as
+	  indicated above.  Choose Y in this case, or set up an initrd.
+
+	  Subsequent options in this menu enable specific SCSI command set
+	  support for harddisks, CD/DVD-ROM/R/W, tapes etc..  This menu also
+	  presents options for specific SCSI controllers, while options for
+	  some other SCSI transports and all non-SCSI controllers are located
+	  in other menus (SATA, USB, FireWire etc.).
 
 config SCSI_DMA
 	bool
@@ -57,32 +65,27 @@ config SCSI_PROC_FS
 
 	  If unsure say Y.
 
-comment "SCSI support type (disk, tape, CD-ROM)"
+comment "SCSI command set drivers (disk, tape, CD-ROM)"
 	depends on SCSI
 
 config BLK_DEV_SD
-	tristate "SCSI disk support"
+	tristate "Harddisks and other Direct access devices"
 	depends on SCSI
 	---help---
-	  If you want to use SCSI hard disks, Fibre Channel disks,
-	  Serial ATA (SATA) or Parallel ATA (PATA) hard disks,
-	  USB storage or the SCSI or parallel port version of
-	  the IOMEGA ZIP drive, say Y and read the SCSI-HOWTO,
-	  the Disk-HOWTO and the Multi-Disk-HOWTO, available from
-	  <http://www.tldp.org/docs.html#howto>. This is NOT for SCSI
-	  CD-ROMs.
+	  Say Y if you want to use harddisks and similar block-oriented devices
+	  via SCSI or via drivers which use SCSI command sets (e.g. the Serial
+	  and Parallel ATA kernel subsystem, USB, and more).
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called sd_mod.
 
-	  Do not compile this driver as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI disk.
-	  In this case, do not compile the driver for your SCSI host adapter
-	  (below) as a module either.
+	  If your root file system (the one containing the directory /) is
+	  located on a disk which accessed via this driver, choose Y instead of
+	  M or set up a suitable initrd.
 
 config CHR_DEV_ST
-	tristate "SCSI tape support"
+	tristate "Tape drives"
 	depends on SCSI
 	---help---
 	  If you want to use a SCSI tape drive under Linux, say Y and read the
@@ -95,7 +98,7 @@ config CHR_DEV_ST
 	  <file:Documentation/scsi/scsi.txt>. The module will be called st.
 
 config CHR_DEV_OSST
-	tristate "SCSI OnStream SC-x0 tape support"
+	tristate "SCSI OnStream SC-x0 tape drives"
 	depends on SCSI
 	---help---
 	  The OnStream SC-x0 SCSI tape drives cannot be driven by the
@@ -117,13 +120,13 @@ config CHR_DEV_OSST
 	  <file:Documentation/scsi/scsi.txt>. The module will be called osst.
 
 config BLK_DEV_SR
-	tristate "SCSI CDROM support"
+	tristate "CD-ROMs, DVD-ROMs"
 	depends on SCSI
 	---help---
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
-	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
-	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
-	  Y or M to "ISO 9660 CD-ROM file system support" later.
+	  Say Y if you want to use CD-ROMs or DVD-ROMs via SCSI or via drivers
+	  which use SCSI command sets (e.g. the Serial and Parallel ATA kernel
+	  subsystem, USB, and more). Also make sure to say Y or M to "ISO 9660
+	  CD-ROM file system support" later.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
@@ -164,7 +167,7 @@ config CHR_DEV_SG
 	  If unsure, say N.
 
 config CHR_DEV_SCH
-	tristate "SCSI media changer support"
+	tristate "SCSI media changers"
 	depends on SCSI
 	---help---
 	  This is a driver for SCSI media changers.  Most common devices are
Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#70 lore raw

Re: [PATCH] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 138 lines · Stefan Richter
Quoted 9 lines · Lennart Sorensen

Review

Quoted 5 lines · Stefan Richter
(quoted diff) +1 -1
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
+	  If you want to use a SCSI, SATA, USB or FireWire CD-ROM or DVD-ROM,
 	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
 	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
 	  Y or M to "ISO 9660 CD-ROM file system support" later.

How about that one for libata driven PATA CDROM drives? Could replace SATA with libata, or something similar.

From: Stefan Richter <[email protected]>
Subject: SCSI: update Kconfig help text to indicate SCSI core's widespread usage

---
 drivers/scsi/Kconfig |   67 ++++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 32 deletions(-)

Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================

drivers/scsi/Kconfig +34 -31
@@ -12,23 +12,31 @@ config SCSI
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
-	  If you want to use a SCSI hard disk, SCSI tape drive, SCSI CD-ROM or
-	  any other SCSI device under Linux, say Y and make sure that you know
-	  the name of your SCSI host adapter (the card inside your computer
-	  that "speaks" the SCSI protocol, also called SCSI controller),
-	  because you will be asked for it.
-
-	  You also need to say Y here if you have a device which speaks
-	  the SCSI protocol.  Examples of this include the parallel port
-	  version of the IOMEGA ZIP drive, USB storage devices, Fibre
-	  Channel, FireWire storage and the IDE-SCSI emulation driver.
+	  This option enables core support for SCSI protocols.
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    or iSCSI,
+	  - for non-SCSI hardware which speaks SCSI protocols, such as USB
+	    storage devices or the parallel port version of Iomega Zip drive,
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, most notably all Serial ATA drivers, and Parallel ATA
+	    via the ATA configuration option.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called scsi_mod.
 
 	  However, do not compile this as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI device.
+	  (the one containing the directory /) is located on a SCSI device
+	  or on a device whose driver represents it as SCSI device, as
+	  indicated above.  Choose Y in this case, or set up an initrd.
+
+	  Subsequent options in this menu enable specific SCSI command set
+	  support for harddisks, CD/DVD-ROM/R/W, tapes etc..  This menu also
+	  presents options for specific SCSI controllers, while options for
+	  some other SCSI transports and all non-SCSI controllers are located
+	  in other menus (SATA, USB, FireWire etc.).
 
 config SCSI_DMA
 	bool
@@ -57,32 +65,27 @@ config SCSI_PROC_FS
 
 	  If unsure say Y.
 
-comment "SCSI support type (disk, tape, CD-ROM)"
+comment "SCSI command set drivers (disk, tape, CD-ROM)"
 	depends on SCSI
 
 config BLK_DEV_SD
-	tristate "SCSI disk support"
+	tristate "Harddisks and other Direct access devices"
 	depends on SCSI
 	---help---
-	  If you want to use SCSI hard disks, Fibre Channel disks,
-	  Serial ATA (SATA) or Parallel ATA (PATA) hard disks,
-	  USB storage or the SCSI or parallel port version of
-	  the IOMEGA ZIP drive, say Y and read the SCSI-HOWTO,
-	  the Disk-HOWTO and the Multi-Disk-HOWTO, available from
-	  <http://www.tldp.org/docs.html#howto>. This is NOT for SCSI
-	  CD-ROMs.
+	  Say Y if you want to use harddisks and similar block-oriented devices
+	  via SCSI or via drivers which use SCSI command sets (e.g. the Serial
+	  and Parallel ATA kernel subsystem, USB, and more).
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called sd_mod.
 
-	  Do not compile this driver as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI disk.
-	  In this case, do not compile the driver for your SCSI host adapter
-	  (below) as a module either.
+	  If your root file system (the one containing the directory /) is
+	  located on a disk which accessed via this driver, choose Y instead of
+	  M or set up a suitable initrd.
 
 config CHR_DEV_ST
-	tristate "SCSI tape support"
+	tristate "Tape drives"
 	depends on SCSI
 	---help---
 	  If you want to use a SCSI tape drive under Linux, say Y and read the
@@ -95,7 +98,7 @@ config CHR_DEV_ST
 	  <file:Documentation/scsi/scsi.txt>. The module will be called st.
 
 config CHR_DEV_OSST
-	tristate "SCSI OnStream SC-x0 tape support"
+	tristate "SCSI OnStream SC-x0 tape drives"
 	depends on SCSI
 	---help---
 	  The OnStream SC-x0 SCSI tape drives cannot be driven by the
@@ -117,13 +120,13 @@ config CHR_DEV_OSST
 	  <file:Documentation/scsi/scsi.txt>. The module will be called osst.
 
 config BLK_DEV_SR
-	tristate "SCSI CDROM support"
+	tristate "CD-ROMs, DVD-ROMs"
 	depends on SCSI
 	---help---
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
-	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
-	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
-	  Y or M to "ISO 9660 CD-ROM file system support" later.
+	  Say Y if you want to use CD-ROMs or DVD-ROMs via SCSI or via drivers
+	  which use SCSI command sets (e.g. the Serial and Parallel ATA kernel
+	  subsystem, USB, and more). Also make sure to say Y or M to "ISO 9660
+	  CD-ROM file system support" later.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.

drivers/scsi/Kconfig config CHR_DEV_SG · line 173

Quoted 8 lines
drivers/scsi/Kconfig +1 -1
@@ -164,7 +167,7 @@ config CHR_DEV_SG
 	  If unsure, say N.
 
 config CHR_DEV_SCH
-	tristate "SCSI media changer support"
+	tristate "SCSI media changers"
 	depends on SCSI
 	---help---
 	  This is a driver for SCSI media changers.  Most common devices are

Looks great. I like it.

--
Len Sorensen

#71 lore raw

PATCH 1/1 SCSI: update Kconfig help text to indicate SCSI core's widespread usage

In reply to Stefan Richter

---

And one more update:
There is SAS too, and I forgot 'is' in "on a disk which __ accessed via".

 drivers/scsi/Kconfig |   67 ++++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 32 deletions(-)
drivers/scsi/Kconfig +35 -32
Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================
@@ -12,23 +12,31 @@ config SCSI
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
-	  If you want to use a SCSI hard disk, SCSI tape drive, SCSI CD-ROM or
-	  any other SCSI device under Linux, say Y and make sure that you know
-	  the name of your SCSI host adapter (the card inside your computer
-	  that "speaks" the SCSI protocol, also called SCSI controller),
-	  because you will be asked for it.
-
-	  You also need to say Y here if you have a device which speaks
-	  the SCSI protocol.  Examples of this include the parallel port
-	  version of the IOMEGA ZIP drive, USB storage devices, Fibre
-	  Channel, FireWire storage and the IDE-SCSI emulation driver.
+	  This option enables core support for SCSI protocols.
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    SAS, or iSCSI,
+	  - for non-SCSI hardware which speaks SCSI protocols, such as USB
+	    storage devices or the parallel port version of Iomega Zip drive,
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, most notably all Serial ATA drivers, and Parallel ATA
+	    via the ATA configuration option.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called scsi_mod.
 
 	  However, do not compile this as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI device.
+	  (the one containing the directory /) is located on a SCSI device
+	  or on a device whose driver represents it as SCSI device, as
+	  indicated above.  Choose Y in this case, or set up an initrd.
+
+	  Subsequent options in this menu enable specific SCSI command set
+	  support for harddisks, CD/DVD-ROM/R/W, tapes etc..  This menu also
+	  presents options for specific SCSI controllers, while options for
+	  some other SCSI transports and all non-SCSI controllers are located
+	  in other menus (SATA, USB, FireWire etc.).
 
 config SCSI_DMA
 	bool
@@ -57,32 +65,27 @@ config SCSI_PROC_FS
 
 	  If unsure say Y.
 
-comment "SCSI support type (disk, tape, CD-ROM)"
+comment "SCSI command set drivers (disk, tape, CD-ROM)"
 	depends on SCSI
 
 config BLK_DEV_SD
-	tristate "SCSI disk support"
+	tristate "Harddisks and other Direct access devices"
 	depends on SCSI
 	---help---
-	  If you want to use SCSI hard disks, Fibre Channel disks,
-	  Serial ATA (SATA) or Parallel ATA (PATA) hard disks,
-	  USB storage or the SCSI or parallel port version of
-	  the IOMEGA ZIP drive, say Y and read the SCSI-HOWTO,
-	  the Disk-HOWTO and the Multi-Disk-HOWTO, available from
-	  <http://www.tldp.org/docs.html#howto>. This is NOT for SCSI
-	  CD-ROMs.
+	  Say Y if you want to use harddisks and similar block-oriented devices
+	  via SCSI or via drivers which use SCSI command sets (e.g. the Serial
+	  and Parallel ATA kernel subsystem, USB, and more).
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called sd_mod.
 
-	  Do not compile this driver as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI disk.
-	  In this case, do not compile the driver for your SCSI host adapter
-	  (below) as a module either.
+	  If your root file system (the one containing the directory /) is
+	  located on a disk which is accessed via this driver, choose Y rather
+	  than M or set up a suitable initrd.
 
 config CHR_DEV_ST
-	tristate "SCSI tape support"
+	tristate "Tape drives"
 	depends on SCSI
 	---help---
 	  If you want to use a SCSI tape drive under Linux, say Y and read the
@@ -95,7 +98,7 @@ config CHR_DEV_ST
 	  <file:Documentation/scsi/scsi.txt>. The module will be called st.
 
 config CHR_DEV_OSST
-	tristate "SCSI OnStream SC-x0 tape support"
+	tristate "SCSI OnStream SC-x0 tape drives"
 	depends on SCSI
 	---help---
 	  The OnStream SC-x0 SCSI tape drives cannot be driven by the
@@ -117,13 +120,13 @@ config CHR_DEV_OSST
 	  <file:Documentation/scsi/scsi.txt>. The module will be called osst.
 
 config BLK_DEV_SR
-	tristate "SCSI CDROM support"
+	tristate "CD-ROMs, DVD-ROMs"
 	depends on SCSI
 	---help---
-	  If you want to use a SCSI or FireWire CD-ROM under Linux,
-	  say Y and read the SCSI-HOWTO and the CDROM-HOWTO at
-	  <http://www.tldp.org/docs.html#howto>. Also make sure to say
-	  Y or M to "ISO 9660 CD-ROM file system support" later.
+	  Say Y if you want to use CD-ROMs or DVD-ROMs via SCSI or via drivers
+	  which use SCSI command sets (e.g. the Serial and Parallel ATA kernel
+	  subsystem, USB, and more). Also make sure to say Y or M to "ISO 9660
+	  CD-ROM file system support" later.
 
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
@@ -164,7 +167,7 @@ config CHR_DEV_SG
 	  If unsure, say N.
 
 config CHR_DEV_SCH
-	tristate "SCSI media changer support"
+	tristate "SCSI media changers"
 	depends on SCSI
 	---help---
 	  This is a driver for SCSI media changers.  Most common devices are
Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#72 lore raw

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 22 lines · On Fri, 14 Sep 2007 23:14:21 +0200 (CEST) Stefan Richter…

---

And one more update:
There is SAS too, and I forgot 'is' in "on a disk which __ accessed via".

 drivers/scsi/Kconfig |   67 ++++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 32 deletions(-)

Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================

drivers/scsi/Kconfig +0 -5
@@ -12,23 +12,31 @@ config SCSI
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
-	  If you want to use a SCSI hard disk, SCSI tape drive, SCSI CD-ROM or
-	  any other SCSI device under Linux, say Y and make sure that you know
-	  the name of your SCSI host adapter (the card inside your computer
-	  that "speaks" the SCSI protocol, also called SCSI controller),
-	  because you will be asked for it.

drivers/scsi/Kconfig config SCSI · line 19

Quoted 10 lines
drivers/scsi/Kconfig +5 -5
-
-	  You also need to say Y here if you have a device which speaks
-	  the SCSI protocol.  Examples of this include the parallel port
-	  version of the IOMEGA ZIP drive, USB storage devices, Fibre
-	  Channel, FireWire storage and the IDE-SCSI emulation driver.
+	  This option enables core support for SCSI protocols.
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    SAS, or iSCSI,

There is SRP too.

#73 lore raw

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 2 lines · FUJITA Tomonori

On Fri, 14 Sep 2007 23:14:21 +0200 (CEST)
Stefan Richter <[email protected]> wrote:

...

Quoted 2 lines
Quoted 2 lines

And one more update:
There is SAS too,

...

Quoted 6 lines

drivers/scsi/Kconfig config SCSI · line 19

Quoted 4 lines
drivers/scsi/Kconfig +4 -0
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    SAS, or iSCSI,

There is SRP too.

I think I'll rewrite it as "for newer SCSI transports such as FireWire storage." ;-)

If SRP was in, can 'such as' be omitted? "for newer SCSI transports (Fibre Channel, FireWire storage, iSCSI, SAS, SRP)," Or would be "for newer SCSI transports such as Fibre Channel, FireWire storage, iSCSI, SAS, and more," be OK?

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#74 lore raw

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 14 lines · On Sat, 15 Sep 2007 08:16:03 +0200 Stefan Richter <[email protected]>…
Quoted 2 lines · FUJITA Tomonori

On Fri, 14 Sep 2007 23:14:21 +0200 (CEST)
Stefan Richter <[email protected]> wrote:

...

Quoted 2 lines
Quoted 2 lines

And one more update:
There is SAS too,

...

Quoted 6 lines

drivers/scsi/Kconfig config SCSI · line 19

Quoted 4 lines
drivers/scsi/Kconfig +4 -0
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    SAS, or iSCSI,

There is SRP too.

Quoted 5 lines

I think I'll rewrite it as "for newer SCSI transports such as FireWire storage." ;-)

If SRP was in, can 'such as' be omitted? "for newer SCSI transports (Fibre Channel, FireWire storage, iSCSI, SAS, SRP),"

It might be necessary to add SSA too.

Quoted 2 lines

Or would be "for newer SCSI transports such as Fibre Channel, FireWire storage, iSCSI, SAS, and more," be OK?

scsi-ml has SPI, FC, iSCSI, SAS, and SRP transport classes (SRP is in scsi-misc now). It's a bit strange to omit only SRP, I think. But I might be too SRP-biased.

#75 lore raw

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 8 lines · FUJITA Tomonori
Quoted 2 lines · On Sat, 15 Sep 2007 08:16:03 +0200 Stefan Richter <[email protected]>…

Or would be "for newer SCSI transports such as Fibre Channel, FireWire storage, iSCSI, SAS, and more," be OK?

scsi-ml has SPI, FC, iSCSI, SAS, and SRP transport classes (SRP is in scsi-misc now). It's a bit strange to omit only SRP, I think. But I might be too SRP-biased.

"such as... and more" suggests that there are indeed more SCSI transports supported by Linux than mentioned in this help text.

We could also write "such as Fibre Channel, iSCSI, SAS, and more," if you suspect bias on my side. ;-) Help texts should be concise.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#76 lore raw

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 6 lines · On Sat, 15 Sep 2007 14:30:10 +0200 Stefan Richter <[email protected]>…
Quoted 5 lines · FUJITA Tomonori
Quoted 2 lines · On Sat, 15 Sep 2007 08:16:03 +0200 Stefan Richter <[email protected]>…

Or would be "for newer SCSI transports such as Fibre Channel, FireWire storage, iSCSI, SAS, and more," be OK?

Quoted 6 lines
Quoted 3 lines

scsi-ml has SPI, FC, iSCSI, SAS, and SRP transport classes (SRP is in scsi-misc now). It's a bit strange to omit only SRP, I think. But I might be too SRP-biased.

"such as... and more" suggests that there are indeed more SCSI transports supported by Linux than mentioned in this help text.

I think that you can remove "such as" if you add SRP and SSA. "for SCSI transports such as Fibre Channel, FireWire, SAS, iSCSI, SRP, or SSA" should be fine. But I'm not sure that scsi-ml has a SSA hba driver. If not, we could remove SSA.

Quoted 6 lines

We could also write "such as Fibre Channel, iSCSI, SAS, and more," if you suspect bias on my side. ;-) Help texts should be concise.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#77 lore raw

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

In reply to Stefan Richter
Quoted 24 lines · Stefan Richter

---

And one more update:
There is SAS too, and I forgot 'is' in "on a disk which __ accessed via".

 drivers/scsi/Kconfig |   67 ++++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 32 deletions(-)

Index: linux-2.6.23-rc6/drivers/scsi/Kconfig
===================================================================

drivers/scsi/Kconfig +0 -7
@@ -12,23 +12,31 @@ config SCSI
 	depends on BLOCK
 	select SCSI_DMA if HAS_DMA
 	---help---
-	  If you want to use a SCSI hard disk, SCSI tape drive, SCSI CD-ROM or
-	  any other SCSI device under Linux, say Y and make sure that you know
-	  the name of your SCSI host adapter (the card inside your computer
-	  that "speaks" the SCSI protocol, also called SCSI controller),
-	  because you will be asked for it.
-
-	  You also need to say Y here if you have a device which speaks

drivers/scsi/Kconfig config SCSI · line 21

Quoted 10 lines
drivers/scsi/Kconfig +7 -3
-	  the SCSI protocol.  Examples of this include the parallel port
-	  version of the IOMEGA ZIP drive, USB storage devices, Fibre
-	  Channel, FireWire storage and the IDE-SCSI emulation driver.
+	  This option enables core support for SCSI protocols.
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    SAS, or iSCSI,
+	  - for non-SCSI hardware which speaks SCSI protocols, such as USB
+	    storage devices or the parallel port version of Iomega Zip drive,

but not for CONFIG_BLK_DEV_UB

drivers/scsi/Kconfig config SCSI · line 24

Quoted 3 lines
drivers/scsi/Kconfig +3 -0
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, most notably all Serial ATA drivers, and Parallel ATA
+	    via the ATA configuration option.

but not for CONFIG_BLK_DEV_IDE_SATA

Quoted 6 lines
drivers/scsi/Kconfig +0 -1
 	  To compile this driver as a module, choose M here and read
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called scsi_mod.
 
 	  However, do not compile this as a module if your root file system
-	  (the one containing the directory /) is located on a SCSI device.

drivers/scsi/Kconfig config SCSI · line 39

Quoted 10 lines
drivers/scsi/Kconfig +9 -0
+	  (the one containing the directory /) is located on a SCSI device
+	  or on a device whose driver represents it as SCSI device, as
+	  indicated above.  Choose Y in this case, or set up an initrd.
+
+	  Subsequent options in this menu enable specific SCSI command set
+	  support for harddisks, CD/DVD-ROM/R/W, tapes etc..  This menu also
+	  presents options for specific SCSI controllers, while options for
+	  some other SCSI transports and all non-SCSI controllers are located
+	  in other menus (SATA, USB, FireWire etc.).
...

You expect all kconfig users to read and completely understand this?

Although it's no longer required that the user sees the CONFIG_SCSI option at all since we can determine automaically when it's required and when not?

Quoted 1 line

Stefan Richter

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#78 lore raw

Re: [PATCH update] SCSI: update Kconfig help text to indicate SCSI core's widespread usage

Quoted 12 lines · Adrian Bunk

drivers/scsi/Kconfig config SCSI · line 21

Quoted 6 lines · Stefan Richter
drivers/scsi/Kconfig +6 -0
+	  You need it
+	  - for classic parallel SCSI hardware,
+	  - for newer SCSI transports such as Fibre Channel, FireWire storage,
+	    SAS, or iSCSI,
+	  - for non-SCSI hardware which speaks SCSI protocols, such as USB
+	    storage devices or the parallel port version of Iomega Zip drive,

but not for CONFIG_BLK_DEV_UB

Quoted 6 lines

drivers/scsi/Kconfig config SCSI · line 24

Quoted 3 lines
drivers/scsi/Kconfig +3 -0
+	  - for non-SCSI hardware whose drivers translate from and to SCSI
+	    protocols, most notably all Serial ATA drivers, and Parallel ATA
+	    via the ATA configuration option.

but not for CONFIG_BLK_DEV_IDE_SATA

Well, one could add a

You don't need it
- for x,
- for y.

bullet list.

...

Quoted 1 line

You expect all kconfig users to read and completely understand this?

I occasionally write documentation without the expectation that every potential user will read and understand it.

Quoted 3 lines

Although it's no longer required that the user sees the CONFIG_SCSI option at all since we can determine automaically when it's required and when not?

Maybe you can hide CONFIG_SCSI, but you still need to provide the above information --- then under the sd, sr, st, sg options, which may actually be the better places although it increases redundancy.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#79 lore raw
In reply to Stefan Richter
Quoted 18 lines · Stefan Richter
Quoted 9 lines · Adrian Bunk
Quoted 3 lines · Stefan Richter

The patch which is discussed here is specifically targeted towards users who are convinced that they can migrate to different drivers without reading Kconfig help texts.

Nothing about the patch is only about migration.

The same applies if you configure a kernel from scratch.

Quoted 7 lines

Do "make menuconfig" with the .config you are normally using, count the number of options that are visible, and ask yourself whether we can really expect users to read the help texts for every single option shown.

People mostly read help texts for options where they don't understand what this option is about - and "Serial ATA" therefore is an option that is likely to get enabled without the user looking at the help text.

Quoted 8 lines

If you create .config from scratch, then you can get away without reading help texts if you have a target with minimal hardware and protocols requirements and you know all the subsystems involved.

In all other cases, you theoretically need to read all help texts (minus the ones that don't appear because you deselect entire subsystems). In practice, this takes too much time, hence you take an existing .config (yours or somebody else's) and go from there.

Kconfig let's you start with the defconfig when doing "make menuconfig" without any .config present, so in practice users start from the defconfig and then go through all menus at once enabling and disabling options to adapt the configurations to their needs.

Or they start from the "includes everything" .config of their distribution and remove everything they don't need.

Quoted 2 lines

Whenever one enables an option for the first time, it would IMO be foolish to ignore its help text.

Then the number of non-foolish users is quite near to 0...

If you expect people to read several hundreds or thousands of help texts only for configuring a kernel then you are expecting something that is simply not realistic.

It is intuitive for a user to enable the "Serial ATA" menu and he might not expect to have to read the help text when he has SATA drivers, while having to enable anything in the "SCSI device support" menu is highly unintuitively when the user does not have SCSI hardware.

Quoted 1 line

Stefan Richter

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#80 lore raw
Quoted 7 lines · Adrian Bunk
Quoted 3 lines · Stefan Richter

In
practice, this takes too much time, hence you take an existing .config (yours or somebody else's) and go from there.

Kconfig let's you start with the defconfig when doing "make menuconfig" without any .config present,

[...]

This is one of those "somebody else's .config".

Quoted 4 lines
Quoted 2 lines

Whenever one enables an option for the first time, it would IMO be foolish to ignore its help text.

Then the number of non-foolish users is quite near to 0...

Perhaps. Although I meant only options which one enables oneself, not options which are taken over from somebody else's .config.

Quoted 8 lines

If you expect people to read several hundreds or thousands of help texts only for configuring a kernel then you are expecting something that is simply not realistic.

It is intuitive for a user to enable the "Serial ATA" menu and he might not expect to have to read the help text when he has SATA drivers, while having to enable anything in the "SCSI device support" menu is highly unintuitively when the user does not have SCSI hardware.

It surely is unintuitive, and it is one of the worse cases where the current menu layout is unintuitive. We have to improve that, even though it is ultimately impossible to serve everyone's needs equally well or, generally, make kernel configuration a piece of cake.

Note though, some suggestions which came up here don't actually make the menus more intuitive. Notably the patch "Select BLK_DEV_SD for all SCSI/libata drivers" is counterintuitive in a different color: It follows the philosophy of "I know what's good for you and I act on your behalf behind your back --- trust me, it's for your best".

I too am guilty of proposing the usage of 'select'
(http://lkml.org/lkml/2007/9/8/9) but I suggested a variant which lets the user stay informed and in control (as far as this is possible with 'select' which always increases complexity, never reduces it).

But rather than adding multiple menu items which enable the same option, a reorganization of the menus which better reflect the role of SCSI core and SCSI highlevel might be more effective --- similar to "Networking" which is separate from "Network device support"
(http://lkml.org/lkml/2007/9/10/5, http://lkml.org/lkml/2007/9/10/115).

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -===-
http://arcgraph.de/sr/
#81 lore raw
In reply to Adrian Bunk

Hello,

Quoted 5 lines · On Fri, 14 Sep 2007 17:15:22 +0200 Adrian Bunk <[email protected]> wrote:
Quoted 4 lines · Stefan Richter
Quoted 3 lines · Adrian Bunk
Quoted 2 lines · Jeff Garzik

Let's step back a moment and consider the actual scale and impact of the problem at hand.

Quoted 8 lines

Do "make menuconfig" with the .config you are normally using, count the number of options that are visible, and ask yourself whether we can really expect users to read the help texts for every single option shown.

People mostly read help texts for options where they don't understand what this option is about - and "Serial ATA" therefore is an option that is likely to get enabled without the user looking at the help text.

As a "make menuconfig" user, let me say that I agree. Of course, I'm used to rebuild kernel, but sometimes, some options are not clear, and the help text is searched for. But, getting too much of "No help text available" usually results in people no more reading the help text.

What about splitting the screen to have the top half with the menu, and the bottom half with the help ?

Paul

Signature · 13 lines
Paul Rolland                                E-Mail : rol(at)witbe.net
Witbe.net SA                                Tel. +33 (0)1 47 67 77 77
Les Collines de l'Arche                     Fax. +33 (0)1 47 67 77 99
F-92057 Paris La Defense                    RIPE : PR12-RIPE

Please no HTML, I'm not a browser - Pas d'HTML, je ne suis pas un navigateur 
"Some people dream of success... while others wake up and work hard at it" 

"I worry about my child and the Internet all the time, even though she's too 
young to have logged on yet. Here's what I worry about. I worry that 10 or 15 
years from now, she will come to me and say 'Daddy, where were you when they 
took freedom of the press away from the Internet?'"
--Mike Godwin, Electronic Frontier Foundation 
#82 lore raw
Quoted 2 lines · Paul Rolland

getting too much of "No help text available" usually results in people no more reading the help text.

I assert that a Kconfig prompt (a visible Kconfig variable) _without_ help text is a bug.

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#83 lore raw

Hello Stefan,

Quoted 6 lines · On Sat, 15 Sep 2007 10:25:39 +0200 Stefan Richter <[email protected]>…
Quoted 2 lines · Paul Rolland

getting too much of "No help text available" usually results in people no more reading the help text.

I assert that a Kconfig prompt (a visible Kconfig variable) _without_ help text is a bug.

Here is an example from 2.6.34-rc6 :
.config - Linux Kernel v2.6.23-rc6 Configuration
------------------------------------------------------------------------------

 +------------------------- Provide RTC interrupt -------------------------+ 
 | There is no help available for this kernel option.                      |
 | Symbol: HPET_EMULATE_RTC [=y]                                           |
 | Prompt: Provide RTC interrupt                                           |
 |   Defined at arch/x86_64/Kconfig:471                                    |
 |   Depends on: HPET_TIMER && RTC=y                                       |
 |   Location:                                                             |
 |   -> Processor type and features |   

Regards,
Paul

#84 lore raw

x86_64 usability bug: Kconfig prompt without help text (was Re: sata & scsi suggestion for make menuconfig)

I take the liberty to modify the CC list.

Quoted 7 lines · Paul Rolland
Quoted 2 lines · Stefan Richter

I assert that a Kconfig prompt (a visible Kconfig variable) _without_ help text is a bug.

Here is an example from 2.6.34-rc6 :
.config - Linux Kernel v2.6.23-rc6 Configuration
------------------------------------------------------------------------------

Quoted 8 lines
 +------------------------- Provide RTC interrupt -------------------------+ 
 | There is no help available for this kernel option.                      |
 | Symbol: HPET_EMULATE_RTC [=y]                                           |
 | Prompt: Provide RTC interrupt                                           |
 |   Defined at arch/x86_64/Kconfig:471                                    |
 |   Depends on: HPET_TIMER && RTC=y                                       |
 |   Location:                                                             |
 |   -> Processor type and features |   

The same prompt existed in arch/i386/Kconfig without help text too but it was later made invisible and automatic by pre-2.6.13 patch "remove special HPET_EMULATE_RTC config option", commit c91096d85c95c6b7fe8d7065e2aa6825e0bdaca9: "We had a user whose apps weren't working correctly because his "rtc" wasn't working fully. For the sake of simplicity, it seems sensible to always enable HPET RTC emulation."

- So, which criteria influence whether HPET_EMULATE_RTC should be enabled on x86_64 or not?

- In case that there is no compelling reason to disable it if its dependencies are satisfied, shouldn't it rather be invisible and automatic like on i386?

Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#85 lore raw

Re: x86_64 usability bug: Kconfig prompt without help text (was Re: sata & scsi suggestion for make menuconfig)

Quoted 2 lines

- So, which criteria influence whether HPET_EMULATE_RTC should be enabled on x86_64 or not?

If there is one it needs to be a runtime switch anyways.

Quoted 4 lines

- In case that there is no compelling reason to disable it if its dependencies are satisfied, shouldn't it rather be invisible and automatic like on i386?

It should be automatic. Please send a patch.

-Andi

#86 lore raw

PATCH 1/1 x86_64: configure HPET_EMULATE_RTC automatically

I don't know exactly what this option does...
Andi says it should be automatic rather than exposed as a prompt.

---

arch/x86_64/Kconfig +2 -1
@@ -469,8 +469,9 @@ config HPET_TIMER
 	  <http://www.intel.com/hardwaredesign/hpetspec.htm>.
 
 config HPET_EMULATE_RTC
-	bool "Provide RTC interrupt"
+	bool
 	depends on HPET_TIMER && RTC=y
+	default y
 
 # Mark as embedded because too many people got it wrong.
 # The code disables itself when not needed.
Signature · 3 lines
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
#87 lore raw
In reply to Paul Rolland
Quoted 17 lines · Paul Rolland
Quoted 5 lines · On Fri, 14 Sep 2007 17:15:22 +0200 Adrian Bunk <[email protected]> wrote:
Quoted 4 lines · Stefan Richter
Quoted 3 lines · Adrian Bunk
Quoted 2 lines · Jeff Garzik

Let's step back a moment and consider the actual scale and impact of the problem at hand.

Quoted 8 lines

Do "make menuconfig" with the .config you are normally using, count the number of options that are visible, and ask yourself whether we can really expect users to read the help texts for every single option shown.

People mostly read help texts for options where they don't understand what this option is about - and "Serial ATA" therefore is an option that is likely to get enabled without the user looking at the help text.

Quoted 7 lines

As a "make menuconfig" user, let me say that I agree. Of course, I'm used to rebuild kernel, but sometimes, some options are not clear, and the help text is searched for. But, getting too much of "No help text available" usually results in people no more reading the help text.

What about splitting the screen to have the top half with the menu, and the bottom half with the help ?

I useually have more screen space available to the side then above and below the list of options.

David Lang