export man page updated.

PATCH In review Steve Dickson 2 participants 5 messages Sep 17, 2007 – Sep 18, 2007

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Steve Dickson

author

2007-09-17 15:50 UTC #0 lore raw

PATCH 1/1 export man page updated.

It was pointed that the exportfs man page talks about the wrong file. In 2.6 kernels the export information is now kept in /var/lib/nfs/etab not /var/lib/nfs/xtab.

This patch basically does a 's/xtab/etab' and is relative to the to the Fedora git tree

git://git.infradead.org/~steved/nfs-utils.fedora

steved.

commit 0647ed30739b9867a4657bd69467925c868640b3

Author: Steve Dickson <[email protected]>
Date:   Fri Sep 14 13:21:08 2007 -0400

Updated exportfs man to talk about /var/lib/nfs/etab instead of /var/lib/nfs/xtab

Signed-off-by Steve Dickson <[email protected]>

utils/exportfs/exportfs.man +11 ~~-11~~

index 2bd8e31..9cfe7b8 100644
@@ -22,14 +22,14 @@ The
 .B exportfs
 command is used to maintain the current table of exported file systems for
 NFS. This list is kept in a separate file named
-.BR /var/lib/nfs/xtab
+.BR /var/lib/nfs/etab
 which is read by
 .B mountd
 when a remote host requests access to mount a file tree, and parts of
 the list which are active are kept in the kernel's export table.
 .P
 Normally this 
-.B xtab
+.B etab
 file is initialized with the list of all file systems named in
 .B /etc/exports 
 by invoking

@@ -59,7 +59,7 @@ In the new mode,
 does not give any information to the kernel but only provides it to
 .B mountd
 through the
-.B /var/lib/nfs/xtab
+.B /var/lib/nfs/etab
 file.
 .B mountd
 will listen to requests from the kernel and will provide information

@@ -69,7 +69,7 @@ In the legacy mode,
 any export requests which identify a specific host (rather than a
 subnet or netgroup etc) are entered directly into the kernel's export
 table as well as being written to
-.BR /var/lib/nfs/xtab .
+.BR /var/lib/nfs/etab .
 Further, any mount points listed in
 .B /var/lib/nfs/rmtab
 which match a non host-specific export request will cause an

@@ -93,8 +93,8 @@ file, so that only default options and options given on the command
 line are used.
 .TP
 .B -r
-Reexport all directories. It synchronizes /var/lib/nfs/xtab
-with /etc/exports. It removes entries in /var/lib/nfs/xtab
+Reexport all directories. It synchronizes /var/lib/nfs/etab
+with /etc/exports. It removes entries in /var/lib/nfs/etab
 which are deleted from /etc/exports, and remove any entries from the
 kernel export table which are no longer valid.
 .TP

@@ -120,7 +120,7 @@ entries to the export table.  When using
 all directories in
 .B exports(5)
 are added to
-.B xtab
+.B etab
 and the resulting list is pushed into the kernel.
 .P
 The

@@ -152,7 +152,7 @@ directory.
 Modifications of the kernel export table used by
 .B nfsd(8)
 take place immediately after parsing the command line and updating the
-.B xtab
+.B etab
 file.
 .P
 The default export options are

@@ -163,14 +163,14 @@ The third synopsis shows how to unexported a currently exported directory.
 When using
 .BR "exportfs -ua" ,
 all entries listed in
-.B xtab
+.B etab
 are removed from the kernel export tables, and the file is cleared. This
 effectively shuts down all NFS activity.
 .P
 To remove individual export entries, one can specify a
 .I host:/path
 pair. This deletes the specified entry from
-.B xtab
+.B etab
 and removes the corresponding kernel entry (if any).
 .P
 .\" -------------------- Dumping the Export Table -----------------

@@ -186,7 +186,7 @@ option, the list of flags pertaining to each export are shown in addition.
 The following adds all directories listed in
 .B /etc/exports
 to
-.B /var/lib/nfs/xtab
+.B /var/lib/nfs/etab
 and pushes the resulting export entries into the kernel:
 .P
 .nf

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Chuck Lever

2007-09-17 16:46 UTC #1 lore raw

Quoted 8 lines · Steve Dickson

It was pointed that the exportfs man page talks about the wrong file. In 2.6 kernels the export information is now kept in /var/lib/nfs/etab not /var/lib/nfs/xtab.
This patch basically does a 's/xtab/etab' and is relative to the to the Fedora git tree
git://git.infradead.org/~steved/nfs-utils.fedora

Hrm, an attachment.

@@ -93,8 +93,8 @@ file, so that only default options and options given on the command
line are used.
.TP
.B -r
-Reexport all directories. It synchronizes /var/lib/nfs/xtab
-with /etc/exports. It removes entries in /var/lib/nfs/xtab
+Reexport all directories. It synchronizes /var/lib/nfs/etab
+with /etc/exports. It removes entries in /var/lib/nfs/etab
which are deleted from /etc/exports, and remove any entries from the kernel export table which are no longer valid.
.TP

In this hunk, why isn't the file name bold, like the others?

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Steve Dickson

author

2007-09-18 11:10 UTC #2 lore raw

Quoted 11 lines · Chuck Lever

Quoted 8 lines · Steve Dickson
It was pointed that the exportfs man page talks about the wrong file. In 2.6 kernels the export information is now kept in /var/lib/nfs/etab not /var/lib/nfs/xtab.
This patch basically does a 's/xtab/etab' and is relative to the to the Fedora git tree
git://git.infradead.org/~steved/nfs-utils.fedora
Hrm, an attachment.

hmm... are you not seeing the attachments inlined?

Quoted 14 lines

(quoted diff) +0 -0

@@ -93,8 +93,8 @@ file, so that only default options and options given

on the command
line are used.
.TP
.B -r

utils/exportfs/exportfs.man +2 -2

-Reexport all directories. It synchronizes /var/lib/nfs/xtab
-with /etc/exports. It removes entries in /var/lib/nfs/xtab
+Reexport all directories. It synchronizes /var/lib/nfs/etab
+with /etc/exports. It removes entries in /var/lib/nfs/etab
 which are deleted from /etc/exports, and remove any entries from the
 kernel export table which are no longer valid.
 .TP

Quoted 1 line

In this hunk, why isn't the file name bold, like the others?

Thats the way it was. If its a problem, I'll respin the patch...

steved.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Chuck Lever

2007-09-18 15:50 UTC #3 lore raw

Quoted 6 lines · Steve Dickson

Quoted 5 lines · Chuck Lever
Quoted 4 lines · Steve Dickson
It was pointed that the exportfs man page talks about the wrong file. In 2.6 kernels the export information is now kept in /var/lib/nfs/etab not /var/lib/nfs/xtab.

Quoted 7 lines

Quoted 6 lines
Quoted 4 lines
This patch basically does a 's/xtab/etab' and is relative to the to the Fedora git tree
git://git.infradead.org/~steved/nfs-utils.fedora
Hrm, an attachment.
hmm... are you not seeing the attachments inlined?

When I reply the attachment is discarded so I have to do a number of steps to quote your patch that wouldn't be necessary if you had inlined the patch. The point of inlining patches rather than attaching them is to allow others to quote the patch in their reply with no extra steps. And there are tools to import inlined patches -- not sure if they work for attachments.

It's a scalability thing when reviewers have to deal with dozens of patches a day.

Quoted 13 lines

(quoted diff) +0 -0

@@ -93,8 +93,8 @@ file, so that only default options and options given

on the command
line are used.
.TP
.B -r

utils/exportfs/exportfs.man +2 -2

-Reexport all directories. It synchronizes /var/lib/nfs/xtab
-with /etc/exports. It removes entries in /var/lib/nfs/xtab
+Reexport all directories. It synchronizes /var/lib/nfs/etab
+with /etc/exports. It removes entries in /var/lib/nfs/etab
 which are deleted from /etc/exports, and remove any entries from the
 kernel export table which are no longer valid.
 .TP

Quoted 2 lines

Quoted 1 line
In this hunk, why isn't the file name bold, like the others?
Thats the way it was. If its a problem, I'll respin the patch...

See http://www.faqs.org/docs/Linux-mini/Man-Page.html#Q8

"Filenames are always in italics."

I ask "why isn't this filename bold" because the other instances in this particular man page are also bold and not italicized... which is marginally incorrect, if not unconventional.

It's hard to say something like this is "a problem" since it is only a man page. But I like to leave things a little cleaner (more correct) than when I found them.

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Steve Dickson

author

2007-09-18 18:01 UTC #4 lore raw

Quoted 10 lines · Chuck Lever

When I reply the attachment is discarded so I have to do a number of steps to quote your patch that wouldn't be necessary if you had inlined the patch. The point of inlining patches rather than attaching them is to allow others to quote the patch in their reply with no extra steps. And there are tools to import inlined patches -- not sure if they work for attachments.
It's a scalability thing when reviewers have to deal with dozens of patches a day.

I agree.. Its just nobody mentioned they were having problems with the way I was sending out patch... but its dully noted.

Quoted 4 lines

It's hard to say something like this is "a problem" since it is only a man page. But I like to leave things a little cleaner (more correct) than when I found them.

True... Here is the updated patch:

commit 1cdab9665cf1a7bc2f9e51851f27eb5121b4be16

Author: Steve Dickson <[email protected]>
Date:   Tue Sep 18 13:53:25 2007 -0400

Updated exportfs man to talk about /var/lib/nfs/etab instead of /var/lib/nfs/xtab

Signed-off-by Steve Dickson <[email protected]>

utils/exportfs/exportfs.man +4 -4

index 2bd8e31..9ca4ba3 100644
@@ -22,14 +22,14 @@ The
  .B exportfs
  command is used to maintain the current table of exported file systems for
  NFS. This list is kept in a separate file named
-.BR /var/lib/nfs/xtab
+.BR /var/lib/nfs/etab
  which is read by
  .B mountd
  when a remote host requests access to mount a file tree, and parts of
  the list which are active are kept in the kernel's export table.
  .P
  Normally this
-.B xtab
+.B etab
  file is initialized with the list of all file systems named in
  .B /etc/exports
  by invoking

@@ -59,7 +59,7 @@ In the new mode,
  does not give any information to the kernel but only provides it to
  .B mountd
  through the
-.B /var/lib/nfs/xtab
+.B /var/lib/nfs/etab
  file.
  .B mountd
  will listen to requests from the kernel and will provide information

@@ -69,7 +69,7 @@ In the legacy mode,
  any export requests which identify a specific host (rather than a
  subnet or netgroup etc) are entered directly into the kernel's export
  table as well as being written to
-.BR /var/lib/nfs/xtab .
+.BR /var/lib/nfs/etab .
  Further, any mount points listed in
  .B /var/lib/nfs/rmtab
  which match a non host-specific export request will cause an

@@ -93,8 +93,10 @@ file, so that only default options and options given

on the command
line are used.
.TP
.B -r
-Reexport all directories. It synchronizes /var/lib/nfs/xtab -with /etc/exports. It removes entries in /var/lib/nfs/xtab +Reexport all directories. It synchronizes
+.B /var/lib/nfs/etab
+with /etc/exports. It removes entries in
+.B /var/lib/nfs/etab
which are deleted from /etc/exports, and remove any entries from the kernel export table which are no longer valid.
.TP
@@ -120,7 +122,7 @@ entries to the export table. When using
all directories in
.B exports(5)
are added to
-.B xtab
+.B etab
and the resulting list is pushed into the kernel.
.P
The
@@ -152,7 +154,7 @@ directory.
Modifications of the kernel export table used by
.B nfsd(8)
take place immediately after parsing the command line and updating the
-.B xtab
+.B etab
file.
.P
The default export options are
@@ -163,14 +165,14 @@ The third synopsis shows how to unexported a currently exported directory.
When using
.BR "exportfs -ua" ,
all entries listed in
-.B xtab
+.B etab
are removed from the kernel export tables, and the file is cleared. This effectively shuts down all NFS activity.
.P
To remove individual export entries, one can specify a
.I host:/path
pair. This deletes the specified entry from
-.B xtab
+.B etab
and removes the corresponding kernel entry (if any).
.P
.\" -------------------- Dumping the Export Table -----------------
@@ -186,7 +188,7 @@ option, the list of flags pertaining to each export are shown in addition.
The following adds all directories listed in
.B /etc/exports
to
-.B /var/lib/nfs/xtab
+.B /var/lib/nfs/etab
and pushes the resulting export entries into the kernel:
.P
.nf