Skip to contentSkip to conversation

ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one

PATCH In review Rene Herman 3 participants 5 messages Sep 18, 2007 Input drivers

lore
Share & tools
lore

Rene Herman

author
#0 lore raw

PATCH 1/1 ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one

Hi Nicolas.

Given that it's not checking for signals, I believe this one should be an uninterruptible sleep instead?

Signed-off-by Rene Herman <[email protected]>

Rene.

drivers/input/touchscreen/ucb1400_ts.c +1 -2
index f0cbcdb..670dd49 100644
@@ -130,8 +130,7 @@ static unsigned int ucb1400_adc_read(struct ucb1400 *ucb, u16 adc_channel)
 		if (val & UCB_ADC_DAT_VALID)
 			break;
 		/* yield to other processes */
-		set_current_state(TASK_INTERRUPTIBLE);
-		schedule_timeout(1);
+		schedule_timeout_uninterruptible(1);
 	}
 
 	return UCB_ADC_DAT_VALUE(val);
#1 lore raw
Quoted 4 lines · Rene Herman

Hi Nicolas.

Given that it's not checking for signals, I believe this one should be an uninterruptible sleep instead?

Probably.

Nicolas

author
#2 lore raw
Quoted 8 lines · Nicolas Pitre
Quoted 4 lines · Rene Herman

Hi Nicolas.

Given that it's not checking for signals, I believe this one should be an uninterruptible sleep instead?

Probably.

Thanks. Should I send it somewhere or will you or Dmitry grab it?

Rene.

#3 lore raw
Quoted 4 lines · Rene Herman
Quoted 2 lines · Nicolas Pitre

On Tue, 18 Sep 2007, Rene Herman wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Hi Nicolas.

Given that it's not checking for signals, I believe this one should be an uninterruptible sleep instead?

Probably.

Thanks. Should I send it somewhere or will you or Dmitry grab it?

Please send it to Dmitry with my ACK.

Nicolas

maintainer
#4 lore raw
Quoted 8 lines · Nicolas Pitre
Quoted 6 lines · Rene Herman
Quoted 4 lines · Nicolas Pitre
Quoted 2 lines · Rene Herman

Hi Nicolas.

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Given that it's not checking for signals, I believe this one should be an uninterruptible sleep instead?

Probably.

Thanks. Should I send it somewhere or will you or Dmitry grab it?

Please send it to Dmitry with my ACK.

I have it, thanks.

Next time please use my gmail or mail.ru account - [email protected] is dead.

Signature · 1 line
Dmitry