sched: fix to use invalid sched_class
PATCH 1/1 sched: fix to use invalid sched_class
Hi Ingo,
I found an issue about the scheduler.
If you need a test case, please let me know.
Here is a patch.
When using rt_mutex, a NULL pointer dereference is occurred at enqueue_task_rt. Here is a scenario;
1) there are two threads, the thread A is fair_sched_class and thread B is rt_sched_class.
2) Thread A is boosted up to rt_sched_class, because the thread A has a rt_mutex lock and the thread B is waiting the lock.
3) At this time, when thread A create a new thread C, the thread C has a rt_sched_class.
4) When doing wake_up_new_task() for the thread C, the priority of the thread C is out of the RT priority range, because the normal priority of thread A is not the RT priority. It makes data corruption by overflowing the rt_prio_array.
The new thread C should be fair_sched_class.
The new thread should be valid scheduler class before queuing. This patch fixes to set the suitable scheduler class.
---
kernel/sched.c +5 -0
@@ -1682,6 +1682,11 @@ void fastcall wake_up_new_task(struct task_struct *p, unsigned long clone_flags) p->prio =effective_prio (p); +if (rt_prio (p->prio)) + p->sched_class = &rt_sched_class; +else + p->sched_class = &fair_sched_class; +if (!p->sched_class->task_new || !sysctl_sched_child_runs_first || (clone_flags &CLONE_VM ) ||task_cpu (p) != this_cpu || !current->se.on_rq) {
Quoted 20 lines · Hiroshi Shimamoto
Hi Ingo,
I found an issue about the scheduler.
If you need a test case, please let me know.
Here is a patch.When using
rt_mutex, a NULL pointer dereference is occurred atenqueue_task_rt. Here is a scenario;
1) there are two threads, the thread A isfair_sched_classand thread B isrt_sched_class.
2) Thread A is boosted up tort_sched_class, because the thread A has art_mutexlock and the thread B is waiting the lock.
3) At this time, when thread A create a new thread C, the thread C has art_sched_class.
4) When doingwake_up_new_task()for the thread C, the priority of the thread C is out of the RT priority range, because the normal priority of thread A is not the RT priority. It makes data corruption by overflowing thert_prio_array.
The new thread C should befair_sched_class.
Quoted 2 lines
The new thread should be valid scheduler class before queuing. This patch fixes to set the suitable scheduler class.
Nice fix! It's a 2.6.23 must-have fix - i'll push it out into the scheduler tree. Thanks!
Ingo