Remove unused member from nsproxy

PATCH In review Pavel Emelyanov 3 participants 4 messages Sep 26, 2007

lore

Share & tools

lore

Pavel Emelyanov

author

2007-09-26 13:14 UTC #0 lore raw

PATCH 1/1 Remove unused member from nsproxy

The nslock spinlock is not used in the kernel at all. Remove it.

Signed-off-by Pavel Emelyanov <[email protected]>

---

include/linux/init_task.h +0 -1

index a3f2541..cae35b6 100644
@@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
 #define INIT_NSPROXY(nsproxy) {						\
 	.pid_ns		= &init_pid_ns,					\
 	.count		= ATOMIC_INIT(1),				\
-	.nslock		= __SPIN_LOCK_UNLOCKED(nsproxy.nslock),		\
 	.uts_ns		= &init_uts_ns,					\
 	.mnt_ns		= NULL,						\
 	INIT_NET_NS(net_ns)                                             \

include/linux/nsproxy.h +0 -1

index 4d564d8..0e66b57 100644
@@ -23,7 +23,6 @@ struct pid_namespace;
  */
 struct nsproxy {
 	atomic_t count;
-	spinlock_t nslock;
 	struct uts_namespace *uts_ns;
 	struct ipc_namespace *ipc_ns;
 	struct mnt_namespace *mnt_ns;

Serge E. Hallyn

Acked-by on v1 1/1

2007-09-26 13:28 UTC #1 lore raw

Quoted 4 lines · Pavel Emelyanov

The nslock spinlock is not used in the kernel at all. Remove it.
Signed-off-by Pavel Emelyanov <[email protected]>

Acked-by Serge Hallyn <[email protected]>

Quoted 26 lines

---

include/linux/init_task.h +0 -1

index a3f2541..cae35b6 100644
@@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
 #define INIT_NSPROXY(nsproxy) {						\
 	.pid_ns		= &init_pid_ns,					\
 	.count		= ATOMIC_INIT(1),				\
-	.nslock		= __SPIN_LOCK_UNLOCKED(nsproxy.nslock),		\
 	.uts_ns		= &init_uts_ns,					\
 	.mnt_ns		= NULL,						\
 	INIT_NET_NS(net_ns)                                             \

include/linux/nsproxy.h +0 -1

index 4d564d8..0e66b57 100644
@@ -23,7 +23,6 @@ struct pid_namespace;
  */
 struct nsproxy {
 	atomic_t count;
-	spinlock_t nslock;
 	struct uts_namespace *uts_ns;
 	struct ipc_namespace *ipc_ns;
 	struct mnt_namespace *mnt_ns;

Cedric Le Goater

2007-09-26 13:31 UTC #2 lore raw

In reply to Pavel Emelyanov

Quoted 1 line · Pavel Emelyanov

The nslock spinlock is not used in the kernel at all.

it's also useless now that you have put some RCU rules around it. right ?

Quoted 34 lines

Remove it.

Signed-off-by Pavel Emelyanov <[email protected]>

---

include/linux/init_task.h +0 -1

index a3f2541..cae35b6 100644
@@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
 #define INIT_NSPROXY(nsproxy) {						\
 	.pid_ns		= &init_pid_ns,					\
 	.count		= ATOMIC_INIT(1),				\
-	.nslock		= __SPIN_LOCK_UNLOCKED(nsproxy.nslock),		\
 	.uts_ns		= &init_uts_ns,					\
 	.mnt_ns		= NULL,						\
 	INIT_NET_NS(net_ns)                                             \

include/linux/nsproxy.h +0 -1

index 4d564d8..0e66b57 100644
@@ -23,7 +23,6 @@ struct pid_namespace;
  */
 struct nsproxy {
 	atomic_t count;
-	spinlock_t nslock;
 	struct uts_namespace *uts_ns;
 	struct ipc_namespace *ipc_ns;
 	struct mnt_namespace *mnt_ns;

_______________________________________________
Containers mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/containers

Pavel Emelyanov

author

2007-09-26 13:37 UTC #3 lore raw

Quoted 5 lines · Cedric Le Goater

Quoted 1 line · Pavel Emelyanov
The nslock spinlock is not used in the kernel at all.
it's also useless now that you have put some RCU rules around it. right ?

Exactly!

Quoted 43 lines

C.
Quoted 29 lines
Remove it.
Signed-off-by Pavel Emelyanov <[email protected]>
---
include/linux/init_task.h +0 -1
index a3f2541..cae35b6 100644
@@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy;
 #define INIT_NSPROXY(nsproxy) {						\
 	.pid_ns		= &init_pid_ns,					\
 	.count		= ATOMIC_INIT(1),				\
-	.nslock		= __SPIN_LOCK_UNLOCKED(nsproxy.nslock),		\
 	.uts_ns		= &init_uts_ns,					\
 	.mnt_ns		= NULL,						\
 	INIT_NET_NS(net_ns)                                             \
include/linux/nsproxy.h +0 -1
index 4d564d8..0e66b57 100644
@@ -23,7 +23,6 @@ struct pid_namespace;
  */
 struct nsproxy {
 	atomic_t count;
-	spinlock_t nslock;
 	struct uts_namespace *uts_ns;
 	struct ipc_namespace *ipc_ns;
 	struct mnt_namespace *mnt_ns;
Quoted 5 lines
_______________________________________________
Containers mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/containers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/