Skip to contentSkip to conversation

Remove duplicated declarations in procfs

PATCH RESEND In review Pierre Peiffer 2 participants 3 messages Sep 28, 2007 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 Remove duplicated declarations in procfs

From: Pierre Peiffer <[email protected]>

This is a trivial patch that removes some duplicated declarations of extern variables.

---

 fs/proc/internal.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
fs/proc/internal.h +0 -4
index b215c35..d812816 100644
@@ -50,10 +50,6 @@ extern const struct file_operations proc_maps_operations;
 extern const struct file_operations proc_numa_maps_operations;
 extern const struct file_operations proc_smaps_operations;
 
-extern const struct file_operations proc_maps_operations;
-extern const struct file_operations proc_numa_maps_operations;
-extern const struct file_operations proc_smaps_operations;
-
 
 void free_proc_entry(struct proc_dir_entry *de);
 
Signature · 1 line
Pierre
#1 lore raw
Quoted 16 lines · On Fri, 28 Sep 2007 09:27:56 +0200 Pierre Peiffer <[email protected]>…

From: Pierre Peiffer <[email protected]>

This is a trivial patch that removes some duplicated declarations of extern variables.

---

 fs/proc/internal.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
fs/proc/internal.h +0 -0
index b215c35..d812816 100644

fs/proc/internal.h extern const struct file_operations proc_maps_operations; · line 54

Quoted 9 lines
fs/proc/internal.h +0 -4
@@ -50,10 +50,6 @@ extern const struct file_operations proc_maps_operations;
 extern const struct file_operations proc_numa_maps_operations;
 extern const struct file_operations proc_smaps_operations;
 
-extern const struct file_operations proc_maps_operations;
-extern const struct file_operations proc_numa_maps_operations;
-extern const struct file_operations proc_smaps_operations;
-
 
 void free_proc_entry(struct proc_dir_entry *de);

yup, thanks, the maps2 patches in -mm already accidentally fixed this so I haven't bothered merging it as a standalone thing.

#2 lore raw
Quoted 4 lines · Andrew Morton

yup, thanks, the maps2 patches in -mm already accidentally fixed this so I haven't bothered merging it as a standalone thing.

Ok, good.

Thanks,

Signature · 1 line
Pierre