Skip to contentSkip to conversation

fpga: dfl: fme: Fix cpu hotplug code

RFC In review Kajol Jain 3 participants 5 messages Jun 28, 2021 – Jun 29, 2021

Subsystems (2)
lore
Share & tools
lore

Kajol Jain

author
#0 lore raw

RFC 1/1 fpga: dfl: fme: Fix cpu hotplug code

Commit 724142f8c42a ("fpga: dfl: fme: add performance reporting support") added performance reporting support for FPGA management engine via perf.

It also added cpu hotplug feature but it didn't add pmu migration call in cpu offline function. This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.

Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.

Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
---
 drivers/fpga/dfl-fme-perf.c | 4 ++++
 1 file changed, 4 insertions(+)

---
- This fix patch is not tested (as I don't have required environment). But issue mentioned in the commit msg can be re-created, by starting any fme_perf event and while its still running, offline current designated cpu pointed by cpumask file. Since current code didn't migrating pmu, perf gonna try getting counts from that offlined cpu and hence we will not get event data.
---

drivers/fpga/dfl-fme-perf.c +4 -0
index 4299145ef347..b9a54583e505 100644
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
 		return 0;
 
 	priv->cpu = target;
+
+	/* Migrate fme_perf pmu events to the new target cpu */
+	perf_pmu_migrate_context(&priv->pmu, cpu, target);
+
 	return 0;
 }
 
Signature · 1 line
2.31.1
maintainer Tested-by on v1 1/1
#1 lore raw

It's a good fix, you can drop the RFC in commit title. :)

The title could be more specific, like:

fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

So we know it is for performance reporting feature at first glance.

Quoted 3 lines · Kajol Jain

Commit 724142f8c42a ("fpga: dfl: fme: add performance reporting support") added performance reporting support for FPGA management engine via perf.

May drop this section, it is indicated in the Fixes tag.

Quoted 2 lines

It also added cpu hotplug feature but it didn't add

The performance reporting driver added cpu hotplug ...

Quoted 8 lines

pmu migration call in cpu offline function. This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.

Quoted 5 lines

Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.

Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")

Thanks,
Yilun

Quoted 29 lines
---
 drivers/fpga/dfl-fme-perf.c | 4 ++++
 1 file changed, 4 insertions(+)

---
- This fix patch is not tested (as I don't have required environment). But issue mentioned in the commit msg can be re-created, by starting any fme_perf event and while its still running, offline current designated cpu pointed by cpumask file. Since current code didn't migrating pmu, perf gonna try getting counts from that offlined cpu and hence we will not get event data.
---

drivers/fpga/dfl-fme-perf.c +4 -0
index 4299145ef347..b9a54583e505 100644
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
 		return 0;
 
 	priv->cpu = target;
+
+	/* Migrate fme_perf pmu events to the new target cpu */
+	perf_pmu_migrate_context(&priv->pmu, cpu, target);
+
 	return 0;
 }
 
Signature · 1 line
2.31.1
author
#2 lore raw
Quoted 8 lines · Xu Yilun

It's a good fix, you can drop the RFC in commit title. :)

The title could be more specific, like:

fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

So we know it is for performance reporting feature at first glance.

Quoted 8 lines
Quoted 3 lines · Kajol Jain

Commit 724142f8c42a ("fpga: dfl: fme: add performance reporting support") added performance reporting support for FPGA management engine via perf.

May drop this section, it is indicated in the Fixes tag.

Hi Yilun,
Thanks for testing the patch. I will make mentioned changes and send
new patch.

Thanks,
Kajol Jain

Quoted 53 lines
Quoted 2 lines

It also added cpu hotplug feature but it didn't add

The performance reporting driver added cpu hotplug ...

Quoted 8 lines

pmu migration call in cpu offline function. This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.

Quoted 5 lines

Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.

Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")

Thanks,
Yilun

Quoted 29 lines
---
 drivers/fpga/dfl-fme-perf.c | 4 ++++
 1 file changed, 4 insertions(+)

---
- This fix patch is not tested (as I don't have required environment). But issue mentioned in the commit msg can be re-created, by starting any fme_perf event and while its still running, offline current designated cpu pointed by cpumask file. Since current code didn't migrating pmu, perf gonna try getting counts from that offlined cpu and hence we will not get event data.
---

drivers/fpga/dfl-fme-perf.c +4 -0
index 4299145ef347..b9a54583e505 100644
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
 		return 0;
 
 	priv->cpu = target;
+
+	/* Migrate fme_perf pmu events to the new target cpu */
+	perf_pmu_migrate_context(&priv->pmu, cpu, target);
+
 	return 0;
 }
 
Signature · 1 line
2.31.1
maintainer
#3 lore raw
In reply to Kajol Jain
Quoted 13 lines · Kajol Jain

Commit 724142f8c42a ("fpga: dfl: fme: add performance reporting support") added performance reporting support for FPGA management engine via perf.

It also added cpu hotplug feature but it didn't add pmu migration call in cpu offline function. This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.

Quoted 5 lines

Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.

Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")

You might want to Cc: [email protected] if it fixes an actual bug.

Quoted 30 lines
---
 drivers/fpga/dfl-fme-perf.c | 4 ++++
 1 file changed, 4 insertions(+)

---
- This fix patch is not tested (as I don't have required environment). But issue mentioned in the commit msg can be re-created, by starting any fme_perf event and while its still running, offline current designated cpu pointed by cpumask file. Since current code didn't migrating pmu, perf gonna try getting counts from that offlined cpu and hence we will not get event data.
---

drivers/fpga/dfl-fme-perf.c +4 -0
index 4299145ef347..b9a54583e505 100644
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
 		return 0;
 
 	priv->cpu = target;
+
+	/* Migrate fme_perf pmu events to the new target cpu */
+	perf_pmu_migrate_context(&priv->pmu, cpu, target);
+
 	return 0;
 }
 
Signature · 1 line
2.31.1

- Moritz

author
#4 lore raw
Quoted 14 lines · Moritz Fischer
Quoted 13 lines · Kajol Jain

Commit 724142f8c42a ("fpga: dfl: fme: add performance reporting support") added performance reporting support for FPGA management engine via perf.

It also added cpu hotplug feature but it didn't add pmu migration call in cpu offline function. This can create an issue incase the current designated cpu being used to collect fme pmu data got offline, as based on current code we are not migrating fme pmu to new target cpu. Because of that perf will still try to fetch data from that offline cpu and hence we will not get counter data.

Quoted 7 lines
Quoted 5 lines

Patch fixed this issue by adding pmu_migrate_context call in fme_perf_offline_cpu function.

Fixes 724142f8c42a ("fpga: dfl: fme: add performance reporting support")

You might want to Cc: [email protected] if it fixes an actual bug.

Hi Moritz,
I already send patch out without RFC tag yesterday.
Link to the patch: https://lkml.org/lkml/2021/6/28/275

I will cc [email protected] there as suggested by you.

Thanks,
Kajol Jain

Quoted 32 lines
Quoted 30 lines
---
 drivers/fpga/dfl-fme-perf.c | 4 ++++
 1 file changed, 4 insertions(+)

---
- This fix patch is not tested (as I don't have required environment). But issue mentioned in the commit msg can be re-created, by starting any fme_perf event and while its still running, offline current designated cpu pointed by cpumask file. Since current code didn't migrating pmu, perf gonna try getting counts from that offlined cpu and hence we will not get event data.
---

drivers/fpga/dfl-fme-perf.c +4 -0
index 4299145ef347..b9a54583e505 100644
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
 		return 0;
 
 	priv->cpu = target;
+
+	/* Migrate fme_perf pmu events to the new target cpu */
+	perf_pmu_migrate_context(&priv->pmu, cpu, target);
+
 	return 0;
 }
 
Signature · 1 line
2.31.1

- Moritz