Skip to contentSkip to conversation

Resend [PATCH] qla1280: uses wrong failure path after failed pci_set_dma_mask

PATCH Johannes Dickgreber 1 participant 1 message Oct 3, 2007 SCSI

lore
Share & tools
lore

Johannes Dickgreber

author
#0 lore raw

Hi

Sorry, I got no answer, so i resend.

I think there will be a wrong goto target after a failed pci_set_dma_mask.

Please Check.

Signed-off-by Johannes Dickgreber [email protected]

---

qla1280.c renamed from qla1280.c.orig +2 -2
@@ -4298,7 +4298,7 @@ qla1280_probe_one(struct pci_dev *pdev, 
 			printk(KERN_WARNING "scsi(%li): Unable to set a "
 			       "suitable DMA mask - aborting\n", ha->host_no);
 			error = -ENODEV;
-			goto error_free_irq;
+			goto error_put_host;
 		}
 	} else
 		dprintk(2, "scsi(%li): 64 Bit PCI Addressing Enabled\n",

@@ -4308,7 +4308,7 @@ qla1280_probe_one(struct pci_dev *pdev, 
 		printk(KERN_WARNING "scsi(%li): Unable to set a "
 		       "suitable DMA mask - aborting\n", ha->host_no);
 		error = -ENODEV;
-		goto error_free_irq;
+		goto error_put_host;
 	}
 #endif

Thanks

tanzy