Skip to contentSkip to conversation

Resend [PATCH] qla1280: wasted space in allocated pages for request and response ring

PATCH Johannes Dickgreber 1 participant 1 message Oct 3, 2007 SCSI

lore
Share & tools
lore
#0 lore raw

Hi

Sorry I Got no answer, so i resend

i think there is wasted space in allocated pages for request and response rings.
The allocations are made with REQUEST_ENTRY_CNT + 1 and RESPONSE_ENTRY_CNT + 1, but they are set with 256 and 16.

So we got more pages, which we dont use very much.

Can you please check.

---

qla1280.h renamed from qla1280.h.orig +2 -2
@@ -91,8 +91,8 @@
 #define INVALID_HANDLE			(MAX_OUTSTANDING_COMMANDS + 2)
 
 /* ISP request and response entry counts (37-65535) */
-#define REQUEST_ENTRY_CNT		256 /* Number of request entries. */
-#define RESPONSE_ENTRY_CNT		16  /* Number of response entries. */
+#define REQUEST_ENTRY_CNT		255 /* Number of request entries. */
+#define RESPONSE_ENTRY_CNT		63  /* Number of response entries. */
 
 /*
  * SCSI Request Block structure  (sp)  that is placed

Thanks

tanzy