scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()
Subsystems (2)
PATCH 1/1 scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()
From: SeongJae Park <[email protected]>
Commit cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp with general hdw_queues per cpu") has introduced static checker warnings for potential null dereferences in 'lpfc_sli4_hba_unset()' and commit 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning in lpfc_sli4_hba_unset") has tried to fix it. However, yet another potential null dereference is remaining. This commit fixes it.
This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc.
--- drivers/scsi/lpfc/lpfc_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +2 -1
@@ -11878,7 +11878,8 @@ lpfc_sli4_hba_unset(struct lpfc_hba *phba)lpfc_sli4_xri_exchange_busy_wait (phba);/* per-phba callback de-registration for hotplug event */ -lpfc_cpuhp_remove (phba); +if (phba->pport) +lpfc_cpuhp_remove (phba);/* Disable PCI subsystem interrupt */ lpfc_sli4_disable_intr (phba);
Signature · 1 line
2.17.1
Quoted 24 lines · SeongJae Park
From: SeongJae Park <[email protected]>
Commit
cdb42becdd40("scsi: lpfc: Replaceio_channelsfor nvme and fcp with generalhdw_queuesper cpu") has introduced static checker warnings for potential null dereferences in 'lpfc_sli4_hba_unset()' and commit1ffdd2c0440d("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset") has tried to fix it. However, yet another potential null dereference is remaining. This commit fixes it.This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc.
Fixes 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset")Fixes cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp with general hdw_queues per cpu")Signed-off-by SeongJae Park <[email protected]>--- drivers/scsi/lpfc/lpfc_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/scsi/lpfc/lpfc_init.c +0
-0
drivers/scsi/lpfc/lpfc_init.c lpfc_sli4_hba_unset(struct lpfc_hba *phba) · line 11885
Quoted 9 lines
drivers/scsi/lpfc/lpfc_init.c +2
-1@@ -11878,7 +11878,8 @@ lpfc_sli4_hba_unset(struct lpfc_hba *phba)lpfc_sli4_xri_exchange_busy_wait (phba);/* per-phba callback de-registration for hotplug event */ -lpfc_cpuhp_remove (phba); +if (phba->pport) +lpfc_cpuhp_remove (phba);/* Disable PCI subsystem interrupt */ lpfc_sli4_disable_intr (phba);
-- james
Martin K. Petersen
AppliedQuoted 8 lines · SeongJae Park
Commit
cdb42becdd40("scsi: lpfc: Replaceio_channelsfor nvme and fcp with generalhdw_queuesper cpu") has introduced static checker warnings for potential null dereferences in 'lpfc_sli4_hba_unset()' and commit1ffdd2c0440d("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset") has tried to fix it. However, yet another potential null dereference is remaining. This commit fixes it.[...]
Applied to 5.8/scsi-fixes, thanks!
[1/1] scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()
https://git.kernel.org/mkp/scsi/c/46da547e21d6
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering