Skip to contentSkip to conversation

New driver for Broadcom 10Gb Ethernet, take two.

PATCH In review Eliezer Tamir 2 participants 3 messages Oct 7, 2007 – Oct 8, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover New driver for Broadcom 10Gb Ethernet, take two.

This is an initial version of the BNX2X, the Linux driver for the BCM5771X 10Gb Ethernet controller family.

Although the chip is very different from the 5706-8 family we based the driver code on the BNX2 driver.

Since the hardware is supposed to be generally available soon I have
posted an initial version and after hearing all the comments I am reposting with changes to address them.

Some planned feature are still under development, but we want to get whatever we have out now so people can start using the HW.

Main changes from first version.

* Fixed most issues raised by Michael Buesch. (Thanks Michael!)
* Some slow path bug fixes.
* Yitchak Gertner re-grouped the code in a more logical manner.
* A lot of work was done to get the generated code to comply with coding style requirements.

Known issues/TODO.
* Move slowpath event handling from tasklet to workqueue context. This will allow replacing the busy waits in the link management code with sleeps.

Please consider applying to 2.6.24

Thanks
Eliezer

#1 lore raw
Quoted 9 lines · Eliezer Tamir

This is an initial version of the BNX2X, the Linux driver for the BCM5771X 10Gb Ethernet controller family.
Although the chip is very different from the 5706-8 family we based the driver code on the BNX2 driver.
Since the hardware is supposed to be generally available soon I have posted an initial version and after hearing all the comments I am reposting with changes to address them.
Some planned feature are still under development, but we want to get whatever we have out now so people can start using the HW.

Your patch-posting procedure is yet in a bit problem state..

+{
+static const u32 EVST_TSEM_FAST_MEMORY_COMMON_MEMORY_INIT_EMULATION_7[] = { +0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
+0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
+0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,

It does look like your Thunderbird 2.0 did wrap long text lines when you included the texts into the posts.

The result is that currently your patches are not usable at all.

Your options:
- instead of including the patch in message body, use Attach
- use some other email program that does not scramble your texts

     (e.g. mutt + emacs)

- publish the patch file on network somewhere, and just tell URL to that one in email

Quoted 8 lines

Main changes from first version.

* Fixed most issues raised by Michael Buesch. (Thanks Michael!)
* Some slow path bug fixes.
* Yitchak Gertner re-grouped the code in a more logical manner.
* A lot of work was done to get the generated code to comply with coding style requirements.

Quoted 8 lines

Known issues/TODO.
* Move slowpath event handling from tasklet to workqueue context. This will allow replacing the busy waits in the link management code with sleeps.

Please consider applying to 2.6.24

Thanks
Eliezer

/Matti Aarnio -- one of <[email protected]>

#2 lore raw
Quoted 11 lines · Matti Aarnio

Your patch-posting procedure is yet in a bit problem state..

+{
+static const u32 EVST_TSEM_FAST_MEMORY_COMMON_MEMORY_INIT_EMULATION_7[] = { +0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
+0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
+0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,

Quoted 4 lines

It does look like your Thunderbird 2.0 did wrap long text lines when you included the texts into the posts.

Sorry about that, will fix and resubmit shortly.

Thanks
Eliezer