Skip to contentSkip to conversation

Patch for WindowsMobile5 on Linux Kernel

DISCUSSION NAK Grosjo.net - jom 5 participants 6 messages Oct 9, 2007

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

On Die, 2007-10-09 at 12:20 +0300, Grosjo.net - jom wrote:
[...]

Quoted 3 lines

Would it be possible to include the patches (available on www.synce.org) for WindowsMobile5, as most mobile phones are under Window$, and it is very convenient to connect it to the laptop under Linux

do {
Test them
review them
sent them as patches hereover
handle feedback
until(accepted)

Bernd

Signature · 3 lines
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services
#2 lore raw
Quoted 6 lines · Bernd Petrovitsch

On Die, 2007-10-09 at 12:20 +0300, Grosjo.net - jom wrote:
[...]

Quoted 3 lines

Would it be possible to include the patches (available on www.synce.org) for WindowsMobile5, as most mobile phones are under Window$, and it is very convenient to connect it to the laptop under Linux

Quoted 6 lines

do {
Test them
review them
sent them as patches hereover
handle feedback
until(accepted)

FWIW, the patch in question is a one-liner:

drivers/net/usb/rndis_host.c +1 -2
@@ -499,8 +499,7 @@
 	net->hard_header_len += sizeof (struct rndis_data_hdr);
 	dev->hard_mtu = net->mtu + net->hard_header_len;
 
-	dev->rx_urb_size = dev->hard_mtu + (dev->maxpacket + 1);
-	dev->rx_urb_size &= ~(dev->maxpacket - 1);
+	dev->rx_urb_size = (dev->udev->speed == USB_SPEED_FULL) ? 16384 : 8192;
 	u.init->max_transfer_size = cpu_to_le32(dev->rx_urb_size);
 
 	net->change_mtu = NULL;

Xav

#3 lore raw
Quoted 3 lines

FWIW, the patch in question is a one-liner:

Yes, that is why it shall be probably possible to include it in the kernel ?

I do not have the contact with SynCE developers. Maybe one of you have.

Jom

Nacked-By NAK
#4 lore raw
In reply to Xavier Bestel
Quoted 1 line · Xavier Bestel

FWIW, the patch in question is a one-liner:

That's not a valid argument. This may work with a WM5 device, but looks very dubious, wrt. other RNDIS devices. Why are these constants hardcoded and not taken in some way from the descriptors?

There must be some justification why these values need to be hardcoded, and if so, this must be dependent on the rndis device really being a WM5 device.

#5 lore raw
In reply to Grosjo.net - jom

Hi,

Quoted 3 lines · Grosjo.net - jom

Would it be possible to include the patches (available on www.synce.org) for WindowsMobile5, as most mobile phones are under Window$, and it is very convenient to connect it to the laptop under Linux

Sounds useful so please ask the synce developers to submit those patches upstream.

Pekka