Skip to contentSkip to conversation

Need to call kgdb8250_add_platform_port in omap_serial_init()?

PATCH Drew Moseley 2 participants 3 messages Oct 11, 2007 – Oct 12, 2007

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Drew Moseley

author
#0 lore raw

The patch below calls kgdb8250_add_platform_port() from omap_serial_init(). This is copied from mach-omap/serial.c. Without this patch kgdbwait will fail.

Comments?

Drew

arch/arm/mach-omap2/serial.c +3 -0
Index: linux/arch/arm/mach-omap2/serial.c
===================================================================
@@ -162,6 +162,9 @@ void __init omap_serial_init()
 		}
 
 		omap_serial_reset(p);
+#ifdef CONFIG_KGDB_8250
+		kgdb8250_add_platform_port(i, &serial_platform_data[i]);
+#endif
 	}
 }
Signature · 1 line
mailto:[email protected]
maintainer
#1 lore raw

Hi,

Quoted 6 lines · Drew Moseley

The patch below calls kgdb8250_add_platform_port() from omap_serial_init(). This is copied from mach-omap/serial.c. Without this patch kgdbwait will fail.

Comments?

Makes sense, but I can't find any references in linux-omap for kgdb8250_add_platform_port... I guess that's in some other tree?

Regards,

Tony

Quoted 21 lines

Index: linux/arch/arm/mach-omap2/serial.c
===================================================================

arch/arm/mach-omap2/serial.c +3 -0
@@ -162,6 +162,9 @@ void __init omap_serial_init()
 		}
 
 		omap_serial_reset(p);
+#ifdef CONFIG_KGDB_8250
+		kgdb8250_add_platform_port(i, &serial_platform_data[i]);
+#endif
 	}
 }
Signature · 6 lines
-- 
mailto:[email protected]
_______________________________________________
Linux-omap-open-source mailing list
[email protected]
http://linux.omap.com/mailman/listinfo/linux-omap-open-source
author
#2 lore raw
Quoted 7 lines · Tony Lindgren

Hi,

Quoted 4 lines · Drew Moseley

The patch below calls kgdb8250_add_platform_port() from omap_serial_init(). This is copied from mach-omap/serial.c. Without this patch kgdbwait will fail.

Quoted 9 lines
Quoted 1 line

Comments?

Makes sense, but I can't find any references in linux-omap for kgdb8250_add_platform_port... I guess that's in some other tree?

Regards,

Tony

Indeed. Sorry about that. Resubmitted to the kgdb bugreport list.

Drew