mmc: possible leak in mmc_read_ext_csd
PATCH 1/1 mmc: possible leak in mmc_read_ext_csd
The exception path associated with an invalid ext_csd_struct returns without freeing ext_csd.
Coverity CID 1909.
Signed-off-by Florin Malita
---
drivers/mmc/core/mmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/core/mmc.c +0 -0
@@ -213,7 +213,8 @@ static int mmc_read_ext_csd(struct mmc_card *card)
printk(KERN_ERR "%s: unrecognised EXT_CSD structure "
"version %d\n", mmc_hostname(card->host),
ext_csd_struct);
- return -EINVAL;
+ err = -EINVAL;
+ goto out;
}
if (ext_csd_struct >= 2) {Quoted 6 lines · On Sat, 13 Oct 2007 12:27:20 -0400 Florin Malita <[email protected]> wrote:
The exception path associated with an invalid
ext_csd_structreturns without freeingext_csd.Coverity CID 1909.
Signed-off-by Florin Malita
Quite right. Applied.
Rgds
Signature · 5 lines
-- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org