Correct vendor-prefix and document device isl29028

This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix found by checkpatch also documented for compatibility reasons.

Signed-off-by Darshana Padmadas <[email protected]>

This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix found by checkpatch also documented for compatibility reasons.

Signed-off-by Darshana Padmadas <[email protected]>

---
 Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
 1 file changed, 2 insertions(+)

Documentation/devicetree/bindings/i2c/trivial-devices.txt +2 -0

index 6af570e..d024613 100644
@@ -57,6 +57,8 @@ gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
 infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
 infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
 isl,isl12057		Intersil ISL12057 I2C RTC Chip
+isil,isl29028           Deprecated name, use isl,isl29028 instead
+isl,isl29028            Intersil ISL29028 Ambient Light and Proximity Sensor
 maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
 maxim,max1237		Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
 maxim,max6625		9-Bit/12-Bit Temperature Sensors with I??C-Compatible Serial Interface

Signature · 6 lines

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Quoted 4 lines · Darshana Padmadas

This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix found by checkpatch also documented for compatibility reasons.

Signed-off-by Darshana Padmadas <[email protected]>

Acked-by Mark Rutland <[email protected]>

Quoted 4 lines

---
 Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
 1 file changed, 2 insertions(+)

Documentation/devicetree/bindings/i2c/trivial-devices.txt gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In · line 60

Quoted 9 lines

Documentation/devicetree/bindings/i2c/trivial-devices.txt +1 -0

index 6af570e..d024613 100644
@@ -57,6 +57,8 @@ gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
 infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
 infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
 isl,isl12057		Intersil ISL12057 I2C RTC Chip
+isil,isl29028           Deprecated name, use isl,isl29028 instead

Quoted 12 lines

Documentation/devicetree/bindings/i2c/trivial-devices.txt +1 -0

+isl,isl29028            Intersil ISL29028 Ambient Light and Proximity Sensor
 maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
 maxim,max1237		Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
 maxim,max6625		9-Bit/12-Bit Temperature Sensors with I??C-Compatible Serial Interface

Signature · 6 lines

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels.

Signed-off-by Darshana Padmadas <[email protected]>

This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels.

Signed-off-by Darshana Padmadas <[email protected]>

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0

index ac7269f..e2503b8 100644
@@ -68,6 +68,7 @@ img	Imagination Technologies Ltd.
 intel	Intel Corporation
 intercontrol	Inter Control Group
 isee	ISEE 2007 S.L.
+isil 	Intersil (deprecated, use isl)
 isl	Intersil
 karo	Ka-Ro electronics GmbH
 keymile	Keymile GmbH

Signature · 6 lines

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

This patch adds the correct vendor-prefix for device isl29028 and maintains deprecated vendor-prefix found by checkpatch warning for older kernel releases.

Signed-off-by Darshana Padmadas <[email protected]>

This patch adds the correct vendor-prefix for device isl29028 and maintains deprecated vendor-prefix found by checkpatch warning for older kernel releases.

Signed-off-by Darshana Padmadas <[email protected]>

---
 drivers/staging/iio/light/isl29028.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/staging/iio/light/isl29028.c +2 -1

index 6014625..60b02a8 100644
@@ -537,7 +537,8 @@ static const struct i2c_device_id isl29028_id[] = {
 MODULE_DEVICE_TABLE(i2c, isl29028_id);
 
 static const struct of_device_id isl29028_of_match[] = {
-	{ .compatible = "isil,isl29028", },
+	{ .compatible = "isl,isl29028", },
+	{ .compatible = "isil,isl29028", }, /* deprecated, don't use */
 	{ },
 };
 MODULE_DEVICE_TABLE(of, isl29028_of_match);

Signature · 6 lines

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

arch/arm/boot/dts/tegra30-cardhu.dtsi line 193

Quoted 8 lines · On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:

                /* ALS and Proximity sensor */
                isl29028 at 44 {

arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -1

-                       compatible = "isil,isl29028";
+                       compatible = "isl,isl29028";
                        reg = <0x44>;
                        interrupt-parent = <&gpio>;
                        interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;

Does this intentionally list only the new string?

If we want compatibility between new dts files and old kernels, this would need to be

	compatible = "isl,isl29028", compatible = "isil,isl29028";

Quoted 10 lines · Arnd Bergmann

arch/arm/boot/dts/tegra30-cardhu.dtsi line 193

Quoted 8 lines · On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:

                /* ALS and Proximity sensor */
                isl29028 at 44 {

arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -1

-                       compatible = "isil,isl29028";
+                       compatible = "isl,isl29028";
                        reg = <0x44>;
                        interrupt-parent = <&gpio>;
                        interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;

Quoted 6 lines

Does this intentionally list only the new string?

If we want compatibility between new dts files and old kernels, this would need to be

      compatible = "isl,isl29028", compatible = "isil,isl29028";

Are we aiming for new dts wto work with old kernels? It's nice if they do, but I don't think it should be necessary. Old DTBs should definitely work with a new kernel, though.

Personally I'd rather see one string (preferably the canonical one, but the deprecated one is ok) than two strings when those strings are for the exact same device.

Quoted 22 lines · On Tuesday 07 October 2014 13:08:12 Mark Rutland wrote:

Quoted 10 lines · Arnd Bergmann

arch/arm/boot/dts/tegra30-cardhu.dtsi line 193

Quoted 8 lines · On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:

                /* ALS and Proximity sensor */
                isl29028 at 44 {

arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -1

-                       compatible = "isil,isl29028";
+                       compatible = "isl,isl29028";
                        reg = <0x44>;
                        interrupt-parent = <&gpio>;
                        interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;

Quoted 6 lines

Does this intentionally list only the new string?

If we want compatibility between new dts files and old kernels, this would need to be

      compatible = "isl,isl29028", compatible = "isil,isl29028";

Are we aiming for new dts wto work with old kernels? It's nice if they do, but I don't think it should be necessary. Old DTBs should definitely work with a new kernel, though.

Quoted 4 lines

Personally I'd rather see one string (preferably the canonical one, but the deprecated one is ok) than two strings when those strings are for the exact same device.

Ok, fair enough. I think we should have the new name in dts files normally then, in order to avoid spreading the mistake further when someone copies it.

Quoted 10 lines · Arnd Bergmann

Quoted 9 lines · On Tuesday 07 October 2014 13:08:12 Mark Rutland wrote:

Quoted 8 lines · Arnd Bergmann

arch/arm/boot/dts/tegra30-cardhu.dtsi

Quoted 7 lines · On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:

                /* ALS and Proximity sensor */
                isl29028@44 {

arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -1

-                       compatible = "isil,isl29028";
+                       compatible = "isl,isl29028";
                        reg = <0x44>;
                        interrupt-parent = <&gpio>;
                        interrupts = <TEGRA_GPIO(L, 0)

IRQ_TYPE_LEVEL_HIGH>;

Quoted 5 lines

Quoted 5 lines

Quoted 5 lines

Quoted 1 line

Does this intentionally list only the new string?

If we want compatibility between new dts files and old kernels, this

would

Quoted 6 lines

Quoted 6 lines

Quoted 3 lines

need to be

      compatible = "isl,isl29028", compatible = "isil,isl29028";

Are we aiming for new dts wto work with old kernels? It's nice if they do, but I don't think it should be necessary. Old DTBs should

definitely

Quoted 10 lines

Quoted 6 lines

work with a new kernel, though.

Personally I'd rather see one string (preferably the canonical one, but the deprecated one is ok) than two strings when those strings are for the exact same device.

Ok, fair enough. I think we should have the new name in dts files normally then, in order to avoid spreading the mistake further when someone copies it.

Sounds good to me.

Mark.

So we stick to using just the new string, right? Any more changes to this patch ?