Skip to contentSkip to conversation

add -E option to mke2fs usage information

PATCH In review Coly Li 2 participants 4 messages Oct 15, 2007 – Oct 16, 2007

lore
Share & tools
lore

Coly Li

author
#0 lore raw

PATCH 1/1 add -E option to mke2fs usage information

-E option is missed from usage information of mke2fs. This patch adds -E option to usage information, and names -E|-R as extended-option.
Now the usage information can be consistent with mke2fs.8.in.

Signed-off-by Coly Li <[email protected]>
---
 misc/mke2fs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
misc/mke2fs.c +1 -1
index 4a6cace..128aa43 100644
@@ -100,7 +100,7 @@ static void usage(void)
 	"\t[-N number-of-inodes] [-m reserved-blocks-percentage] "
 	"[-o creator-os]\n\t[-g blocks-per-group] [-L volume-label] "
 	"[-M last-mounted-directory]\n\t[-O feature[,...]] "
-	"[-r fs-revision] [-R options] [-qvSV]\n\tdevice [blocks-count]\n"),
+	"[-r fs-revision] [-E|-R extended-option[,...]] [-qvSV]\n\tdevice [blocks-count]\n"),
 		program_name);
 	exit(1);
 }
Signature · 2 lines
Coly Li
SuSE PRC Labs
#1 lore raw
Quoted 3 lines · Coly Li

-E option is missed from usage information of mke2fs. This patch adds -E option to usage information, and names -E|-R as extended-option.
Now the usage information can be consistent with mke2fs.8.in.

Please fill comments to 80 columns; thanks!!

I checked this into the maint branch, but I just changed the message to use -E only. The use of -R is deprecated, but supported for backwards compatibility; so there's no point putting it in the usage message.

- Ted

author
#2 lore raw
Quoted 6 lines · Theodore Tso
Quoted 3 lines · Coly Li

-E option is missed from usage information of mke2fs. This patch adds -E option to usage information, and names -E|-R as extended-option.
Now the usage information can be consistent with mke2fs.8.in.

Please fill comments to 80 columns; thanks!!

I will note this in future patches :-)

Quoted 5 lines

I checked this into the maint branch, but I just changed the message to use -E only. The use of -R is deprecated, but supported for backwards compatibility; so there's no point putting it in the usage message.

Thanks for the message :-)

Quoted 2 lines

- Ted

author
#3 lore raw
In reply to Theodore Tso
Quoted 6 lines · Theodore Tso
Quoted 3 lines · Coly Li

-E option is missed from usage information of mke2fs. This patch adds -E option to usage information, and names -E|-R as extended-option.
Now the usage information can be consistent with mke2fs.8.in.

Please fill comments to 80 columns; thanks!!

I will follow this in future patches :-)

Quoted 5 lines

I checked this into the maint branch, but I just changed the message to use -E only. The use of -R is deprecated, but supported for backwards compatibility; so there's no point putting it in the usage message.

Thanks for the message :-)

Quoted 2 lines

- Ted