Make MPC8266ADS compile again
PATCH 1/1 Make MPC8266ADS compile again
Make MPC8266ADS board compile again.
include/configs/MPC8266ADS.h +2 -0
@@ -168,6 +168,7 @@#undef CONFIG_CMD_MFSL#undef CONFIG_CMD_MMC#undef CONFIG_CMD_NAND +#undef CONFIG_CMD_ONENAND#undef CONFIG_CMD_PCMCIA#undef CONFIG_CMD_REISER#undef CONFIG_CMD_SCSI
@@ -177,6 +178,7 @@#undef CONFIG_CMD_UNIVERSE#undef CONFIG_CMD_USB#undef CONFIG_CMD_XIMG +#undef CONFIG_CMD_AT91_SPIMUX/* Define a command string that is automatically executed when no character * is read on the console interface withing "Boot Delay" after reset.
PATCH 1/1 Make MPC8266ADS compile again
Quoted 16 lines · runet at innovsys.com
Make MPC8266ADS board compile again.
Signed-off-by Runet Torgersen <[email protected]>include/configs/MPC8266ADS.h +1
-0@@ -168,6 +168,7 @@#undef CONFIG_CMD_MFSL#undef CONFIG_CMD_MMC#undef CONFIG_CMD_NAND +#undef CONFIG_CMD_ONENAND#undef CONFIG_CMD_PCMCIA#undef CONFIG_CMD_REISER#undef CONFIG_CMD_SCSI
include/configs/MPC8266ADS.h line 184
Quoted 7 lines
include/configs/MPC8266ADS.h +1
-0@@ -177,6 +178,7 @@#undef CONFIG_CMD_UNIVERSE#undef CONFIG_CMD_USB#undef CONFIG_CMD_XIMG +#undef CONFIG_CMD_AT91_SPIMUX/* Define a command string that is automatically executed when no character * is read on the console interface withing "Boot Delay" after reset.
The *proper* fix is to delete the
#include <config_cmd_all.h>
and #define only the commands that actually are desired.
The simplest (and probably most proper) way to do this is actually to #include <config_cmd_default.h>
and then add non-default commands that may be useful on the MPC8266ADS board.
The current configuration is legacy from the old bit-mapped configuration ways plus a very poor choice to do the "all-subtractive" method of selecting commands.
With the "all-subtractive" method, new commands will *FOREVER* be breaking the board, resulting in patches and/or bit rot forever. Please fix it once, right, and we will all thank you forever.
TIA,
gvb
PATCH 1/1 Make MPC8266ADS compile again
Quoted 4 lines · In message <[email protected]> you wrote:
The *proper* fix is to delete the
#include <config_cmd_all.h>
and #define only the commands that actually are desired.
Hm...
Quoted 4 lines
The simplest (and probably most proper) way to do this is actually to #include <
config_cmd_default.h>
and then add non-default commands that may be useful on the MPC8266ADS board.
Indeed, that's the preferred way for 99% of all situations.
Quoted 7 lines
The current configuration is legacy from the old bit-mapped configuration ways plus a very poor choice to do the "all-subtractive" method of selecting commands.
With the "all-subtractive" method, new commands will *FOREVER* be breaking the board, resulting in patches and/or bit rot forever. Please fix it once, right, and we will all thank you forever.
Agreed.
Nevertheless, the patch fixes a real build problem now, so I'll apply it.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Q: How do you spell "onomatopoeia"? A: The way it sounds.
Wolfgang Denk
AppliedPATCH 1/1 Make MPC8266ADS compile again
In reply to runet at innovsys.comQuoted 2 lines · In message <47151610.47FrR7hZ3a0AxzYl%[email protected]> you wrote:
Make MPC8266ADS board compile again.
Signed-off-by Runet Torgersen <[email protected]>
Applied, but please see JVB's remarks!
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nail here --X-- for new monitor.