Skip to contentSkip to conversation

OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800

PATCH In review Anderson Briglia 3 participants 5 messages Oct 16, 2007 – Nov 23, 2007

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Anderson Briglia

author
#0 lore raw

PATCH 1/1 OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800

GPIO switch is needed for TUSB6010 code. It must be selected when TUSB6010 is marked on N800 device.

Signed-off-by Anderson Briglia <[email protected]>
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/Kconfig +1 -0
index 51fc13a..9323bd0 100644
@@ -37,6 +37,7 @@ config MACH_NOKIA_N800
 	select CBUS if VIDEO_TCM825X
 	select CBUS_RETU if VIDEO_TCM825X
 	select MENELAUS if VIDEO_TCM825X
+	select OMAP_GPIO_SWITCH
 
 config MACH_OMAP2_TUSB6010
 	bool
Signature · 1 line
1.5.2
maintainer
#1 lore raw

Hi,

Quoted 13 lines · Anderson Briglia

GPIO switch is needed for TUSB6010 code. It must be selected when TUSB6010 is marked on N800 device.

Signed-off-by Anderson Briglia <[email protected]>
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/Kconfig +0 -0
index 51fc13a..9323bd0 100644

arch/arm/mach-omap2/Kconfig config MACH_NOKIA_N800 · line 43

Quoted 7 lines
arch/arm/mach-omap2/Kconfig +1 -0
@@ -37,6 +37,7 @@ config MACH_NOKIA_N800
 	select CBUS if VIDEO_TCM825X
 	select CBUS_RETU if VIDEO_TCM825X
 	select MENELAUS if VIDEO_TCM825X
+	select OMAP_GPIO_SWITCH
 
 config MACH_OMAP2_TUSB6010
 	bool

At least the comment is wrong, can you please check? There's not gpio_switch dependency in tusb6010 code AFAIK.

Tony

author
#2 lore raw
Quoted 21 lines · ext Tony Lindgren

Hi,

Quoted 18 lines · Anderson Briglia

GPIO switch is needed for TUSB6010 code. It must be selected when TUSB6010 is marked on N800 device.

Signed-off-by Anderson Briglia <[email protected]>
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/Kconfig +1 -0
index 51fc13a..9323bd0 100644
@@ -37,6 +37,7 @@ config MACH_NOKIA_N800
 	select CBUS if VIDEO_TCM825X
 	select CBUS_RETU if VIDEO_TCM825X
 	select MENELAUS if VIDEO_TCM825X
+	select OMAP_GPIO_SWITCH
Quoted 5 lines

arch/arm/mach-omap2/Kconfig config MACH_NOKIA_N800 · line 43

Quoted 2 lines
arch/arm/mach-omap2/Kconfig +0 -0
 config MACH_OMAP2_TUSB6010
 	bool

At least the comment is wrong, can you please check? There's not gpio_switch dependency in tusb6010 code AFAIK.

Yes, you're right. I'm re-sending with another comment.

Quoted 3 lines

Tony

#3 lore raw

PATCH 1/1 OMAP: Moving TWL id for i2c in board files

In reply to Anderson Briglia

This patch moves the the adapter number from twl core file to board files.

Signed-off-by chandra shekhar <[email protected]>
---
 drivers/i2c/chips/twl4030_core.c |    2 --
 include/asm/arch/board-2430sdp.h |    3 +++
 include/asm/arch/board-3430sdp.h |    2 ++
 3 files changed, 5 insertions(+), 2 deletions(-)
drivers/i2c/chips/twl4030_core.c +0 -2
Index: linux-git-anand-19NOV/drivers/i2c/chips/twl4030_core.c
===================================================================
@@ -131,8 +131,6 @@
 #define HFCLK_FREQ_38p4_MHZ		(3 << 0)
 #define HIGH_PERF_SQ			(1 << 3)
 
-/* on I2C-1 for 2430SDP */
-#define CONFIG_I2C_TWL4030_ID		1
 
 /**** Helper functions */
 static int
include/asm/arch/board-2430sdp.h +3 -0
Index: linux-git-anand-19NOV/include/asm/arch/board-2430sdp.h
===================================================================
@@ -34,6 +34,9 @@
 #define OMAP24XX_ETHR_GPIO_IRQ		149
 #define SDP2430_CS0_BASE		0x04000000
 
+/* on I2C-2 for 2430SDP */
+#define CONFIG_I2C_TWL4030_ID		2
+
 #define TWL4030_IRQNUM			INT_24XX_SYS_NIRQ
 
 /* TWL4030 Primary Interrupt Handler (PIH) interrupts */
include/asm/arch/board-3430sdp.h +2 -0
Index: linux-git-anand-19NOV/include/asm/arch/board-3430sdp.h
===================================================================
@@ -61,6 +61,8 @@
 #define ONENAND_MAP	0x20000000  /* OneNand flash */
 
 #ifdef CONFIG_TWL4030_CORE
+/* on I2C-1 for 3430SDP */
+#define CONFIG_I2C_TWL4030_ID           1
 
 #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
maintainer
#4 lore raw

Re: [PATCH] OMAP: Moving TWL id for i2c in board files

Quoted 41 lines · Chandra shekhar

This patch moves the the adapter number from twl core file to board files.

Signed-off-by chandra shekhar <[email protected]>
---
 drivers/i2c/chips/twl4030_core.c |    2 --
 include/asm/arch/board-2430sdp.h |    3 +++
 include/asm/arch/board-3430sdp.h |    2 ++
 3 files changed, 5 insertions(+), 2 deletions(-)

Index: linux-git-anand-19NOV/drivers/i2c/chips/twl4030_core.c
===================================================================

drivers/i2c/chips/twl4030_core.c +0 -2
@@ -131,8 +131,6 @@
 #define HFCLK_FREQ_38p4_MHZ		(3 << 0)
 #define HIGH_PERF_SQ			(1 << 3)
 
-/* on I2C-1 for 2430SDP */
-#define CONFIG_I2C_TWL4030_ID		1
 
 /**** Helper functions */
 static int

Index: linux-git-anand-19NOV/include/asm/arch/board-2430sdp.h
===================================================================

include/asm/arch/board-2430sdp.h +3 -0
@@ -34,6 +34,9 @@
 #define OMAP24XX_ETHR_GPIO_IRQ		149
 #define SDP2430_CS0_BASE		0x04000000
 
+/* on I2C-2 for 2430SDP */
+#define CONFIG_I2C_TWL4030_ID		2
+
 #define TWL4030_IRQNUM			INT_24XX_SYS_NIRQ
 
 /* TWL4030 Primary Interrupt Handler (PIH) interrupts */

Index: linux-git-anand-19NOV/include/asm/arch/board-3430sdp.h
===================================================================

include/asm/arch/board-3430sdp.h line 67

Quoted 7 lines
include/asm/arch/board-3430sdp.h +2 -0
@@ -61,6 +61,8 @@
 #define ONENAND_MAP	0x20000000  /* OneNand flash */
 
 #ifdef CONFIG_TWL4030_CORE
+/* on I2C-1 for 3430SDP */
+#define CONFIG_I2C_TWL4030_ID           1
 
 #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ

This will again break any chance of compiling in support for multiple omap2 and omap3 boards. Could you please update this to get the ID configuration from board-*.c files? See how tps65010 handles it for example.

Regards,

Tony