Skip to contentSkip to conversation

Fix again the fl6_sock_lookup() fixed locking

PATCH Applied Pavel Emelyanov 2 participants 2 messages Oct 18, 2007

Subsystems (4)
Networking Network drivers IPv4/IPv6 Arm/actions semi architecture
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 1/1 Fix again the fl6_sock_lookup() fixed locking

YOSHIFUJI fairly pointed out, that the users increment should be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a chance to put this count to zero and release the flowlabel.

Signed-off-by Pavel Emelyanov <[email protected]>
Cc YOSHIFUJI Hideaki <[email protected]>

---

net/ipv6/ip6_flowlabel.c +1 -1
index e55ae1a..b12cc22 100644
@@ -210,9 +210,9 @@ struct ip6_flowlabel * fl6_sock_lookup(struct sock *sk, __be32 label)
 	for (sfl=np->ipv6_fl_list; sfl; sfl = sfl->next) {
 		struct ip6_flowlabel *fl = sfl->fl;
 		if (fl->label == label) {
-			read_unlock_bh(&ip6_sk_fl_lock);
 			fl->lastuse = jiffies;
 			atomic_inc(&fl->users);
+			read_unlock_bh(&ip6_sk_fl_lock);
 			return fl;
 		}
 	}
maintainer Applied
#1 lore raw

From: Pavel Emelyanov <[email protected]>
Date: Thu, 18 Oct 2007 16:36:58 +0400

Quoted 6 lines

YOSHIFUJI fairly pointed out, that the users increment should be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a chance to put this count to zero and release the flowlabel.

Signed-off-by Pavel Emelyanov <[email protected]>
Cc YOSHIFUJI Hideaki <[email protected]>

Applied, thank you very much Pavel.