Skip to contentSkip to conversation

ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

PATCH Applied Randy Dunlap 3 participants 4 messages Oct 19, 2007 – Oct 20, 2007 1 message not in the archive

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Randy Dunlap

author
#1 lore raw

PATCH 1/1 ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

[[email protected] wrote:]

From: Randy Dunlap <[email protected]>

Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only for library-like code, not to enable subsystems.

ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined!
ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>

---
drivers/net/Kconfig | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +0 -0
@@ -2494,7 +2494,7 @@ config CHELSIO_T3

config EHEA
tristate "eHEA Ethernet support"
- depends on IBMEBUS
+ depends on IBMEBUS && INET

	select INET_LRO
	---help---
	  This driver supports the IBM pSeries eHEA ethernet adapter.

@@ -2591,7 +2591,7 @@ config S2IO_NAPI

config MYRI10GE
tristate "Myricom Myri-10G Ethernet support"
- depends on PCI
+ depends on PCI && INET
select FW_LOADER
select CRC32
select INET_LRO

maintainer Acked-by on v1 1/1
#2 lore raw

From: Randy Dunlap <[email protected]>
Date: Thu, 18 Oct 2007 21:53:50 -0700

Quoted 6 lines

[[email protected] wrote:]

From: Randy Dunlap <[email protected]>

Quoted 8 lines

Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only for library-like code, not to enable subsystems.

ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined!
ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>
Acked-by David S. Miller <[email protected]>

Jeff, please pick this one up too, thanks!

author
#3 lore raw
Quoted 13 lines · On Thu, 18 Oct 2007 22:02:22 -0700 (PDT) David Miller wrote:

From: Randy Dunlap <[email protected]>
Date: Thu, 18 Oct 2007 21:53:50 -0700

Quoted 10 lines

[[email protected] wrote:]

From: Randy Dunlap <[email protected]>

Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only for library-like code, not to enable subsystems.

Quoted 8 lines
Quoted 4 lines

ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined!
ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>
Acked-by David S. Miller <[email protected]>

Jeff, please pick this one up too, thanks!

This patch is for kernel bugzilla #9186, not #9187. Clerical error, sorry about that.

---
~Randy

Applied
#4 lore raw
In reply to Randy Dunlap
Quoted 6 lines · Randy Dunlap

[[email protected] wrote:]

From: Randy Dunlap <[email protected]>

Quoted 8 lines

Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only for library-like code, not to enable subsystems.

ERROR: "lro_flush_all" [drivers/net/myri10ge/myri10ge.ko] undefined!
ERROR: "lro_receive_frags" [drivers/net/myri10ge/myri10ge.ko] undefined!

Signed-off-by Randy Dunlap <[email protected]>

applied