Skip to contentSkip to conversation

avoid passing uninitialized ACPI tables to dom0 when checksums fail

PATCH New David Lively 1 participant 1 message Oct 19, 2007

lore
Share & tools
lore

David Lively

author
#0 lore raw

PATCH 1/1 avoid passing uninitialized ACPI tables to dom0 when checksums fail

If during boot, ACPI checksum failures disable ACPI support in Xen, pass 'acpi=off' to the domain 0 kernel to avoid a fatal page fault as domain 0 attempts to access the uninitialized ACPI tables.

Signed-off-by David Lively <[email protected]>
Signed-off-by Steve Ofsthun <[email protected]>
xen/arch/x86/setup.c +5 -0
diff -r 0e884ef3b5bd xen/arch/x86/setup.c
@@ -970,6 +970,11 @@ void __init __start_xen(unsigned long mb
         if ( acpi_skip_timer_override &&
              !strstr(dom0_cmdline, "acpi_skip_timer_override") )
             safe_strcat(dom0_cmdline, " acpi_skip_timer_override");
+        if ( (strlen(acpi_param) == 0) && acpi_disabled )
+        {
+            printk(KERN_WARNING "ACPI is disabled, notifying Domain 0\n");
+            safe_strcpy(acpi_param, "off");
+        }
         if ( (strlen(acpi_param) != 0) && !strstr(dom0_cmdline, "acpi=") )
         {
             safe_strcat(dom0_cmdline, " acpi=");

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel