PHYSADDR is for physical address, KSEG1ADDR is for uncached

IMO, KSEG1 should work for AU1X00 too, but I can't test it

Signed-off-by Vlad Lungu <[email protected]>

Signed-off-by Shinya Kuribayashi <[email protected]>

---
 include/asm-mips/addrspace.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

include/asm-mips/addrspace.h +0 -0

index b8214b1..0e6abd7 100644

Hello,

I'm going to pick up this patch into -mips repos, but several problems are there. Please see below.

Quoted 1 line · Vlad Lungu

IMO, KSEG1 should work for AU1X00 too, but I can't test it

Plase put an appropriate mail subject and patch description. "PHYSADDR is for physical address, KSEG1ADDR is for uncached" seems not be descriptive (at least for me).

If not native english speaker (of course I'm not), it helps a lot to see git log of others.

Quoted 12 lines

Signed-off-by Vlad Lungu <[email protected]>

Signed-off-by Shinya Kuribayashi <[email protected]>

---
 include/asm-mips/addrspace.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

include/asm-mips/addrspace.h +0 -0

index b8214b1..0e6abd7 100644

include/asm-mips/addrspace.h line 51

Quoted 3 lines

include/asm-mips/addrspace.h +0 -0

@@ -49,7 +49,7 @@
    cannot access physical memory directly from core */
 #define UNCACHED_SDRAM(a) (((unsigned long)(a)) | 0x20000000)
 #else  /* !CONFIG_AU1X00 */

Indentation corrupted. Check your mailer settings.

include/asm-mips/addrspace.h line 54

Quoted 4 lines

include/asm-mips/addrspace.h +1 -1

-#define UNCACHED_SDRAM(a) PHYSADDR(a)
+#define UNCACHED_SDRAM(a) KSEG1ADDR(a)
 #endif /* CONFIG_AU1X00 */
 #endif /* __ASSEMBLY__ */

ditto.

include/asm-mips/addrspace.h line 55

Quoted 1 line

include/asm-mips/addrspace.h +0 -0

 /*

As I'm excersizing repo management, please don't expect my quick response ;-)

thanks,

Shinya