ath5k: Further cleanups inside base.c
cover ath5k: Further cleanups inside base.c
A few more cleanups for base.c before i submit the rest of my fixes...
Q: Should we get rid of syctl stuff ? I mean user can only change calibration interval (which is something tricky for users to play with) and debug flags. Does anyone use this ? i mean we can put printks wherever we want, there's no need for this stuff IMHO (it comes from madwifi).
Quoted 6 lines · Nick Kossifidis
A few more cleanups for
base.cbefore i submit the rest of my fixes...Q: Should we get rid of syctl stuff ? I mean user can only change calibration interval (which is something tricky for users to play with) and debug flags. Does anyone use this ? i mean we can put printks wherever we want, there's no need for this stuff IMHO (it comes from madwifi).
Agreed. And if really want it, we can make debug a module_param...
Quoted 9 lines · Jiri Slaby
Quoted 6 lines · Nick Kossifidis
A few more cleanups for
base.cbefore i submit the rest of my fixes...Q: Should we get rid of syctl stuff ? I mean user can only change calibration interval (which is something tricky for users to play with) and debug flags. Does anyone use this ? i mean we can put printks wherever we want, there's no need for this stuff IMHO (it comes from madwifi).
Agreed. And if really want it, we can make debug a
module_param...
It should be removed, but please use 30 seconds for the calibration timer instead of every second. Every second is pretty obsessive considering the fact that even though run every second, we don't calibrate even if AR5K_PHY_IQ_RUN was set. Most of the times i_coffd or q_coffd will be 0, so all we actually do is noise floor calibration.
Luis
2007/10/22, Luis R. Rodriguez <[email protected]>:
Quoted 11 lines · Jiri Slaby
Quoted 9 lines · Nick Kossifidis
Quoted 6 lines
A few more cleanups for
base.cbefore i submit the rest of my fixes...Q: Should we get rid of syctl stuff ? I mean user can only change calibration interval (which is something tricky for users to play with) and debug flags. Does anyone use this ? i mean we can put printks wherever we want, there's no need for this stuff IMHO (it comes from madwifi).
Agreed. And if really want it, we can make debug a
module_param...
Quoted 9 lines
It should be removed, but please use 30 seconds for the calibration timer instead of every second. Every second is pretty obsessive considering the fact that even though run every second, we don't calibrate even if
AR5K_PHY_IQ_RUNwas set. Most of the timesi_coffdorq_coffdwill be 0, so all we actually do is noise floor calibration.Luis
I didn't change the interval, i just cleaned up the code, as you can see that value was put there before (through a macro in base.h -i just removed the macro). Anyway i'll check out calibration stuff more careful because periodic calibration doesn't seem right if we change rates etc (we had a discussion on madwifi-devel on this and i'm still searching it).
Signature · 3 lines
GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick