Remove in-code externs for some functions from net/core/dev.c
Subsystems (2)
PATCH 2/3 Remove in-code externs for some functions from net/core/dev.c
Inconsistent prototype and real type for functions may have worse consequences, than those for variables, so move them into a header.
Since they are used privately in net/core, make this file reside in the same place.
Signed-off-by Pavel Emelyanov <[email protected]>
---
net/core/dev.c +2 -4
@@ -120,6 +120,8 @@#include <linux/ctype.h> #include <linux/if_arp.h> +#include "net-sysfs.h" +/* * The list of packet types we will receive (as opposed to discard) * and the routines to invoke.
@@ -249,10 +251,6 @@ static RAW_NOTIFIER_HEAD(netdev_chain); DEFINE_PER_CPU(struct softnet_data, softnet_data); -extern int netdev_kobject_init (void ); -extern int netdev_register_kobject (struct net_device *); -extern void netdev_unregister_kobject (struct net_device *); -#ifdef CONFIG_DEBUG_LOCK_ALLOC /* * register_netdevice() inits dev->_xmit_lock and sets lockdep class
net/core/net-sysfs.c +2 -0
@@ -18,6 +18,8 @@#include <linux/wireless.h> #include <net/iw_handler.h> +#include "net-sysfs.h" +#ifdef CONFIG_SYSFS static const char fmt_hex[] ="%#x\n" ;static const char fmt_long_hex[] ="%#lx\n" ;
net/core/net-sysfs.h new file +8 -0
@@ -0,0 +1,8 @@ +#ifndef __NET_SYSFS_H__ +#define __NET_SYSFS_H__ + +int netdev_kobject_init (void ); +int netdev_register_kobject (struct net_device *); +void netdev_unregister_kobject (struct net_device *); + +#endif
Signature · 1 line
1.5.3.4
From: Pavel Emelyanov <[email protected]>
Date: Mon, 22 Oct 2007 19:25:50 +0400
Quoted 8 lines
Inconsistent prototype and real type for functions may have worse consequences, than those for variables, so move them into a header.
Since they are used privately in net/core, make this file reside in the same place.
Signed-off-by Pavel Emelyanov <[email protected]>
Applied, thanks.