Skip to contentSkip to conversation

fix drivers/net/wan/lmc/ compilation

PATCH In review Adrian Bunk 2 participants 2 messages Oct 30, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 fix drivers/net/wan/lmc/ compilation

Documentation/SubmitChecklist, point 1:

<-- snip -->

...
CC drivers/net/wan/lmc/lmc_main.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_ioctl’:
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c:239: error: expected expression before ‘else’
...
make[5]: *** [drivers/net/wan/lmc/lmc_main.o] Error 1

<-- snip -->

Signed-off-by Adrian Bunk <[email protected]>

---
d5e92a30491abf073e0a7f4d46b466c7c97f0f61

drivers/net/wan/lmc/lmc_main.c +1 -1
index 64eb578..37c52e1 100644
@@ -234,7 +234,7 @@ int lmc_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/
         sc->lmc_xinfo.Magic1 = 0xDEADBEEF;
 
         if (copy_to_user(ifr->ifr_data, &sc->lmc_xinfo,
-					sizeof(struct lmc_xinfo))) {
+			 sizeof(struct lmc_xinfo)))
 		ret = -EFAULT;
 	else
 		ret = 0;
#1 lore raw
Quoted 23 lines · Adrian Bunk

Documentation/SubmitChecklist, point 1:

<-- snip -->

...
CC drivers/net/wan/lmc/lmc_main.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_ioctl’:
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c:239: error: expected expression before ‘else’
...
make[5]: *** [drivers/net/wan/lmc/lmc_main.o] Error 1

<-- snip -->

Signed-off-by Adrian Bunk <[email protected]>

---
d5e92a30491abf073e0a7f4d46b466c7c97f0f61

drivers/net/wan/lmc/lmc_main.c +0 -0
index 64eb578..37c52e1 100644

drivers/net/wan/lmc/lmc_main.c int lmc_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/ · line 240

Quoted 8 lines
drivers/net/wan/lmc/lmc_main.c +1 -1
@@ -234,7 +234,7 @@ int lmc_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/
         sc->lmc_xinfo.Magic1 = 0xDEADBEEF;
 
         if (copy_to_user(ifr->ifr_data, &sc->lmc_xinfo,
-					sizeof(struct lmc_xinfo))) {
+			 sizeof(struct lmc_xinfo)))
 		ret = -EFAULT;
 	else
 		ret = 0;

I am sorry, my patch broke this and Kristov Provost also noticed this. See http://lkml.org/lkml/2007/10/30/355