Skip to contentSkip to conversation

iounmap after ioremap in error path: arch/ia64/pci/pci.c

PATCH In review Roel Kluin 2 participants 2 messages Nov 3, 2007 – Nov 5, 2007

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 iounmap after ioremap in error path: arch/ia64/pci/pci.c

Do iounmap when too many IO port spaces were encountered

Signed-off-by Roel Kluin <[email protected]>

---

arch/ia64/pci/pci.c +1 -0
index 488e48a..13a05d7 100644
@@ -154,6 +154,7 @@ new_space (u64 phys_base, int sparse)
 			return i;
 
 	if (num_io_spaces = MAX_IO_SPACES) {
+		iounmap(mmio_base);
 		printk(KERN_ERR "PCI: Too many IO port spaces "
 			"(MAX_IO_SPACES=%lu)\n", MAX_IO_SPACES);
 		return ~0;
#1 lore raw
Quoted 3 lines · Roel Kluin

Do iounmap when too many IO port spaces were encountered

Signed-off-by Roel Kluin <[email protected]>

This looks correct to me, so long as calling iounmap() actually reverses ioremap() in this case.

Quoted 17 lines

---

arch/ia64/pci/pci.c +1 -1
index 488e48a..13a05d7 100644
@@ -154,6 +154,7 @@ new_space (u64 phys_base, int sparse)
 			return i;
 
 	if (num_io_spaces = MAX_IO_SPACES) {
+		iounmap(mmio_base);
 		printk(KERN_ERR "PCI: Too many IO port spaces "
 			"(MAX_IO_SPACES=%lu)\n", MAX_IO_SPACES);
 		return ~0;
-

To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/