Skip to contentSkip to conversation

iounmap after ioremap in arch/ia64/sn/pci/pcibr/pcibr_provider.c

PATCH Roel Kluin 2 participants 2 messages Nov 3, 2007 – Nov 5, 2007

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

A better discription, maybe?
--
iounmap after ioremap

---

arch/ia64/sn/pci/pcibr/pcibr_provider.c +1 -0
index ab3eaf8..00d1b85 100644
@@ -186,6 +186,7 @@ pcibr_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
 
 	if (!soft->pbi_int_ate_resource.ate) {
 		kfree(soft);
+		iounmap(soft->pbi_buscommon.bs_base);
 		return NULL;
 	}
 
#1 lore raw
Quoted 3 lines · Roel Kluin

A better discription, maybe?
--
iounmap after ioremap

Again, this looks correct to me, so long as calling iounmap() actually reverses ioremap() in this case.

Quoted 19 lines

---

arch/ia64/sn/pci/pcibr/pcibr_provider.c +1 -1
index ab3eaf8..00d1b85 100644
@@ -186,6 +186,7 @@ pcibr_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
 
 	if (!soft->pbi_int_ate_resource.ate) {
 		kfree(soft);
+		iounmap(soft->pbi_buscommon.bs_base);
 		return NULL;
 	}
 
-

To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/