Skip to contentSkip to conversation

iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c

PATCH In review Roel Kluin 2 participants 4 messages Nov 4, 2007 – Nov 5, 2007

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c

Do iounmap if tioce_kern_init fails

Signed-off-by Roel Kluin <[email protected]>

---

arch/ia64/sn/pci/tioce_provider.c +1 -0
index cee9379..128ed07 100644
@@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
 
 	tioce_kern = tioce_kern_init(tioce_common);
 	if (tioce_kern = NULL) {
+		iounmap(tioce_common->ce_pcibus.bs_base);
 		kfree(tioce_common);
 		return NULL;
 	}
#1 lore raw
Quoted 1 line · Roel Kluin

Do iounmap if tioce_kern_init fails

This is covered by a subsequent patch, right?

Quoted 19 lines
Signed-off-by Roel Kluin <[email protected]>

---

arch/ia64/sn/pci/tioce_provider.c +1 -1
index cee9379..128ed07 100644
@@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
 
 	tioce_kern = tioce_kern_init(tioce_common);
 	if (tioce_kern = NULL) {
+		iounmap(tioce_common->ce_pcibus.bs_base);
 		kfree(tioce_common);
 		return NULL;
 	}
 
-

To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/
author
#2 lore raw
In reply to Roel Kluin
Quoted 4 lines · Simon Horman
Quoted 1 line · Roel Kluin

Do iounmap if tioce_kern_init fails

This is covered by a subsequent patch, right?

aparently it should, what am I missing?

Quoted 14 lines
Quoted 14 lines
Signed-off-by Roel Kluin <[email protected]>

---

arch/ia64/sn/pci/tioce_provider.c +1 -0
index cee9379..128ed07 100644
@@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
 
 	tioce_kern = tioce_kern_init(tioce_common);
 	if (tioce_kern = NULL) {
+		iounmap(tioce_common->ce_pcibus.bs_base);
 		kfree(tioce_common);
 		return NULL;
 	}
#3 lore raw
In reply to Roel Kluin
Quoted 7 lines · Roel Kluin
Quoted 4 lines · Simon Horman
Quoted 1 line · Roel Kluin

Do iounmap if tioce_kern_init fails

This is covered by a subsequent patch, right?

aparently it should, what am I missing?

Nothing, I was just confirming that it is duplicated elsewhere :-)

Quoted 15 lines
Quoted 14 lines
Quoted 14 lines
Signed-off-by Roel Kluin <[email protected]>

---

arch/ia64/sn/pci/tioce_provider.c +1 -0
index cee9379..128ed07 100644
@@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
 
 	tioce_kern = tioce_kern_init(tioce_common);
 	if (tioce_kern = NULL) {
+		iounmap(tioce_common->ce_pcibus.bs_base);
 		kfree(tioce_common);
 		return NULL;
 	}
Signature · 3 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/