Skip to contentSkip to conversation

ide-disk: guarantee 400ns delay after writing command register

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Nov 2, 2007 – Nov 4, 2007 libata

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 2/9 ide-disk: guarantee 400ns delay after writing command register

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/ide-disk.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ide/ide-disk.c +1 -0
Index: b/drivers/ide/ide-disk.c
===================================================================
@@ -274,6 +274,7 @@ static ide_startstop_t __ide_do_rw_disk(
 		}
 
 		hwif->OUTBSYNC(drive, command, IDE_COMMAND_REG);
+		ndelay(400);	/* FIXME */
 
 		return pre_task_out_intr(drive, rq);
 	}
Acked-by on v1 2/9
#1 lore raw

Hello.

Quoted 1 line · Bartlomiej Zolnierkiewicz
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Sergei Shtylyov <[email protected]>

drivers/ide/ide-disk.c static ide_startstop_t __ide_do_rw_disk( · line 277

Quoted 9 lines

Index: b/drivers/ide/ide-disk.c
===================================================================

drivers/ide/ide-disk.c +1 -0
@@ -274,6 +274,7 @@ static ide_startstop_t __ide_do_rw_disk(
 		}
 
 		hwif->OUTBSYNC(drive, command, IDE_COMMAND_REG);
+		ndelay(400);	/* FIXME */

FIXME?

drivers/ide/ide-disk.c static ide_startstop_t __ide_do_rw_disk( · line 280

Quoted 2 lines
drivers/ide/ide-disk.c +0 -0
 		return pre_task_out_intr(drive, rq);
 	}

MBR, Sergei