Skip to contentSkip to conversation

Fix incorrect usage of strncat in bdx_get_drvinfo(); drivers/net/tehuti.c

PATCH Applied Roel Kluin 2 participants 2 messages Nov 5, 2007 – Nov 13, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 Fix incorrect usage of strncat in bdx_get_drvinfo(); drivers/net/tehuti.c

Fix incorrect length for strncat by replacing it with strlcat

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/tehuti.c +4 -4
index 4e1b84e..21230c9 100644
@@ -2168,10 +2168,10 @@ bdx_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
 {
 	struct bdx_priv *priv = netdev->priv;
 
-	strncat(drvinfo->driver, BDX_DRV_NAME, sizeof(drvinfo->driver));
-	strncat(drvinfo->version, BDX_DRV_VERSION, sizeof(drvinfo->version));
-	strncat(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
-	strncat(drvinfo->bus_info, pci_name(priv->pdev),
+	strlcat(drvinfo->driver, BDX_DRV_NAME, sizeof(drvinfo->driver));
+	strlcat(drvinfo->version, BDX_DRV_VERSION, sizeof(drvinfo->version));
+	strlcat(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
+	strlcat(drvinfo->bus_info, pci_name(priv->pdev),
 		sizeof(drvinfo->bus_info));
 
 	drvinfo->n_stats = ((priv->stats_flag) ?