Skip to contentSkip to conversation

Remove uninitialized cow if snapshot creation fails

PATCH New Jun'ichi Nomura 1 participant 1 message Nov 9, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove uninitialized cow if snapshot creation fails

Similar to the mirror log cleanup, snapshot cow also should be removed if the snapshot creation fails.

# dmsetup create --notable testvg-lvol1-cow
# lvcreate -s -l1 -n lvol1 testvg/lvol0
  /dev/testvg/lvol1: not found: device not cleared
  Aborting. Failed to wipe snapshot exception store. Remove new LV and retry.
# lvs
  LV    VG     Attr   LSize Origin Snap%  Move Log Copy% 
  lvol0 testvg -wi-a- 4.00M
  lvol1 testvg -wi--- 4.00M

Attached patch removes the incomplete COW LV if the snapshot creation fails.

A test script is also attached.

Thanks,

Signature · 15 lines
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvm2-cleanup-cow-on-init-failure.patch
Type: text/x-patch
Size: 2476 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20071109/a2fa5ee8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup-lvcreate-snapshot.sh
Type: application/x-sh
Size: 1477 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20071109/a2fa5ee8/attachment.sh>