Skip to contentSkip to conversation

Remove bugus goto-s from ip_route_input_slow

PATCH Applied Pavel Emelyanov 2 participants 2 messages Nov 10, 2007 – Nov 11, 2007

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 1/1 Remove bugus goto-s from ip_route_input_slow

Both places look like

        if (err == XXX) 
               goto yyy;

done:

while both yyy targets look like

        err = XXX;
        goto done;

so this is ok to remove the above if-s.

yyy labels are used in other places and are not removed.

Signed-off-by Pavel Emelyanov <[email protected]>

---

net/ipv4/route.c +0 -5
index 21b12de..c95b270 100644
@@ -1813,11 +1813,6 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
 		goto martian_destination;
 
 	err = ip_mkroute_input(skb, &res, &fl, in_dev, daddr, saddr, tos);
-	if (err == -ENOBUFS)
-		goto e_nobufs;
-	if (err == -EINVAL)
-		goto e_inval;
-
 done:
 	in_dev_put(in_dev);
 	if (free_res)
Signature · 1 line
1.5.3.4
maintainer Applied
#1 lore raw

From: Pavel Emelyanov <[email protected]>
Date: Sat, 10 Nov 2007 17:27:50 +0300

Quoted 8 lines

Both places look like

        if (err == XXX) 
               goto yyy;

done:

while both yyy targets look like

Quoted 8 lines
        err = XXX;
        goto done;

so this is ok to remove the above if-s.

yyy labels are used in other places and are not removed.

Signed-off-by Pavel Emelyanov <[email protected]>

Applied, thanks.