Skip to contentSkip to conversation

Enable ULi1575 Ethernet support in 8610HPCD config

PATCH New Jon Loeliger 6 participants 15 messages Nov 13, 2007 – Nov 16, 2007

lore
Share & tools
lore

Jon Loeliger

author
#0 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

From: Roy Zang <[email protected]>

Signed-off-by Roy Zang <[email protected]>
Acked-by Jon Loeliger <[email protected]>
---
 include/configs/MPC8610HPCD.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
include/configs/MPC8610HPCD.h +4 -4
index f5d9c09..ef1310f 100644
@@ -312,16 +312,16 @@
 #define CONFIG_PCI_SCAN_SHOW		/* show pci devices on startup */
 
 #define CONFIG_NET_MULTI
+#define CONFIG_CMD_NET
 #define CONFIG_PCI_PNP		/* do pci plug-and-play */
 
-#if 0 /* TODO */
-/* enable onboard uli network support */
-#endif
-
 #define CONFIG_RTL8139
 #define CONFIG_SK98
 #define CONFIG_EEPRO100
 #define CONFIG_TULIP
+#ifdef CONFIG_TULIP
+#define CONFIG_ETHADDR   00:E0:0C:00:00:01
+#endif
 
 /************************************************************
  * USB support
Signature · 1 line
1.5.3
#1 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 8 lines · Jon Loeliger

From: Roy Zang <[email protected]>

Signed-off-by Roy Zang <[email protected]>
Acked-by Jon Loeliger <[email protected]>
---
 include/configs/MPC8610HPCD.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

<snip>

include/configs/MPC8610HPCD.h line 323

Quoted 5 lines

#define CONFIG_EEPRO100
#define CONFIG_TULIP

include/configs/MPC8610HPCD.h +2 -0
+#ifdef CONFIG_TULIP
+#define CONFIG_ETHADDR   00:E0:0C:00:00:01

Do you really need to do this? It's just asking for trouble.

regards,
Ben

#2 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 9 lines · Ben Warren
Quoted 8 lines · Jon Loeliger

From: Roy Zang <[email protected]>

Signed-off-by Roy Zang <[email protected]>
Acked-by Jon Loeliger <[email protected]>
---
 include/configs/MPC8610HPCD.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Quoted 7 lines

<snip>

include/configs/MPC8610HPCD.h line 323

Quoted 5 lines

#define CONFIG_EEPRO100
#define CONFIG_TULIP

include/configs/MPC8610HPCD.h +2 -0
+#ifdef CONFIG_TULIP
+#define CONFIG_ETHADDR   00:E0:0C:00:00:01

Do you really need to do this? It's just asking for trouble.

It can assign a init MAC address to the port. Now, EEPROM issue is solved. We can remove it. CONFIG_TULIP is not accurate for the port. I have renamed it to CONFIG_ULI526X in the driver. I will provide a patch to fix both of these. Tired today :-), hope tomorrow!
Thanks.
Roy

#3 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 23 lines · Zang Roy-r61911 wrote:
Quoted 13 lines · Ben Warren
Quoted 9 lines · Jon Loeliger

From: Roy Zang <[email protected]>

Signed-off-by Roy Zang <[email protected]>
Acked-by Jon Loeliger <[email protected]>
---
 include/configs/MPC8610HPCD.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

<snip>

Quoted 8 lines

include/configs/MPC8610HPCD.h line 323

Quoted 6 lines

#define CONFIG_EEPRO100
#define CONFIG_TULIP

include/configs/MPC8610HPCD.h +2 -0
+#ifdef CONFIG_TULIP
+#define CONFIG_ETHADDR   00:E0:0C:00:00:01

Do you really need to do this? It's just asking for trouble.

Quoted 11 lines

It can assign a init MAC address to the port. Now, EEPROM issue is solved. We can remove it. CONFIG_TULIP is not accurate for the port. I have renamed it to CONFIG_ULI526X in the driver. I will provide a patch to fix both of these. Tired today :-), hope tomorrow!
Thanks.
Roy

Sounds good. Sleep > work.

regards,
Ben

#4 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

In reply to Jon Loeliger
Quoted 5 lines · Jon Loeliger

From: Roy Zang <[email protected]>

Signed-off-by Roy Zang <[email protected]>
Acked-by Jon Loeliger <[email protected]>

---

No commit message?

Quoted 4 lines

#define CONFIG_RTL8139
#define CONFIG_SK98
#define CONFIG_EEPRO100
#define CONFIG_TULIP

Shouldn't we undefine these macros? With the on-board ULI working now, we don't need these other NICs.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
author
#5 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 2 lines · Timur Tabi

No commit message?

When will people figure this out?

The mail Subject: line _is_ the first line of
the commit log message.

Thanks,
jdl

#6 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 2 lines · Jon Loeliger

The mail Subject: line _is_ the first line of
the commit log message.

I like to see commit logs that are more than just one line.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
author
#7 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 7 lines · Timur Tabi
Quoted 2 lines · Jon Loeliger

The mail Subject: line _is_ the first line of
the commit log message.

I like to see commit logs that are more than just one line.

I don't like them when it isn't necessary.

Deal with it.

jdl

#8 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

In reply to Timur Tabi
Quoted 5 lines · Timur Tabi
Quoted 2 lines · Jon Loeliger

The mail Subject: line _is_ the first line of
the commit log message.

I like to see commit logs that are more than just one line.

I like this too. But in some cases, one line is really enough. And this is the case here too.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#9 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

In reply to Timur Tabi
Quoted 7 lines · Timur Tabi
Quoted 4 lines

#define CONFIG_RTL8139
#define CONFIG_SK98
#define CONFIG_EEPRO100
#define CONFIG_TULIP

Shouldn't we undefine these macros? With the on-board ULI working now, we don't need these other NICs.

Obviously, I was only talking about the first three. We still need to define CONFIG_TULIP.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#10 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 7 lines · Tabi Timur
Quoted 5 lines · Timur Tabi
Quoted 4 lines

#define CONFIG_RTL8139
#define CONFIG_SK98
#define CONFIG_EEPRO100
#define CONFIG_TULIP

Quoted 7 lines
Quoted 1 line

Shouldn't we undefine these macros? With the on-board ULI working

now, we don't

Quoted 1 line

need these other NICs.

Obviously, I was only talking about the first three. We still need to define
CONFIG_TULIP.

Change CONFIG_TULIP to CONFIG_ULI526X.
I intend to keep RTL8139 and Intel EEPR100. They work on the board and can provide extra choices except the on board Ethernet port. I am not sure whether SK98 work. If it can not work, we can undef it. Any idea?
Roy

#11 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 2 lines · Zang Roy-r61911 wrote:

I intend to keep RTL8139 and Intel EEPR100. They work on the board and can provide extra choices except the on board Ethernet port.

Well, the board config files should match what's on the board. We don't ship the board with an RTL or Intel NIC, therefore the config file should not enable them. With your logic, we should just enable ALL of the NICs that work.

If a customer inserts an RTL or Intel NIC, he can add those lines if he wants. Otherwise, all you're doing is bloating the binary.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#12 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 4 lines · Timur Tabi
Quoted 2 lines · Zang Roy-r61911 wrote:

I intend to keep RTL8139 and Intel EEPR100. They work on the board and can provide extra choices except the on board Ethernet port.

Is there any reason one wouldn't want to use the on-board ethernet port?

Quoted 7 lines

Well, the board config files should match what's on the board. We don't ship the board with an RTL or Intel NIC, therefore the config file should not enable them. With your logic, we should just enable ALL of the NICs that work.

If a customer inserts an RTL or Intel NIC, he can add those lines if he wants. Otherwise, all you're doing is bloating the binary.

Hmm, weren't you scrounging around for a certain kind of PCI NIC that your 8610 board's u-boot image supported not too long ago?

Wouldn't it have been nice if they built in support for a few of the most common ones? :-)

-Scott

#13 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 7 lines · Scott Wood
Quoted 4 lines · Timur Tabi
Quoted 2 lines · Zang Roy-r61911 wrote:

I intend to keep RTL8139 and Intel EEPR100. They work on the board and can provide extra choices except the on board Ethernet port.

Is there any reason one wouldn't want to use the on-board ethernet port?

Not with this patch. The only reason to enable all those other boards is because the on-board ethernet port *didn't* work, so everyone had to some some PCI NIC.

Quoted 2 lines

Hmm, weren't you scrounging around for a certain kind of PCI NIC that your 8610 board's u-boot image supported not too long ago?

Yes. That's because the on-board ethernet was not supported.

Quoted 2 lines

Wouldn't it have been nice if they built in support for a few of the most common ones? :-)

And they did. But now, it's no longer necessary.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#14 lore raw

PATCH 1/1 Enable ULi1575 Ethernet support in 8610HPCD config

Quoted 8 lines · Tabi Timur
Quoted 4 lines · Scott Wood
Quoted 3 lines · Timur Tabi
Quoted 1 line · Zang Roy-r61911 wrote:

I intend to keep RTL8139 and Intel EEPR100. They work on the board

and

Quoted 2 lines
Quoted 1 line
Quoted 1 line

can provide extra choices except the on board Ethernet port.

Quoted 9 lines
Quoted 1 line

Is there any reason one wouldn't want to use the on-board ethernet

port?

Not with this patch. The only reason to enable all those other boards is
because the on-board ethernet port *didn't* work, so everyone had to some some
PCI NIC.

That is also my opinion.
Roy