Skip to contentSkip to conversation

m68knommu: Removing config variable DUMPTOFLASH

PATCH In review Jiri Olsa 3 participants 4 messages Nov 15, 2007 – Nov 19, 2007 Kernel janitors

lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 m68knommu: Removing config variable DUMPTOFLASH

Removing config variable DUMPTOFLASH, since it is not used

Signed-off-by Jiri Olsa <[email protected]>
---
 arch/m68knommu/Kconfig.debug |    7 -------
 arch/m68knommu/defconfig     |    1 -
 2 files changed, 0 insertions(+), 8 deletions(-)
arch/m68knommu/Kconfig.debug +0 -7
index 9ff47bd..ed6d9a8 100644
@@ -21,13 +21,6 @@ config BOOTPARAM_STRING
 	default 'console=ttyS0,19200'
 	depends on BOOTPARAM
 
-config DUMPTOFLASH
-	bool "Panic/Dump to FLASH"
-	depends on COLDFIRE
-	help
-	  Dump any panic of trap output into a flash memory segment
-	  for later analysis.
-
 config NO_KERNEL_MSG
 	bool "Suppress Kernel BUG Messages"
 	help
arch/m68knommu/defconfig +0 -1
index 5a0ecaa..6481130 100644
@@ -597,7 +597,6 @@ CONFIG_MSDOS_PARTITION=y
 # CONFIG_FULLDEBUG is not set
 # CONFIG_HIGHPROFILE is not set
 # CONFIG_BOOTPARAM is not set
-# CONFIG_DUMPTOFLASH is not set
 # CONFIG_NO_KERNEL_MSG is not set
 # CONFIG_BDM_DISABLE is not set
#1 lore raw

Re: [PATCH] m68knommu: Removing config variable BDM_DISABLE

2007/11/15, Jiri Olsa <[email protected]>:

Quoted 66 lines

Removing config variable BDM_DISABLE, since it is not used Removing #ifdef MCF_BDM_DISABLE code , since MCF_BDM_DISABLE is not defined

Signed-off-by Jiri Olsa <[email protected]>
---
 arch/m68knommu/Kconfig.debug          |    6 ------
 arch/m68knommu/defconfig              |    1 -
 arch/m68knommu/platform/5307/config.c |    9 ---------
 arch/m68knommu/platform/532x/config.c |    9 ---------
 4 files changed, 0 insertions(+), 25 deletions(-)
arch/m68knommu/Kconfig.debug +0 -6
index 9ff47bd..2784b46 100644
@@ -33,10 +33,4 @@ config NO_KERNEL_MSG
        help
          Do not output any debug BUG messages within the kernel.
 
-config BDM_DISABLE
-       bool "Disable BDM signals"
-       depends on (EXPERIMENTAL && COLDFIRE)
-       help
-         Disable the ColdFire CPU's BDM signals.
-
 endmenu
arch/m68knommu/defconfig +0 -1
index 5a0ecaa..fa44eea 100644
@@ -599,7 +599,6 @@ CONFIG_MSDOS_PARTITION=y
 # CONFIG_BOOTPARAM is not set
 # CONFIG_DUMPTOFLASH is not set
 # CONFIG_NO_KERNEL_MSG is not set
-# CONFIG_BDM_DISABLE is not set
 
 #
 # Security options
arch/m68knommu/platform/5307/config.c +0 -9
index 6040821..e356e4a 100644
@@ -116,15 +116,6 @@ void config_BSP(char *commandp, int size)
 #endif
 
        mach_reset = coldfire_reset;
-
-#ifdef MCF_BDM_DISABLE
-       /*
-        * Disable the BDM clocking.  This also turns off most of the rest of
-        * the BDM device.  This is good for EMC reasons. This option is not
-        * incompatible with the memory protection option.
-        */
-       wdebug(MCFDEBUG_CSR, MCFDEBUG_CSR_PSTCLK);
-#endif
 }
 
 /***************************************************************************/
arch/m68knommu/platform/532x/config.c +0 -0
index f77328b..4166ce5 100644
@@ -98,15 +98,6 @@ void config_BSP(char *commandp, int size)
        mcf_timervector = 64+32;
        mcf_profilevector = 64+33;
        mach_reset = coldfire_reset;

arch/m68knommu/platform/532x/config.c void config_BSP(char *commandp, int size) · line 101

Quoted 10 lines
arch/m68knommu/platform/532x/config.c +0 -9
-
-#ifdef MCF_BDM_DISABLE
-       /*
-        * Disable the BDM clocking.  This also turns off most of the rest of
-        * the BDM device.  This is good for EMC reasons. This option is not
-        * incompatible with the memory protection option.
-        */
-       wdebug(MCFDEBUG_CSR, MCFDEBUG_CSR_PSTCLK);
-#endif
 }

Maybe someone wanted to write "#ifdef CONFIG_BDM_DISABLE"?

author
#2 lore raw

Re: [PATCH] m68knommu: Removing config variable BDM_DISABLE

In reply to Jiri Olsa
Quoted 71 lines · Marcin S'lusarz

2007/11/15, Jiri Olsa <[email protected]>:

Quoted 70 lines

Removing config variable BDM_DISABLE, since it is not used Removing #ifdef MCF_BDM_DISABLE code , since MCF_BDM_DISABLE is not defined

Signed-off-by Jiri Olsa <[email protected]>
---
 arch/m68knommu/Kconfig.debug          |    6 ------
 arch/m68knommu/defconfig              |    1 -
 arch/m68knommu/platform/5307/config.c |    9 ---------
 arch/m68knommu/platform/532x/config.c |    9 ---------
 4 files changed, 0 insertions(+), 25 deletions(-)
arch/m68knommu/Kconfig.debug +0 -6
index 9ff47bd..2784b46 100644
@@ -33,10 +33,4 @@ config NO_KERNEL_MSG
        help
          Do not output any debug BUG messages within the kernel.
 
-config BDM_DISABLE
-       bool "Disable BDM signals"
-       depends on (EXPERIMENTAL && COLDFIRE)
-       help
-         Disable the ColdFire CPU's BDM signals.
-
 endmenu
arch/m68knommu/defconfig +0 -1
index 5a0ecaa..fa44eea 100644
@@ -599,7 +599,6 @@ CONFIG_MSDOS_PARTITION=y
 # CONFIG_BOOTPARAM is not set
 # CONFIG_DUMPTOFLASH is not set
 # CONFIG_NO_KERNEL_MSG is not set
-# CONFIG_BDM_DISABLE is not set
 
 #
 # Security options
arch/m68knommu/platform/5307/config.c +0 -9
index 6040821..e356e4a 100644
@@ -116,15 +116,6 @@ void config_BSP(char *commandp, int size)
 #endif
 
        mach_reset = coldfire_reset;
-
-#ifdef MCF_BDM_DISABLE
-       /*
-        * Disable the BDM clocking.  This also turns off most of the rest of
-        * the BDM device.  This is good for EMC reasons. This option is not
-        * incompatible with the memory protection option.
-        */
-       wdebug(MCFDEBUG_CSR, MCFDEBUG_CSR_PSTCLK);
-#endif
 }
 
 /***************************************************************************/
arch/m68knommu/platform/532x/config.c +0 -4
index f77328b..4166ce5 100644
@@ -98,15 +98,6 @@ void config_BSP(char *commandp, int size)
        mcf_timervector = 64+32;
        mcf_profilevector = 64+33;
        mach_reset = coldfire_reset;
-
-#ifdef MCF_BDM_DISABLE
-       /*
-        * Disable the BDM clocking.  This also turns off most of the rest of
Quoted 9 lines

arch/m68knommu/platform/532x/config.c void config_BSP(char *commandp, int size) · line 101

Quoted 6 lines
arch/m68knommu/platform/532x/config.c +0 -5
-        * the BDM device.  This is good for EMC reasons. This option is not
-        * incompatible with the memory protection option.
-        */
-       wdebug(MCFDEBUG_CSR, MCFDEBUG_CSR_PSTCLK);
-#endif
 }

Maybe someone wanted to write "#ifdef CONFIG_BDM_DISABLE"?

who can tell? I'll try to find out...

#3 lore raw

Re: [PATCH] m68knommu: Removing config variable BDM_DISABLE

In reply to Jiri Olsa
Quoted 81 lines · Jiri Olsa
Quoted 70 lines · Marcin S'lusarz

2007/11/15, Jiri Olsa <[email protected]>:

Quoted 69 lines

Removing config variable BDM_DISABLE, since it is not used Removing #ifdef MCF_BDM_DISABLE code , since MCF_BDM_DISABLE is not defined

Signed-off-by Jiri Olsa <[email protected]>
---
 arch/m68knommu/Kconfig.debug          |    6 ------
 arch/m68knommu/defconfig              |    1 -
 arch/m68knommu/platform/5307/config.c |    9 ---------
 arch/m68knommu/platform/532x/config.c |    9 ---------
 4 files changed, 0 insertions(+), 25 deletions(-)
arch/m68knommu/Kconfig.debug +0 -6
index 9ff47bd..2784b46 100644
@@ -33,10 +33,4 @@ config NO_KERNEL_MSG
        help
          Do not output any debug BUG messages within the kernel.
 
-config BDM_DISABLE
-       bool "Disable BDM signals"
-       depends on (EXPERIMENTAL && COLDFIRE)
-       help
-         Disable the ColdFire CPU's BDM signals.
-
 endmenu
arch/m68knommu/defconfig +0 -1
index 5a0ecaa..fa44eea 100644
@@ -599,7 +599,6 @@ CONFIG_MSDOS_PARTITION=y
 # CONFIG_BOOTPARAM is not set
 # CONFIG_DUMPTOFLASH is not set
 # CONFIG_NO_KERNEL_MSG is not set
-# CONFIG_BDM_DISABLE is not set
 
 #
 # Security options
arch/m68knommu/platform/5307/config.c +0 -9
index 6040821..e356e4a 100644
@@ -116,15 +116,6 @@ void config_BSP(char *commandp, int size)
 #endif
 
        mach_reset = coldfire_reset;
-
-#ifdef MCF_BDM_DISABLE
-       /*
-        * Disable the BDM clocking.  This also turns off most of the rest of
-        * the BDM device.  This is good for EMC reasons. This option is not
-        * incompatible with the memory protection option.
-        */
-       wdebug(MCFDEBUG_CSR, MCFDEBUG_CSR_PSTCLK);
-#endif
 }
 
 /***************************************************************************/
arch/m68knommu/platform/532x/config.c +0 -3
index f77328b..4166ce5 100644
@@ -98,15 +98,6 @@ void config_BSP(char *commandp, int size)
        mcf_timervector = 64+32;
        mcf_profilevector = 64+33;
        mach_reset = coldfire_reset;
-
-#ifdef MCF_BDM_DISABLE
-       /*
Quoted 9 lines

arch/m68knommu/platform/532x/config.c void config_BSP(char *commandp, int size) · line 101

Quoted 7 lines
arch/m68knommu/platform/532x/config.c +0 -6
-        * Disable the BDM clocking.  This also turns off most of the rest of
-        * the BDM device.  This is good for EMC reasons. This option is not
-        * incompatible with the memory protection option.
-        */
-       wdebug(MCFDEBUG_CSR, MCFDEBUG_CSR_PSTCLK);
-#endif
 }

Maybe someone wanted to write "#ifdef CONFIG_BDM_DISABLE"?

Quoted 1 line

who can tell? I'll try to find out...

That is right. s/MCF_BDM_DISABLE/CONFIG_BDM_DISABLE/ is the more correct fix.

Regards
Greg

Signature · 5 lines
------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Dude       EMAIL:     [email protected]
Secure Computing Corporation                PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com