Skip to contentSkip to conversation

Relax the module get/put in ip_vs_app.c

PATCH In review Pavel Emelyanov 3 participants 3 messages Nov 19, 2007 – Nov 20, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 1/1 Relax the module get/put in ip_vs_app.c

Both try_module_get/module_put already handle the module == NULL case, so no need in manual checking.

This patch fits both net-2.6 and net-2.6.25.

Signed-off-by Pavel Emelyanov <[email protected]>

---

net/ipv4/ipvs/ip_vs_app.c +2 -7
index 664cb8e..535abe0 100644
@@ -51,18 +51,13 @@ static DEFINE_MUTEX(__ip_vs_app_mutex);
  */
 static inline int ip_vs_app_get(struct ip_vs_app *app)
 {
-	/* test and get the module atomically */
-	if (app->module)
-		return try_module_get(app->module);
-	else
-		return 1;
+	return try_module_get(app->module);
 }
 
 
 static inline void ip_vs_app_put(struct ip_vs_app *app)
 {
-	if (app->module)
-		module_put(app->module);
+	module_put(app->module);
 }