Skip to contentSkip to conversation

Compilation for CONFIG_INET=n case

PATCH Applied Pavel Emelyanov 2 participants 2 messages Nov 21, 2007 – Nov 22, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Pavel Emelyanov

author
#0 lore raw

PATCH 1/1 Compilation for CONFIG_INET=n case

Found this occasionally.

The CONFIG_INET=n is hardly ever set, but if it is the irlan_eth_send_gratuitous_arp() compilation should produce a warning about unused variable in_dev.

Too pedantic? :)

Signed-off-by Pavel Emelyanov <[email protected]>

---

net/irda/irlan/irlan_eth.c +1 -1
index 7f9c854..c682207 100644
@@ -296,6 +296,7 @@ void irlan_eth_flow_indication(void *instance, void *sap, LOCAL_FLOW flow)
  */
 void irlan_eth_send_gratuitous_arp(struct net_device *dev)
 {
+#ifdef CONFIG_INET
 	struct in_device *in_dev;
 
 	/*

@@ -303,7 +304,6 @@ void irlan_eth_send_gratuitous_arp(struct net_device *dev)
 	 * is useful if we have changed access points on the same
 	 * subnet.
 	 */
-#ifdef CONFIG_INET
 	IRDA_DEBUG(4, "IrLAN: Sending gratuitous ARP\n");
 	rcu_read_lock();
 	in_dev = __in_dev_get_rcu(dev);
Applied
#1 lore raw
Quoted 9 lines · Pavel Emelyanov

Found this occasionally.

The CONFIG_INET=n is hardly ever set, but if it is the irlan_eth_send_gratuitous_arp() compilation should produce a warning about unused variable in_dev.

Too pedantic? :)

Signed-off-by Pavel Emelyanov <[email protected]>

Not too pedantic yet, please keep trying :)

Applied to net-2.6. Thanks!

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt