Skip to contentSkip to conversation

qed: select ZLIB_INFLATE

PATCH Applied Arnd Bergmann 2 participants 2 messages Nov 10, 2015

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 qed: select ZLIB_INFLATE

The newly added qlogic qed driver uses the zlib library, but misses the dependency:

drivers/built-in.o: In function `qed_alloc_stream_mem':
drivers/net/ethernet/qlogic/qed/qed_main.c:707: undefined reference to zlib_inflate_workspacesize' drivers/built-in.o: In function qed_unzip_data':
drivers/net/ethernet/qlogic/qed/qed_main.c:675: undefined reference to `zlib_inflateInit2'

This changes Kconfig to always select zlib when needed.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes fe56b9e6a8d9 ("qed: Add module with basic common support")

---
Found on ARM randconfig builds

drivers/net/ethernet/qlogic/Kconfig +1 -0
index 30a6f246dfc9..ddcfcab034c2 100644
@@ -94,6 +94,7 @@ config NETXEN_NIC
 config QED
 	tristate "QLogic QED 25/40/100Gb core driver"
 	depends on PCI
+	select ZLIB_INFLATE
 	---help---
 	  This enables the support for ...
maintainer Applied
#1 lore raw

From: Arnd Bergmann <[email protected]>
Date: Tue, 10 Nov 2015 11:28:15 +0100

Quoted 8 lines

The newly added qlogic qed driver uses the zlib library, but misses the dependency:

drivers/built-in.o: In function `qed_alloc_stream_mem':
drivers/net/ethernet/qlogic/qed/qed_main.c:707: undefined reference to zlib_inflate_workspacesize' drivers/built-in.o: In function qed_unzip_data':
drivers/net/ethernet/qlogic/qed/qed_main.c:675: undefined reference to `zlib_inflateInit2'

Quoted 6 lines

This changes Kconfig to always select zlib when needed.

Signed-off-by Arnd Bergmann <[email protected]>
Fixes fe56b9e6a8d9 ("qed: Add module with basic common support")

---
Found on ARM randconfig builds

Applied, thanks.