Skip to contentSkip to conversation

NET: dmfe.c : fix access to card's pci config space in D3

PATCH In review Maxim Levitsky 2 participants 4 messages Nov 22, 2007 – Nov 24, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Maxim Levitsky

author
#0 lore raw

Hi,

I somehow assumed that pci_save_state should be called while device is powered off, but actually the opposite is true.

Thus I am sending this patch to fix it.

Sorry for this mistake,
Best regards,
Maxim Levitsky

author
#1 lore raw

PATCH 1/1 NET: dmfe: don't access configuration space in D3 state

Quoted 1 line

From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001

From: Maxim Levitsky <[email protected]>
Date: Fri, 23 Nov 2007 01:15:36 +0200
Subject: [PATCH] NET: dmfe: don't access configuration space in D3 state
Accidently I reversed the order of pci_save_state and pci_set_power_state in .suspend()/.resume() callbacks

Signed-off-by Maxim Levitsky <[email protected]>
---
 drivers/net/tulip/dmfe.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/tulip/dmfe.c +2 -2
index 390d02d..9d199b0 100644
@@ -2118,8 +2118,8 @@ static int dmfe_suspend(struct pci_dev *pci_dev, pm_message_t state)
 	pci_enable_wake(pci_dev, PCI_D3cold, 1);
 
 	/* Power down device*/
-	pci_set_power_state(pci_dev, pci_choose_state (pci_dev,state));
 	pci_save_state(pci_dev);
+	pci_set_power_state(pci_dev, pci_choose_state (pci_dev,state));
 
 	return 0;
 }

@@ -2129,8 +2129,8 @@ static int dmfe_resume(struct pci_dev *pci_dev)
 	struct net_device *dev = pci_get_drvdata(pci_dev);
 	u32 tmp;
 
-	pci_restore_state(pci_dev);
 	pci_set_power_state(pci_dev, PCI_D0);
+	pci_restore_state(pci_dev);
 
 	/* Re-initilize DM910X board */
 	dmfe_init_dm910x(dev);
Signature · 1 line
1.5.3.4
#2 lore raw

Re: [PATCH] NET: dmfe: don't access configuration space in D3 state

Quoted 7 lines · Maxim Levitsky
Quoted 1 line

From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001

From: Maxim Levitsky <[email protected]>
Date: Fri, 23 Nov 2007 01:15:36 +0200
Subject: [PATCH] NET: dmfe: don't access configuration space in D3 state
Accidently I reversed the order of pci_save_state and pci_set_power_state in .suspend()/.resume() callbacks

Quoted 5 lines
Signed-off-by Maxim Levitsky <[email protected]>
---
 drivers/net/tulip/dmfe.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

applied #upstream-fixes, after hand-editing patch changelog taking by git-am from email body

author
#3 lore raw

Re: [PATCH] NET: dmfe: don't access configuration space in D3 state

Quoted 8 lines · On Saturday 24 November 2007 05:10:37 Jeff Garzik wrote:
Quoted 7 lines · Maxim Levitsky
Quoted 1 line

From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001

From: Maxim Levitsky <[email protected]>
Date: Fri, 23 Nov 2007 01:15:36 +0200
Subject: [PATCH] NET: dmfe: don't access configuration space in D3 state
Accidently I reversed the order of pci_save_state and pci_set_power_state in .suspend()/.resume() callbacks

Quoted 11 lines
Quoted 5 lines
Signed-off-by Maxim Levitsky <[email protected]>
---
 drivers/net/tulip/dmfe.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

applied #upstream-fixes, after hand-editing patch changelog taking by git-am from email body

Hi,

Thanks,
Next time I will be more careful with changelogs.

Best regards,
Maxim Levitsky